[LLDB] [cmake]: Add local module directory to search path for standalone build

[mgorny]

Summary

Add cmake/modules directory to cmake module search path as otherwise CMake fails to find CheckAtomic module when performing standalone build.

Note: I don't have commit access

[Eugene.Zelenko]

I think will be better to use LLVM_MAIN_SRC_DIR.

[krytarowski]

The proper way to fix it is to install CheckAtomic from LLVM/Clang.

See D22999

[mgorny]

I think will be better to use LLVM_MAIN_SRC_DIR.

That won't work since it would require source dir to be still available when building LLDB. The point of stand-alone build is to avoid that, and after applying this patch (and the regex fix), I'm able to achieve that. Using LLVM_MAIN_SRC_DIR would be a regression.

[mgorny]

In D23881#525401, @krytarowski wrote:

The proper way to fix it is to install CheckAtomic from LLVM/Clang.

See D22999

Wasn't that rejected?

[krytarowski]

In D23881#525405, @mgorny wrote:

In D23881#525401, @krytarowski wrote:

The proper way to fix it is to install CheckAtomic from LLVM/Clang.

See D22999

Wasn't that rejected?

There was rejected a proposal to add CheckAtomic copy to LLDB. Not a proposal to install CheckAtomic for more customers of LLVM.

[mgorny]

In D23881#525411, @krytarowski wrote:

In D23881#525405, @mgorny wrote:

In D23881#525401, @krytarowski wrote:

The proper way to fix it is to install CheckAtomic from LLVM/Clang.

See D22999

Wasn't that rejected?

There was rejected a proposal to add CheckAtomic copy to LLDB. Not a proposal to install CheckAtomic for more customers of LLVM.

Ah, sorry, I didn't read that thoroughly. Should I create a patch for that, or will you handle it from here?

[krytarowski]

In D23881#525420, @mgorny wrote:

In D23881#525411, @krytarowski wrote:

In D23881#525405, @mgorny wrote:

In D23881#525401, @krytarowski wrote:

The proper way to fix it is to install CheckAtomic from LLVM/Clang.

See D22999

Wasn't that rejected?

There was rejected a proposal to add CheckAtomic copy to LLDB. Not a proposal to install CheckAtomic for more customers of LLVM.

Ah, sorry, I didn't read that thoroughly. Should I create a patch for that, or will you handle it from here?

Please create it and I will test it on NetBSD.

Please add reviewers from D22999

cmake/modules/LLDBStandalone.cmake

if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
   set(LLVM_LIBRARY_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX})
   if(WIN32 OR CYGWIN)
     # DLL platform -- put DLLs into bin.
     set(LLVM_SHLIB_OUTPUT_INTDIR ${LLVM_RUNTIME_OUTPUT_INTDIR})
   else()
     set(LLVM_SHLIB_OUTPUT_INTDIR ${LLVM_LIBRARY_OUTPUT_INTDIR})
   endif()
 
+  list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules")
   include(AddLLVM)
   include(HandleLLVMOptions)
   include(CheckAtomic)
 
   if (PYTHON_EXECUTABLE STREQUAL "")
     set(Python_ADDITIONAL_VERSIONS 3.5 3.4 3.3 3.2 3.1 3.0 2.7 2.6 2.5)
     include(FindPythonInterp)
     if( NOT PYTHONINTERP_FOUND )