This is an archive of the discontinued LLVM Phabricator instance.

driver: Support checking for rlimits via cmake (when bootstrapping)
ClosedPublic

Authored by mgorny on Aug 20 2016, 4:56 AM.

Details

Summary

Add a cmake check for sys/resource.h and replace the has_include() check with its result, in order to make it possible to use rlimits when building with compilers not supporting has_include() -- i.e. when bootstrapping.

// Please also re-apply dfcd52eb1d8e5d322404b40414cb7331c7380a8c (llvm-config.h fix)

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny updated this revision to Diff 68775.Aug 20 2016, 4:56 AM
mgorny retitled this revision from to driver: Support checking for rlimits via cmake (when bootstrapping).
mgorny updated this object.
mgorny added reviewers: rsmith, vsk.
mgorny added a subscriber: cfe-commits.
vsk resigned from this revision.Aug 23 2016, 10:34 AM
vsk edited reviewers, added: beanz; removed: vsk.

I don't see any issues with this patch, but I'm generally unfamiliar with the bootstrapping process and think Chris could give a better review.

(Also, as Richard pointed out earlier, including llvm-config.h might not be the right solution.)

beanz accepted this revision.Aug 23 2016, 10:39 AM
beanz edited edge metadata.

Patch LGTM.

This revision is now accepted and ready to land.Aug 23 2016, 10:39 AM

Thanks for the review. Could you commit it for me, please? I don't have commit access.

This revision was automatically updated to reflect the committed changes.