Adding three image processing benchmarks generated by Halide.
Based on the current inputs used they are fairly small, but they may be
extended in the future with larger testing inputs.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Adding a note: These benchmarks use libpng, which or may not be installed on the bots.
Should the lib be built as part of the test-suite, and added as a dependency here? Other options?
Would it possible to commit a simple random number generator instead and generate the array data with this generator and a known seed? (I assume here that it doesn't make a difference if the data is a realistic image data or just "random")
Right, I was about to suggest we just load the images stored as raw array of bytes instead of png, but random may work as well.
Bitcode files aren't generated with a released compiler, can you use 3.9?
Bitcode/Benchmarks/Halide/CMakeLists.txt | ||
---|---|---|
2 โ | (On Diff #69924) | What's using pthread? |
Bitcode/Benchmarks/Halide/CMakeLists.txt | ||
---|---|---|
3 โ | (On Diff #71020) | The halide runtime. |
LGTM, thanks Alina.
Could we check-in the Halide source for the benchmarks as well as a reference for how the bitcode was generated?
Yes. Let me see what's the best way to do that.
I'm inclined to include a small doc on the code generation and point to Halide's github sources, rather than add them here.
I'll make a separate patch for that.
Reason for the additional update: I had played with the blur algorithm and schedule and the one in this patch was not the same as Halide trunk. The documentation I plan to add will point to the Halide trunk, and I don't expect major changes in the future, so making sure the two match.