This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Update AMDGPURuntimeMetadata.h for enums of address space qualifiers
AbandonedPublic

Authored by yaxunl on Aug 9 2016, 11:26 AM.

Reviewers

yaxunl retitled this revision from to AMDGPU: Update AMDGPURuntimeMetadata.h for enums of address space qualifiers.

yaxunl updated this object.

yaxunl added reviewers: nhaustov, arsenm.

lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
136–141	Should probably have the values for flat and region

lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
136–141	This is for OpenCL kernel argument reflection. flat and region address spaces do not show up in kernel arguments.

lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
136–141	Region would if that extension were ever finished. There's no real reason we can't support flat either. The values should be there to make sure they are reserved / keep the same values as the address space enum

lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
136–141	What is the value for region and flat address space? Thanks.

lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
136–141	generic is 4 and region is 5

Added generic and region enum value.

superseded by D23424

Path

Size

lib/

Target/

AMDGPU/

7 lines

Context not available.
	WriteOnly = 2,	WriteOnly = 2,
	ReadWrite = 3,	ReadWrite = 3,
	};	};

		enum AddressSpaceQualifer : uint8_t {
		Private = 0,
		Global = 1,
		Constant = 2,
		Local = 3,
		};
		arsenmUnsubmitted Not Done Reply Inline Actions Should probably have the values for flat and region arsenm: Should probably have the values for flat and region
		yaxunlAuthorUnsubmitted Not Done Reply Inline Actions This is for OpenCL kernel argument reflection. flat and region address spaces do not show up in kernel arguments. yaxunl: This is for OpenCL kernel argument reflection. flat and region address spaces do not show up in…
		arsenmUnsubmitted Not Done Reply Inline Actions Region would if that extension were ever finished. There's no real reason we can't support flat either. The values should be there to make sure they are reserved / keep the same values as the address space enum arsenm: Region would if that extension were ever finished. There's no real reason we can't support flat…
		yaxunlAuthorUnsubmitted Not Done Reply Inline Actions What is the value for region and flat address space? Thanks. yaxunl: What is the value for region and flat address space? Thanks.
		arsenmUnsubmitted Not Done Reply Inline Actions generic is 4 and region is 5 arsenm: generic is 4 and region is 5
	} // namespace KernelArg	} // namespace KernelArg
	} // namespace RuntimeMD	} // namespace RuntimeMD
	} // namespace AMDGPU	} // namespace AMDGPU
Context not available.