Page MenuHomePhabricator

[LLVMCov] Swapped the line and count columns.
ClosedPublic

Authored by MaggieYi on Aug 8 2016, 2:01 PM.

Details

Summary

In the coverage report, the line and count columns have been swapped to make it more readable.

Diff Detail

Repository
rL LLVM

Event Timeline

MaggieYi updated this revision to Diff 67221.Aug 8 2016, 2:01 PM
MaggieYi retitled this revision from to [LLVMCov] Swapped the line and count columns..
MaggieYi updated this object.
MaggieYi added reviewers: vsk, davidxl, bogner.
MaggieYi added a subscriber: llvm-commits.
vsk accepted this revision.Aug 8 2016, 4:46 PM
vsk edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Aug 8 2016, 4:46 PM
MaggieYi updated this revision to Diff 67330.Aug 9 2016, 6:54 AM
MaggieYi edited edge metadata.

Thanks Vedant.

When the line and count columns are swapped, the compiler-rt profile regression tests need to be updated as well. I have added another patch to update the compiler-rt regression tests. Since llvm and compile-rt are in the different repositories, should I commit two patches separately? (This will cause test failures).

MaggieYi updated this revision to Diff 67339.Aug 9 2016, 7:15 AM

Fix a linux test.

vsk added a comment.Aug 9 2016, 9:40 AM

When the line and count columns are swapped, the compiler-rt profile regression tests need to be updated as well. I have added another patch to update the compiler-rt regression tests. Since llvm and compile-rt are in the different repositories, should I commit two patches separately? (This will cause test failures).

I think it would be fine to commit the two patches separately but simultaneously. The bots may go red temporarily, but that won't be alarming if you mention that a follow-up commit in compiler-rt is needed in your commit message.

Do you have a linux machine to test the changes to test/profile/Linux/coverage_*? If not, I can help with that.

In D23281#510048, @vsk wrote:

I think it would be fine to commit the two patches separately but simultaneously. The bots may go red temporarily, but that won't be alarming if you mention that a follow-up commit in compiler-rt is needed in your commit message.

Do you have a linux machine to test the changes to test/profile/Linux/coverage_*? If not, I can help with that.

Thanks very much for your help. I have a linux machine to run the compiler-rt tests. With the change, all llvm/clang/compiler-rt regression tests passed.

I will follow your advice to commit two patches separately but simultaneously.

This revision was automatically updated to reflect the committed changes.

Hello Vedant,

I have committed the llvm-cov patch to llvm. When I try to commit compiler-rt patch, I can't commit the patch. Could you help me commit the compiler-rt patch?

Many thanks,