Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

MaggieYi (Ying Yi)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 5:38 AM (422 w, 3 d)

Recent Activity

Wed, Sep 6

MaggieYi committed rG61d615404465: [llvm-cov] Fix the test of bnary-id-lookup.c after the commit cd8fe1dbc. (authored by MaggieYi).
[llvm-cov] Fix the test of bnary-id-lookup.c after the commit cd8fe1dbc.
Wed, Sep 6, 8:45 AM · Restricted Project, Restricted Project

Thu, Aug 31

MaggieYi added a comment to D158614: [UBSan] Disable the function sanitizer on an execute-only target..

Thanks @MaskRay.

Thu, Aug 31, 1:39 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Aug 30

MaggieYi committed rG9ef536a12ea6: [UBSan] Disable the function and kcfi sanitizers on an execute-only target. (authored by MaggieYi).
[UBSan] Disable the function and kcfi sanitizers on an execute-only target.
Wed, Aug 30, 9:20 AM · Restricted Project, Restricted Project
MaggieYi closed D158614: [UBSan] Disable the function sanitizer on an execute-only target..
Wed, Aug 30, 9:20 AM · Restricted Project, Restricted Project, Restricted Project
MaggieYi updated the diff for D158614: [UBSan] Disable the function sanitizer on an execute-only target..

Thanks @MaskRay. The patch is updated.

Wed, Aug 30, 4:26 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Aug 29

MaggieYi added inline comments to D158614: [UBSan] Disable the function sanitizer on an execute-only target..
Tue, Aug 29, 1:31 PM · Restricted Project, Restricted Project, Restricted Project
MaggieYi updated the diff for D158614: [UBSan] Disable the function sanitizer on an execute-only target..

Thanks @MaskRay, I have updated the patch following your suggestions.

Tue, Aug 29, 1:30 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Aug 25

MaggieYi added a comment to D158614: [UBSan] Disable the function sanitizer on an execute-only target..

Thanks @simon_tatham and @MaskRay for the quick code review.

Fri, Aug 25, 2:06 AM · Restricted Project, Restricted Project, Restricted Project
MaggieYi updated the diff for D158614: [UBSan] Disable the function sanitizer on an execute-only target..

The changes include:

Fri, Aug 25, 1:40 AM · Restricted Project, Restricted Project, Restricted Project

Aug 23 2023

MaggieYi requested review of D158614: [UBSan] Disable the function sanitizer on an execute-only target..
Aug 23 2023, 6:49 AM · Restricted Project, Restricted Project, Restricted Project

Apr 18 2023

MaggieYi abandoned D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol..
Apr 18 2023, 1:30 AM · Restricted Project, Restricted Project, Restricted Project

Apr 17 2023

MaggieYi added a comment to D148410: [Parse] Remove TimeTraceScope for "ParseTemplate".

Thanks @MaskRay, the fix is fine for me.

Apr 17 2023, 2:29 AM · Restricted Project, Restricted Project

Apr 13 2023

MaggieYi added a comment to D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol..

Gentle ping ...

Apr 13 2023, 12:55 AM · Restricted Project, Restricted Project, Restricted Project

Apr 4 2023

MaggieYi added a comment to D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol..

Analysis the issue using the above simple example:

Apr 4 2023, 4:35 AM · Restricted Project, Restricted Project, Restricted Project
MaggieYi added a comment to D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol..

A simple test to reproduce the issue:

% cat main.cpp
#include "1.h"
#include "2.h"
int foo();
Apr 4 2023, 4:34 AM · Restricted Project, Restricted Project, Restricted Project
MaggieYi requested review of D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol..
Apr 4 2023, 4:17 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2023

MaggieYi committed rG94dd4766a61b: [Coverage] Fix an issue: a statement after calling 'assert()' function is… (authored by MaggieYi).
[Coverage] Fix an issue: a statement after calling 'assert()' function is…
Mar 2 2023, 1:16 AM · Restricted Project, Restricted Project
MaggieYi closed D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'.
Mar 2 2023, 1:15 AM · Restricted Project, Restricted Project

Mar 1 2023

MaggieYi added inline comments to D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'.
Mar 1 2023, 7:38 AM · Restricted Project, Restricted Project
MaggieYi updated the diff for D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'.

Thanks Zequan. I have added two tests following your suggestion.

Mar 1 2023, 7:36 AM · Restricted Project, Restricted Project

Feb 27 2023

MaggieYi added a comment to D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'.

Gentle ping ...

Feb 27 2023, 3:55 AM · Restricted Project, Restricted Project

Feb 20 2023

MaggieYi added reviewers for D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed': probinson, ormris.
Feb 20 2023, 2:44 AM · Restricted Project, Restricted Project
MaggieYi requested review of D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'.
Feb 20 2023, 2:32 AM · Restricted Project, Restricted Project

Nov 14 2022

MaggieYi committed rGca875cb4fe13: [ThinLTO] a ThinLTO warning is added if cache_size_bytes or cache_size_files is… (authored by MaggieYi).
[ThinLTO] a ThinLTO warning is added if cache_size_bytes or cache_size_files is…
Nov 14 2022, 4:33 AM · Restricted Project, Restricted Project
MaggieYi closed D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..
Nov 14 2022, 4:33 AM · Restricted Project, Restricted Project, Restricted Project

Nov 11 2022

MaggieYi added a comment to D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

@MaskRay, thanks again. I have marked comments as done.

Nov 11 2022, 1:30 AM · Restricted Project, Restricted Project, Restricted Project
MaggieYi added inline comments to D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..
Nov 11 2022, 1:25 AM · Restricted Project, Restricted Project, Restricted Project
MaggieYi updated the diff for D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

Removed '2>&1' from 'RUN: %python'.

Nov 11 2022, 1:24 AM · Restricted Project, Restricted Project, Restricted Project

Nov 9 2022

MaggieYi added a comment to D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

@MaskRay, please let me know if there are any further changes required. Thanks.

Nov 9 2022, 1:18 PM · Restricted Project, Restricted Project, Restricted Project
MaggieYi updated the diff for D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

@tejohnson and @MaskRay, thanks for reviewing the patch.

Nov 9 2022, 12:59 PM · Restricted Project, Restricted Project, Restricted Project

Nov 7 2022

MaggieYi added inline comments to D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..
Nov 7 2022, 2:21 PM · Restricted Project, Restricted Project, Restricted Project
MaggieYi updated the diff for D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

Thanks for your comments.

Nov 7 2022, 2:11 PM · Restricted Project, Restricted Project, Restricted Project

Nov 2 2022

MaggieYi updated the diff for D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

Update the patch following the reviewers' comments, which include:

Nov 2 2022, 10:51 AM · Restricted Project, Restricted Project, Restricted Project

Oct 31 2022

MaggieYi added a comment to D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

I think I might be able to incorporate checkCacheCapacity into pruneCache. I am working on this.

Oct 31 2022, 9:12 AM · Restricted Project, Restricted Project, Restricted Project
MaggieYi added a comment to D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

Gentle ping ..

Oct 31 2022, 5:28 AM · Restricted Project, Restricted Project, Restricted Project

Oct 20 2022

MaggieYi added inline comments to D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..
Oct 20 2022, 9:39 AM · Restricted Project, Restricted Project, Restricted Project
MaggieYi updated the diff for D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

The changes include:

Oct 20 2022, 9:33 AM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2022

MaggieYi updated the diff for D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

Updating the correct patch.

Oct 19 2022, 11:08 AM · Restricted Project, Restricted Project, Restricted Project
MaggieYi added a comment to D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

Thanks Teresa and Fangrui for the comments. Sorry for the delay in updating the patch. I have been trying to find a way to get the warning invoked by all cache users.

Oct 19 2022, 10:51 AM · Restricted Project, Restricted Project, Restricted Project
MaggieYi updated the diff for D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..

Update the patch following the reviewers comments, which include:

Oct 19 2022, 10:31 AM · Restricted Project, Restricted Project, Restricted Project

Oct 10 2022

MaggieYi requested review of D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job..
Oct 10 2022, 8:18 AM · Restricted Project, Restricted Project, Restricted Project

Sep 5 2022

MaggieYi committed rG5de4d97a00b2: Driver tests: remove `REQUIRES: x86-registered-target` and set `--sysroot=""`… (authored by MaggieYi).
Driver tests: remove `REQUIRES: x86-registered-target` and set `--sysroot=""`…
Sep 5 2022, 2:01 AM · Restricted Project, Restricted Project

Sep 2 2022

MaggieYi requested review of D133191: Driver test: remove `REQUIRES: x86-registered-target` and set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`..
Sep 2 2022, 2:37 AM · Restricted Project, Restricted Project

Aug 31 2022

MaggieYi committed rG41b1c9ff7014: Re-add the REQUIRES line to fix a failed build on builder llvm-clang-win-x… (authored by MaggieYi).
Re-add the REQUIRES line to fix a failed build on builder llvm-clang-win-x…
Aug 31 2022, 12:23 PM · Restricted Project, Restricted Project
MaggieYi committed rG0e5fe1cdacdc: Remove `REQUIRES: x86-registered-target` from ps4/ps5 driver tests (authored by MaggieYi).
Remove `REQUIRES: x86-registered-target` from ps4/ps5 driver tests
Aug 31 2022, 1:57 AM · Restricted Project, Restricted Project
MaggieYi closed D132950: Remove unnecessary `REQUIRES: x86-registered-target` from ps4/ps5 driver tests..
Aug 31 2022, 1:57 AM · Restricted Project, Restricted Project
MaggieYi added a comment to D132950: Remove unnecessary `REQUIRES: x86-registered-target` from ps4/ps5 driver tests..

Thanks Paul.

Aug 31 2022, 1:44 AM · Restricted Project, Restricted Project

Aug 30 2022

MaggieYi requested review of D132950: Remove unnecessary `REQUIRES: x86-registered-target` from ps4/ps5 driver tests..
Aug 30 2022, 8:41 AM · Restricted Project, Restricted Project

Jul 27 2022

MaggieYi committed rG8d46cb343f52: Emit a simple StackSizesSection on PS4. (authored by MaggieYi).
Emit a simple StackSizesSection on PS4.
Jul 27 2022, 1:41 AM · Restricted Project, Restricted Project
MaggieYi closed D130495: Have a simple StackSizesSection on PS4..
Jul 27 2022, 1:40 AM · Restricted Project, Restricted Project
MaggieYi committed rGbfe191dfa79b: Disable stack-sizes section by default for PS4. (authored by MaggieYi).
Disable stack-sizes section by default for PS4.
Jul 27 2022, 1:38 AM · Restricted Project, Restricted Project
MaggieYi closed D130493: Disable stack-sizes section by default for PS4..
Jul 27 2022, 1:38 AM · Restricted Project, Restricted Project

Jul 26 2022

MaggieYi updated the diff for D130493: Disable stack-sizes section by default for PS4..

Use Args.addOptInFlag instead of Args.hasFlag, thanks.

Jul 26 2022, 10:34 AM · Restricted Project, Restricted Project

Jul 25 2022

MaggieYi requested review of D130495: Have a simple StackSizesSection on PS4..
Jul 25 2022, 9:01 AM · Restricted Project, Restricted Project
MaggieYi requested review of D130493: Disable stack-sizes section by default for PS4..
Jul 25 2022, 8:47 AM · Restricted Project, Restricted Project

Apr 22 2022

MaggieYi committed rGb09ba4262076: Bug 51277: [DWARF] DW_AT_alignment incorrect when (authored by MaggieYi).
Bug 51277: [DWARF] DW_AT_alignment incorrect when
Apr 22 2022, 4:16 AM · Restricted Project, Restricted Project
MaggieYi closed D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present..
Apr 22 2022, 4:16 AM · debug-info, Restricted Project, Restricted Project
MaggieYi added inline comments to D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present..
Apr 22 2022, 2:41 AM · debug-info, Restricted Project, Restricted Project
MaggieYi updated the diff for D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present..
Apr 22 2022, 2:37 AM · debug-info, Restricted Project, Restricted Project

Apr 21 2022

MaggieYi updated the diff for D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present..

Thanks David, I have modified the test following your advice.

Apr 21 2022, 11:55 AM · debug-info, Restricted Project, Restricted Project

Apr 19 2022

MaggieYi requested review of D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present..
Apr 19 2022, 8:28 AM · debug-info, Restricted Project, Restricted Project

Mar 30 2021

MaggieYi updated subscribers of D99534: [dsymutil] Relocate DW_TAG_label.

Hi Jonas and Nico,

Mar 30 2021, 6:11 AM · Restricted Project
MaggieYi added a comment to D99534: [dsymutil] Relocate DW_TAG_label.

Hi Jonas,

Mar 30 2021, 2:59 AM · Restricted Project

Feb 24 2021

MaggieYi added a comment to D90479: [ValueTracking] ComputeKnownBits - minimum leading/trailing zero bits in LSHR/SHL (PR44526).

I've reverted for now - I took a quick look at the sanitizer test and couldn't grok whats going wrong, will try again when I'm awake :)

Feb 24 2021, 10:32 AM · Restricted Project
MaggieYi added a comment to D90479: [ValueTracking] ComputeKnownBits - minimum leading/trailing zero bits in LSHR/SHL (PR44526).

It seems that this commit has caused several test failures.

Feb 24 2021, 9:32 AM · Restricted Project

Sep 15 2020

MaggieYi added a comment to D87657: [DebugInfo] Remove dots from getFilenameByIndex return value.

Hi Petr Hosek,

Sep 15 2020, 8:25 AM · Restricted Project

May 20 2020

MaggieYi committed rGeba3dd52b14d: Github access test: remove unnecessary whitespaces. (authored by MaggieYi).
Github access test: remove unnecessary whitespaces.
May 20 2020, 2:08 AM

Nov 28 2017

MaggieYi updated the diff for D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally.

The previous patch doesn’t support the sequential commands, for example “mkdir existing_folder || true”. This caused sanitizer-windows test failed. The patch has been updated to support the sequential commands.

Nov 28 2017, 3:19 AM

Nov 23 2017

MaggieYi reopened D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally.

Reverted rL318911 since it broke the sanitizer-windows.

Nov 23 2017, 5:27 AM

Nov 20 2017

MaggieYi updated the diff for D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally.

The test of MC/AsmParser/preserve-comments-crlf.s failed since it uses the unsupported diff option --strip-trailing-cr. I updated the internal diff shell command to support this option.

Nov 20 2017, 4:23 PM

Nov 10 2017

MaggieYi updated the diff for D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally.

Optimised the patch by using python ‘getopt’ module.

Nov 10 2017, 2:08 PM

Nov 9 2017

MaggieYi updated the diff for D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally.

Updated the builtin diff shell to support ‘-u’, ‘-b’ and ‘-w’ options. Now, all llvm, and clang tests passed with both Python 2 and Python 3.

Nov 9 2017, 1:59 PM

Nov 7 2017

MaggieYi added a comment to D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally.
  1. I don't see any tests for the case where the commands *succeed*. Only for the case where they fail. Shouldn't we have some tests that verify the commands actually work?
Nov 7 2017, 6:30 AM
MaggieYi updated the diff for D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally.

The patch updated the test (valid-shell.txt) where lit internal shell commands succeeded.

Nov 7 2017, 6:14 AM

Nov 6 2017

MaggieYi added a comment to D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally.

Update: I actually do see where you're testing that they work, but I'm not convinced that the tests are sufficient. For several reasons.

  1. it doesn't test that the builtin command is actually run versus the OS command. It only tests that whatever command is run doesn't fail.
  1. It doesn't test that the result of the command is as expected, it only tests that it doesn't return an error. For a somewhat unrealistic illustration of this, imagine that all the commands just returned success without actually doing anything. The test as it is written now would pass.
Nov 6 2017, 5:34 AM
MaggieYi added a comment to D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally.
  1. Now that we have upwards of 6 builtin commands, I'm starting to think they should be separated into their own file. For example, lit/test/ShellBuiltins.py We could test them via unittests (e.g. see how BooleanExpression.py implements its unit tests).

What do you think?

Nov 6 2017, 5:33 AM

Nov 2 2017

MaggieYi created D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally.
Nov 2 2017, 2:10 PM

Oct 18 2016

MaggieYi added a comment to D25086: [llvm-cov] Add support for loading coverage from multiple objects.
In D25086#572183, @vsk wrote:

@MaggieYi ping, do you have the bandwidth to update this patch to use the new CoverageMapping::load API? If not, I can take a shot at it.

Oct 18 2016, 3:43 AM

Sep 30 2016

MaggieYi retitled D25086: [llvm-cov] Add support for loading coverage from multiple objects from to [llvm-cov] Allow llvm-cov to report the coverage counters across multiple elf files..
Sep 30 2016, 2:33 AM

Sep 27 2016

MaggieYi abandoned D24687: [llvm-cov] Add a project coverage summary above the index page..
Sep 27 2016, 3:44 AM

Sep 26 2016

MaggieYi abandoned D24586: [llvm-cov] Add filter and sort table functions to the index page..
Sep 26 2016, 12:25 AM

Sep 20 2016

MaggieYi updated the diff for D24687: [llvm-cov] Add a project coverage summary above the index page..
In D24687#546833, @vsk wrote:

I'd prefer to just tackle this issue in this patch. IMO it would be better to drop (or at least defer) the other changes.

Ok, I have updated the patch following your advice.

Sep 20 2016, 1:52 PM

Sep 19 2016

MaggieYi abandoned D24367: [llvm-cov] Provided easy navigation to find the previous and next report..

I agree with you and abandon this patch.

Sep 19 2016, 4:28 AM

Sep 16 2016

MaggieYi retitled D24687: [llvm-cov] Add a project coverage summary above the index page. from to [llvm-cov] Add a project coverage summary above the index page..
Sep 16 2016, 3:12 PM

Sep 14 2016

MaggieYi retitled D24586: [llvm-cov] Add filter and sort table functions to the index page. from to [llvm-cov] Add filter and sort table functions to the index page..
Sep 14 2016, 2:45 PM

Sep 13 2016

MaggieYi added inline comments to D24367: [llvm-cov] Provided easy navigation to find the previous and next report..
Sep 13 2016, 7:42 AM
MaggieYi updated the diff for D24367: [llvm-cov] Provided easy navigation to find the previous and next report..
In D24367#539047, @vsk wrote:

On a low level, I'm concerned about the unnecessary quadratic behavior in this patch. If "N = |SourceFiles|", then renderPageNavigation() does O(N) work and it's called O(N) times. Given that llvm+clang has over 2,400 source files, this could actually be noticeable. We already get user reports about llvm-cov being slow...

Sep 13 2016, 7:40 AM

Sep 12 2016

MaggieYi retitled D24457: [llvm-cov] - Included footer "Generated by llvm-cov -- llvm version <version number>" in the coverage report. from to [llvm-cov] - Included footer "Generated by llvm-cov -- llvm version <version number>" in the coverage report..
Sep 12 2016, 8:15 AM

Sep 9 2016

MaggieYi added reviewers for D24367: [llvm-cov] Provided easy navigation to find the previous and next report.: davidxl, bogner.
Sep 9 2016, 12:33 AM

Sep 8 2016

MaggieYi retitled D24367: [llvm-cov] Provided easy navigation to find the previous and next report. from to [llvm-cov] Provided easy navigation to find the previous and next report..
Sep 8 2016, 4:38 PM

Sep 5 2016

MaggieYi retitled D24241: [llvm-cov] Add the project summary to the text coverage report for each source file. from to [llvm-cov] Add the project summary to the text coverage report for each source file..
Sep 5 2016, 1:21 PM

Sep 2 2016

MaggieYi updated the diff for D23277: [llvm-cov] Add the "Goto first zero count" feature..

Thanks for your pseudocode . Two issues have been fixed.

Sep 2 2016, 2:00 PM

Sep 1 2016

MaggieYi updated the diff for D23277: [llvm-cov] Add the "Goto first zero count" feature..

Thanks for your explanation. I have updated the patch following your advice.

Sep 1 2016, 4:39 AM

Aug 30 2016

MaggieYi added a comment to D23277: [llvm-cov] Add the "Goto first zero count" feature..
In D23277#526594, @vsk wrote:

Thanks for splitting things up :).

I'm not sure that the javascript bit is needed. It looks like a way to remove/disable a link, but I don't see any issue with leaving the link active.

Aug 30 2016, 4:09 PM
MaggieYi updated the diff for D23277: [llvm-cov] Add the "Goto first zero count" feature..

Reused the existing native_separator.c test to check fully covered source file case.

Aug 30 2016, 3:58 PM

Aug 29 2016

MaggieYi updated the diff for D23922: [llvm-cov] Use the native path in the coverage report..

Thanks, the test has been added.

Aug 29 2016, 3:34 PM

Aug 28 2016

MaggieYi added inline comments to D23922: [llvm-cov] Use the native path in the coverage report..
Aug 28 2016, 12:35 PM
MaggieYi updated the diff for D23922: [llvm-cov] Use the native path in the coverage report..

Thanks Vedant, the patch has been updated following your comments.

Aug 28 2016, 12:25 PM

Aug 26 2016

MaggieYi retitled D23922: [llvm-cov] Use the native path in the coverage report. from to [llvm-cov] Use the native path in the coverage report..
Aug 26 2016, 8:19 AM

Aug 24 2016

MaggieYi updated the diff for D23277: [llvm-cov] Add the "Goto first zero count" feature..

Updating the patch to support the "Goto first zero count" feature.

Aug 24 2016, 2:02 PM