- User Since
- Aug 18 2015, 5:38 AM (422 w, 3 d)
Wed, Sep 6
Thu, Aug 31
Wed, Aug 30
Thanks @MaskRay. The patch is updated.
Tue, Aug 29
Thanks @MaskRay, I have updated the patch following your suggestions.
Fri, Aug 25
The changes include:
Aug 23 2023
Apr 18 2023
Apr 17 2023
Thanks @MaskRay, the fix is fine for me.
Apr 13 2023
Gentle ping ...
Apr 4 2023
Analysis the issue using the above simple example:
A simple test to reproduce the issue:
% cat main.cpp #include "1.h" #include "2.h" int foo();
Mar 2 2023
Mar 1 2023
Thanks Zequan. I have added two tests following your suggestion.
Feb 27 2023
Gentle ping ...
Feb 20 2023
Nov 14 2022
Nov 11 2022
@MaskRay, thanks again. I have marked comments as done.
Removed '2>&1' from 'RUN: %python'.
Nov 9 2022
@MaskRay, please let me know if there are any further changes required. Thanks.
Nov 7 2022
Thanks for your comments.
Nov 2 2022
Update the patch following the reviewers' comments, which include:
Oct 31 2022
I think I might be able to incorporate checkCacheCapacity into pruneCache. I am working on this.
Gentle ping ..
Oct 20 2022
The changes include:
Oct 19 2022
Updating the correct patch.
Thanks Teresa and Fangrui for the comments. Sorry for the delay in updating the patch. I have been trying to find a way to get the warning invoked by all cache users.
Update the patch following the reviewers comments, which include:
Oct 10 2022
Sep 5 2022
Sep 2 2022
Aug 31 2022
Aug 30 2022
Jul 27 2022
Jul 26 2022
Use Args.addOptInFlag instead of Args.hasFlag, thanks.
Jul 25 2022
Apr 22 2022
Apr 21 2022
Thanks David, I have modified the test following your advice.
Apr 19 2022
Mar 30 2021
Hi Jonas and Nico,
Feb 24 2021
I've reverted for now - I took a quick look at the sanitizer test and couldn't grok whats going wrong, will try again when I'm awake :)
It seems that this commit has caused several test failures.
Sep 15 2020
Hi Petr Hosek,
May 20 2020
Nov 28 2017
The previous patch doesn’t support the sequential commands, for example “mkdir existing_folder || true”. This caused sanitizer-windows test failed. The patch has been updated to support the sequential commands.
Nov 23 2017
Reverted rL318911 since it broke the sanitizer-windows.
Nov 20 2017
The test of MC/AsmParser/preserve-comments-crlf.s failed since it uses the unsupported diff option --strip-trailing-cr. I updated the internal diff shell command to support this option.
Nov 10 2017
Optimised the patch by using python ‘getopt’ module.
Nov 9 2017
Updated the builtin diff shell to support ‘-u’, ‘-b’ and ‘-w’ options. Now, all llvm, and clang tests passed with both Python 2 and Python 3.
Nov 7 2017
- I don't see any tests for the case where the commands *succeed*. Only for the case where they fail. Shouldn't we have some tests that verify the commands actually work?
The patch updated the test (valid-shell.txt) where lit internal shell commands succeeded.
Nov 6 2017
Update: I actually do see where you're testing that they work, but I'm not convinced that the tests are sufficient. For several reasons.
- it doesn't test that the builtin command is actually run versus the OS command. It only tests that whatever command is run doesn't fail.
- It doesn't test that the result of the command is as expected, it only tests that it doesn't return an error. For a somewhat unrealistic illustration of this, imagine that all the commands just returned success without actually doing anything. The test as it is written now would pass.
- Now that we have upwards of 6 builtin commands, I'm starting to think they should be separated into their own file. For example, lit/test/ShellBuiltins.py We could test them via unittests (e.g. see how BooleanExpression.py implements its unit tests).
What do you think?
Nov 2 2017
Oct 18 2016
Sep 30 2016
Sep 27 2016
Sep 26 2016
Sep 20 2016
Ok, I have updated the patch following your advice.
Sep 19 2016
I agree with you and abandon this patch.
Sep 16 2016
Sep 14 2016
Sep 13 2016
Sep 12 2016
Sep 9 2016
Sep 8 2016
Sep 5 2016
Sep 2 2016
Thanks for your pseudocode . Two issues have been fixed.
Sep 1 2016
Thanks for your explanation. I have updated the patch following your advice.
Aug 30 2016
Reused the existing native_separator.c test to check fully covered source file case.
Aug 29 2016
Thanks, the test has been added.
Aug 28 2016
Thanks Vedant, the patch has been updated following your comments.
Aug 26 2016
Aug 24 2016
Updating the patch to support the "Goto first zero count" feature.