This is an archive of the discontinued LLVM Phabricator instance.

[Darwin] Exclude interception union tests on Darwin and Android
ClosedPublic

Authored by bruno on Aug 3 2016, 12:00 PM.

Details

Summary

Since the directory is empty on Darwin, disable the inclusion and avoid the warning below. Exclude on Android as well to match the behavior from lib/interception/tests/CMakeLists.txt

lit.py: /Users/buildslave/jenkins/sharedspace/clang-R_master@2/llvm/utils/lit/lit/discovery.py:224:
warning: input '/Users/buildslave/jenkins/sharedspace/clang-R_master@2/clang-build/Build/tools/clang/runtime/compiler-rt-bins/test/interception/Unit'
contained no tests

This fixes the above warning in some of public bots, like http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/8686

Diff Detail

Event Timeline

bruno updated this revision to Diff 66685.Aug 3 2016, 12:00 PM
bruno retitled this revision from to [Darwin] Exclude interception union tests on Darwin and Android.
bruno updated this object.
bruno added reviewers: rnk, etienneb.
bruno added a subscriber: llvm-commits.
etienneb accepted this revision.Aug 3 2016, 12:03 PM
etienneb edited edge metadata.

lgtm

(sorry, I wasn't able to jump back on this issue. I ordered a Mac, and I'm still waiting for it).

This revision is now accepted and ready to land.Aug 3 2016, 12:03 PM
bruno closed this revision.Aug 3 2016, 9:57 PM

Thanks Etienne,

Committed r277692.