This is an archive of the discontinued LLVM Phabricator instance.

ELF lld: Ignore -EL and -EB options
ClosedPublic

Authored by emaste on Aug 3 2016, 10:22 AM.

Details

Summary

GNU ld supports -EL and -EB options to choose a default output format (big- or little-endian). We choose the appropriate endianness based on the format of the input objects and can ignore these options.

We could produce an error if -EL / -EB did not match the endianness of the input objects, but I don't think it's worthwhile.

Diff Detail

Repository
rL LLVM

Event Timeline

emaste updated this revision to Diff 66675.Aug 3 2016, 10:22 AM
emaste retitled this revision from to ELF lld: Ignore -EL and -EB options.
emaste updated this object.
emaste added reviewers: compnerd, dsanders.
emaste added a subscriber: llvm-commits.
ruiu added a subscriber: ruiu.Aug 3 2016, 10:48 AM
ruiu added inline comments.
ELF/Options.td
265–267 ↗(On Diff #66675)

Please sort.

Instead of Separate, I think you want to do F<"EB"> because -EB doesn't take arguments, and -EB and --EB are both valid.

emaste updated this revision to Diff 66805.Aug 4 2016, 7:37 AM
emaste edited edge metadata.

Sort, use F<> per @ruiu.

ruiu accepted this revision.Aug 4 2016, 1:19 PM
ruiu added a reviewer: ruiu.

LGTM

This revision is now accepted and ready to land.Aug 4 2016, 1:19 PM
This revision was automatically updated to reflect the committed changes.