This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Fix an unused-using-decl false positive about template arguments in function call expression.
ClosedPublic

Authored by hokein on Jul 26 2016, 5:34 AM.

Diff Detail

Event Timeline

hokein updated this revision to Diff 65500.Jul 26 2016, 5:34 AM
hokein retitled this revision from to [clang-tidy] Fix an unused-using-decl false positive about template arguments in function call expression..
hokein updated this object.
hokein added reviewers: alexfh, djasper.
hokein added a subscriber: cfe-commits.
klimek added a subscriber: klimek.Jul 28 2016, 9:43 AM
klimek added inline comments.
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
84–87

I thought the idea was to make an overload for hasTemplateArgument to work on FunctionDecl. Any specific reason not to make the matchers better?

hokein updated this revision to Diff 66131.Jul 29 2016, 8:54 AM

Use new ast matchers to simplify the code.

Updating D22803: [clang-tidy] Fix an unused-using-decl false positive about template arguments in

function call expression.

hokein marked an inline comment as done.Jul 29 2016, 8:57 AM
hokein added inline comments.
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
84–87

Have added the new matchers to clang ASTMatchers (D22963, D22957), and switched to use these matchers.

alexfh accepted this revision.Aug 1 2016, 8:27 AM
alexfh edited edge metadata.

LG

This revision is now accepted and ready to land.Aug 1 2016, 8:27 AM
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.