This is an archive of the discontinued LLVM Phabricator instance.

TargetOpcodes: Rewrite the documentation for SUBREG_TO_REG
ClosedPublic

Authored by MatzeB on Jul 22 2016, 4:47 PM.

Details

Summary

After some IRC discussion it became clear that the description/intention of this instruction is hard to understand.

Add a more verbose description and clarify the fact that this should not generate any code.

Diff Detail

Repository
rL LLVM

Event Timeline

MatzeB updated this revision to Diff 65189.Jul 22 2016, 4:47 PM
MatzeB retitled this revision from to TargetOpcodes: Rewrite the documentation for SUBREG_TO_REG.
MatzeB updated this object.
MatzeB added reviewers: qcolombet, mkuper, t.p.northover.
MatzeB set the repository for this revision to rL LLVM.
MatzeB added a subscriber: llvm-commits.
mkuper edited edge metadata.Jul 25 2016, 4:15 PM

LGTM with a tiny nit.
But I'd appreciate another pair of eyes verifying (again :-) ) that this describes the correct semantics.

include/llvm/Target/TargetOpcodes.def
62

Extra space before "This".

qcolombet accepted this revision.Aug 9 2016, 6:38 PM
qcolombet edited edge metadata.

LGTM as well.

This revision is now accepted and ready to land.Aug 9 2016, 6:38 PM
This revision was automatically updated to reflect the committed changes.