This is an archive of the discontinued LLVM Phabricator instance.

[PM] Port SymbolRewriter to the new PM
ClosedPublic

Authored by mkuper on Jul 22 2016, 2:41 PM.

Details

Summary

There are two things that potentially worry me about this port:

  1. Is this still the way we want to handle non-default constructors?
  2. I've converted the iplist into a std::list<unique_ptr>, because iplist is not moveable. Does this seem reasonable?

Diff Detail

Event Timeline

mkuper updated this revision to Diff 65161.Jul 22 2016, 2:41 PM
mkuper retitled this revision from to [PM] Port SymbolRewriter to the new PM.
mkuper updated this object.
mkuper added reviewers: compnerd, davide, silvas.
mkuper added a subscriber: llvm-commits.
davide edited edge metadata.Jul 22 2016, 2:49 PM

+ Duncan for the iplist bits.

mkuper added inline comments.Jul 22 2016, 3:07 PM
lib/Transforms/Utils/SymbolRewriter.cpp
71–72

We don't actually need this include, please ignore.

mkuper updated this revision to Diff 65409.Jul 25 2016, 1:27 PM

Thanks, Duncan!

Committed the iplist change separately, so the only thing that I'm concerned about now is the handling of --rewrite-map-file.
Is this still the way we want this to work with the new PM?

davide accepted this revision.Jul 25 2016, 1:29 PM
davide edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jul 25 2016, 1:29 PM

If we want to change the handling of -rewrite-file , fine, but that can (and should) be done separately.

This revision was automatically updated to reflect the committed changes.