Page MenuHomePhabricator

[utils] Add script to check for code coverage regressions
ClosedPublic

Authored by vsk on Jul 19 2016, 3:31 PM.

Details

Summary

This script is meant to be run on code coverage bots in conjunction with utils/prepare-code-coverage-artifact.py to flag coverage regressions in a window of commits.

Diff Detail

Repository
rL LLVM

Event Timeline

vsk updated this revision to Diff 64578.Jul 19 2016, 3:31 PM
vsk retitled this revision from to [utils] Add script to check for code coverage regressions.
vsk updated this object.
vsk added reviewers: cmatthews, silvas, MaggieYi.
vsk added a subscriber: llvm-commits.
vsk updated this object.Jul 19 2016, 3:38 PM
vsk updated this revision to Diff 64627.Jul 19 2016, 6:50 PM
vsk updated this object.
  • Added doctests.
  • Improved comments.
  • Fixed an issue where we would exit(0) even if there are regressions.
silvas accepted this revision.Jul 20 2016, 3:21 PM
silvas edited edge metadata.

lgtm, seems handy.

Is this something that you intend to ship to users, or just a tool for tracking LLVM coverage?

This revision is now accepted and ready to land.Jul 20 2016, 3:21 PM
silvas accepted this revision.Jul 20 2016, 3:21 PM

lgtm, seems handy.

Is this something that you intend to ship to users, or just a tool for tracking LLVM coverage?

vsk added a comment.Jul 20 2016, 3:49 PM

lgtm, seems handy.

Is this something that you intend to ship to users, or just a tool for tracking LLVM coverage?

Thanks. @cmatthews and I are working on a bot to track coverage regressions in llvm. The plan is to let people hammer out usability issues with internal bots (at least, that's what we're doing) and then see if there's broader interest.

I don't know what shipping this script to users entails. It doesn't bake in assumptions about the llvm codebase, if that's what you mean.

This revision was automatically updated to reflect the committed changes.