This is an archive of the discontinued LLVM Phabricator instance.

[PM] Convert Loop Strength Reduce pass to new PM
ClosedPublic

Authored by danielcdh on Jul 18 2016, 10:47 AM.

Diff Detail

Event Timeline

danielcdh updated this revision to Diff 64349.Jul 18 2016, 10:47 AM
danielcdh retitled this revision from to [PM] Convert Loop String Reduce pass to new PM.
danielcdh updated this object.
danielcdh added reviewers: davidxl, silvas.
danielcdh added a subscriber: llvm-commits.

In the title, it should be "Strength", instead of "String".

include/llvm/Transforms/Scalar/LoopStrengthReduce.h
1

Strenght -> Strength

danielcdh retitled this revision from [PM] Convert Loop String Reduce pass to new PM to [PM] Convert Loop Strength Reduce pass to new PM.Jul 18 2016, 10:56 AM
silvas accepted this revision.Jul 18 2016, 2:35 PM
silvas edited edge metadata.

LGTM with a nit.

test/Transforms/LoopStrengthReduce/ivchain.ll
2

You should not need require<ivusers> here.

Also, you don't need the function(...) around require<scalar-evolution>,require<targetir>.

I.e. this can be just require<scalar-evolution>,require<targetir>,loop(strength-reduce).

This revision is now accepted and ready to land.Jul 18 2016, 2:35 PM
danielcdh closed this revision.Jul 18 2016, 2:49 PM