[compiler-rt] Change all asm directives to __asm__ in cpu_model.

[asbirlea]

Summary

Aiming to resolve failure in sanitizer bot by changning all asm directives to asm.
Also, consistency.

[vitalybuka]

lgtm

[compnerd]

lib/builtins/cpu_model.c

230 ↗

(On Diff #64243)

This would be nice to leave as __asm as Microsoft documents it as __asm blocks. https://msdn.microsoft.com/en-us/library/45yd4tzz.aspx

[asbirlea]

Leave __asm for MSVC.

compiler-rt/trunk/lib/builtins/cpu_model.c

 // The check below for i386 was copied from clang's cpuid.h (__get_cpuid_max).
 // Check motivated by bug reports for OpenSSL crashing on CPUs without CPUID
 // support. Consequently, for i386, the presence of CPUID is checked first
 // via the corresponding eflags bit.
 static bool isCpuIdSupported() {
 #if defined(__GNUC__) || defined(__clang__)
 #if defined(__i386__)
   int __cpuid_supported;
-  __asm("  pushfl\n"
+  __asm__("  pushfl\n"
           "  popl   %%eax\n"
           "  movl   %%eax,%%ecx\n"
           "  xorl   $0x00200000,%%eax\n"
           "  pushl  %%eax\n"
           "  popfl\n"
           "  pushfl\n"
           "  popl   %%eax\n"
           "  movl   $0,%0\n"
           "  cmpl   %%eax,%%ecx\n"
           "  je     1f\n"
           "  movl   $1,%0\n"
           "1:"
           : "=r"(__cpuid_supported)
           :
           : "eax", "ecx");
   if (!__cpuid_supported)
     return false;
 #endif
   return true;
 #endif
   return true;
 }
 
 // This code is copied from lib/Support/Host.cpp.
 // Changes to either file should be mirrored in the other.
 
 /// getX86CpuIDAndInfo - Execute the specified cpuid and return the 4 values in
 /// the specified arguments.  If we can't run cpuid on the host, return true.
 static void getX86CpuIDAndInfo(unsigned value, unsigned *rEAX, unsigned *rEBX,
                                unsigned *rECX, unsigned *rEDX) {
 #if defined(__GNUC__) || defined(__clang__)
 #if defined(__x86_64__)
   // gcc doesn't know cpuid would clobber ebx/rbx. Preseve it manually.
-  asm("movq\t%%rbx, %%rsi\n\t"
+  __asm__("movq\t%%rbx, %%rsi\n\t"
           "cpuid\n\t"
           "xchgq\t%%rbx, %%rsi\n\t"
           : "=a"(*rEAX), "=S"(*rEBX), "=c"(*rECX), "=d"(*rEDX)
           : "a"(value));
 #elif defined(__i386__)
-  asm("movl\t%%ebx, %%esi\n\t"
+  __asm__("movl\t%%ebx, %%esi\n\t"
           "cpuid\n\t"
           "xchgl\t%%ebx, %%esi\n\t"
           : "=a"(*rEAX), "=S"(*rEBX), "=c"(*rECX), "=d"(*rEDX)
           : "a"(value));
 // pedantic #else returns to appease -Wunreachable-code (so we don't generate
 // postprocessed code that looks like "return true; return false;")
 #else
   assert(0 && "This method is defined only for x86.");
 #endif
 #elif defined(_MSC_VER)
   // The MSVC intrinsic is portable across x86 and x64.
   int registers[4];

 /// return true.
 static void getX86CpuIDAndInfoEx(unsigned value, unsigned subleaf,
                                  unsigned *rEAX, unsigned *rEBX, unsigned *rECX,
                                  unsigned *rEDX) {
 #if defined(__x86_64__) || defined(_M_X64)
 #if defined(__GNUC__) || defined(__clang__)
   // gcc doesn't know cpuid would clobber ebx/rbx. Preserve it manually.
   // FIXME: should we save this for Clang?
-  asm("movq\t%%rbx, %%rsi\n\t"
+  __asm__("movq\t%%rbx, %%rsi\n\t"
           "cpuid\n\t"
           "xchgq\t%%rbx, %%rsi\n\t"
           : "=a"(*rEAX), "=S"(*rEBX), "=c"(*rECX), "=d"(*rEDX)
           : "a"(value), "c"(subleaf));
 #elif defined(_MSC_VER)
   int registers[4];
   __cpuidex(registers, value, subleaf);
   *rEAX = registers[0];
   *rEBX = registers[1];
   *rECX = registers[2];
   *rEDX = registers[3];
 #else
   assert(0 && "This method is defined only for GNUC, Clang or MSVC.");
 #endif
 #elif defined(__i386__) || defined(_M_IX86)
 #if defined(__GNUC__) || defined(__clang__)
-  asm("movl\t%%ebx, %%esi\n\t"
+  __asm__("movl\t%%ebx, %%esi\n\t"
           "cpuid\n\t"
           "xchgl\t%%ebx, %%esi\n\t"
           : "=a"(*rEAX), "=S"(*rEBX), "=c"(*rECX), "=d"(*rEDX)
           : "a"(value), "c"(subleaf));
 #elif defined(_MSC_VER)
   __asm {
       mov   eax,value
       mov   ecx,subleaf
       cpuid
       mov   esi,rEAX
       mov   dword ptr [esi],eax
       mov   esi,rEBX