This is an archive of the discontinued LLVM Phabricator instance.

Differential D22355

[AMDGPU] Assembler: fix row_bcast parsing
ClosedPublic

Authored by SamWot on Jul 14 2016, 7:22 AM.

Details

Reviewers
• tstellarAMD
vpykhtin
Commits
rG7a2a323feb55: [AMDGPU] Assembler: fix row_bcast parsing
rL275422: [AMDGPU] Assembler: fix row_bcast parsing
Summary

This change fix bug 28538

Diff Detail

Event Timeline

SamWot updated this revision to Diff 63971.Jul 14 2016, 7:22 AM
SamWot retitled this revision from to [AMDGPU] Assembler: fix row_bcast parsing.
SamWot updated this object.
SamWot added a reviewer: vpykhtin.
Herald added a reviewer: • tstellarAMD. · View Herald TranscriptJul 14 2016, 7:22 AM
Herald added subscribers: kzhuravl, arsenm. · View Herald Transcript
SamWot updated this object.Jul 14 2016, 7:23 AM
SamWot edited edge metadata.
vpykhtin accepted this revision.Jul 14 2016, 7:35 AM
vpykhtin edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 14 2016, 7:35 AM
Closed by commit rL275422: [AMDGPU] Assembler: fix row_bcast parsing (authored by skolton). · Explain WhyJul 14 2016, 7:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
AMDGPU/
AsmParser/
2 lines
test/
MC/
AMDGPU/
regression/
12 lines

Diff 63971

lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

Show First 20 Lines • Show All 2,548 Lines • ▼ Show 20 Lines if (Prefix == "quad_perm") {
Int = 0x138; Int = 0x138;
} else if (Prefix == "wave_ror") { } else if (Prefix == "wave_ror") {
Int = 0x13C; Int = 0x13C;
} else if (Prefix == "row_bcast") { } else if (Prefix == "row_bcast") {
if (Int == 15) { if (Int == 15) {
Int = 0x142; Int = 0x142;
} else if (Int == 31) { } else if (Int == 31) {
Int = 0x143; Int = 0x143;
} else {
return MatchOperand_ParseFail;
} }
} else { } else {
return MatchOperand_ParseFail; return MatchOperand_ParseFail;
} }
} }
} }
Parser.Lex(); // eat last token Parser.Lex(); // eat last token
▲ Show 20 Lines • Show All 225 Lines • Show Last 20 Lines

test/MC/AMDGPU/regression/bug28538.s

  • This file was added.
// RUN: not llvm-mc -arch=amdgcn -mcpu=tonga -show-encoding %s 2>&1 | FileCheck %s --check-prefix=NOCIVI --check-prefix=NOVI
// RUN: not llvm-mc -arch=amdgcn -show-encoding %s 2>&1 | FileCheck %s --check-prefix=NOSI --check-prefix=NOSICI
// RUN: not llvm-mc -arch=amdgcn -mcpu=SI -show-encoding %s 2>&1 | FileCheck %s --check-prefix=NOSI --check-prefix=NOSICI
// RUN: not llvm-mc -arch=amdgcn -mcpu=bonaire -show-encoding %s 2>&1 | FileCheck %s --check-prefix=NOSICI
// NOSICI: error:
// NOVI: error: failed parsing operand
v_mov_b32 v0, v0 row_bcast:0
// NOSICI: error:
// NOVI: error: failed parsing operand
v_mov_b32 v0, v0 row_bcast:13