This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Fix missing argument in asan unittest
ClosedPublic

Authored by etienneb on Jul 13 2016, 11:56 PM.

Reviewers

Commits

Summary

Both test have the same command-line.
The second test is missing the /GS-.

Keep in mind that /GS is on by default.

etienneb retitled this revision from to [compiler-rt] Fix missing argument in asan unittest.

etienneb updated this object.

etienneb added a reviewer: rnk.

lgtm

test/asan/TestCases/Windows/dll_seh.cc
4	Let's add -GS to be explicit.

This revision is now accepted and ready to land.Jul 14 2016, 8:35 AM

nits

Path

Size

test/

asan/

TestCases/

Windows/

4 lines

	// RUN: %clang_cl_asan -O0 %p/dll_host.cc -Fe%t			// RUN: %clang_cl_asan -O0 %p/dll_host.cc -Fe%t
	//			//
	// Check both -GS and -GS- builds:			// Check both -GS and -GS- builds:
	// RUN: %clang_cl_asan -LD -O0 %s -Fe%t.dll			// RUN: %clang_cl_asan -GS -LD -O0 %s -Fe%t.dll
				rnkUnsubmitted Not Done Reply Inline Actions Let's add -GS to be explicit. rnk: Let's add -GS to be explicit.
	// RUN: %run %t %t.dll			// RUN: %run %t %t.dll
	//			//
	// RUN: %clang_cl_asan -LD -O0 %s -Fe%t.dll			// RUN: %clang_cl_asan -GS- -LD -O0 %s -Fe%t.dll
	// RUN: %run %t %t.dll			// RUN: %run %t %t.dll

	#include <windows.h>			#include <windows.h>
	#include <assert.h>			#include <assert.h>
	#include <stdio.h>			#include <stdio.h>

	// Should just "#include <sanitizer/asan_interface.h>" when C++ exceptions are			// Should just "#include <sanitizer/asan_interface.h>" when C++ exceptions are
	// supported and we don't need to use CL.			// supported and we don't need to use CL.
	Show All 35 Lines