This is an archive of the discontinued LLVM Phabricator instance.

Differential D22309

[asan] Reduce flakiness of halt_on_error-torture.cc testcase.
ClosedPublic

Authored by m.ostapenko on Jul 13 2016, 11:36 AM.

Details

Reviewers
kcc
eugenis
rnk
Commits
rG26b0bc0bd6db: [asan] Reduce flakiness of halt_on_error-torture.cc testcase.
rCRT275539: [asan] Reduce flakiness of halt_on_error-torture.cc testcase.
rL275539: [asan] Reduce flakiness of halt_on_error-torture.cc testcase.
Summary

It seems in some situations we have clashes on very first error so test only prints "nested bug in the same thread, aborting" rather than "use-after-poison", so remove corresponding " RUN: FileCheck %s < 10.txt" line.
Also, the two last " RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 1.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt" look wrong, they should check 10.txt. Fix these lines too.

Diff Detail

Repository
rL LLVM

Event Timeline

m.ostapenko updated this revision to Diff 63833.Jul 13 2016, 11:36 AM
m.ostapenko retitled this revision from to [asan] Reduce flakiness of halt_on_error-torture.cc testcase..
m.ostapenko updated this object.
m.ostapenko added reviewers: kcc, eugenis, rnk.
m.ostapenko set the repository for this revision to rL LLVM.
m.ostapenko added a project: Restricted Project.
m.ostapenko added subscribers: MatzeB, llvm-commits, ygribov.
Herald added a subscriber: kubamracek. · View Herald TranscriptJul 13 2016, 11:36 AM
ygribov added a comment.Jul 14 2016, 6:12 AM

As discussed in private email, I'm ok with this change (provided that change of checked file has been tested). I'm not a reviewer though.

rnk accepted this revision.Jul 14 2016, 8:18 AM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Jul 14 2016, 8:18 AM
Closed by commit rL275539: [asan] Reduce flakiness of halt_on_error-torture.cc testcase. (authored by chefmax). · Explain WhyJul 15 2016, 1:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
test/
asan/
TestCases/
Posix/
8 lines

Diff 64101

compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc

// Stress test recovery mode with many threads. // Stress test recovery mode with many threads.
// //
// RUN: %clangxx_asan -fsanitize-recover=address -pthread %s -o %t // RUN: %clangxx_asan -fsanitize-recover=address -pthread %s -o %t
// //
// RUN: %env_asan_opts=halt_on_error=false:suppress_equal_pcs=false %run %t 1 10 >1.txt 2>&1 // RUN: %env_asan_opts=halt_on_error=false:suppress_equal_pcs=false %run %t 1 10 >1.txt 2>&1
// RUN: FileCheck %s < 1.txt // RUN: FileCheck %s < 1.txt
// RUN: [ $(grep -c 'ERROR: AddressSanitizer: use-after-poison' 1.txt) -eq 10 ] // RUN: [ $(grep -c 'ERROR: AddressSanitizer: use-after-poison' 1.txt) -eq 10 ]
// RUN: FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt // RUN: FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt
// //
// Collisions are unlikely but still possible so we need the ||. // Collisions are unlikely but still possible so we need the ||.
// RUN: %env_asan_opts=halt_on_error=false:suppress_equal_pcs=false %run %t 10 20 >10.txt 2>&1 || true // RUN: %env_asan_opts=halt_on_error=false:suppress_equal_pcs=false %run %t 10 20 >10.txt 2>&1 || true
// This one is racy although _very_ unlikely to fail: // RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 10.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 10.txt
// RUN: FileCheck %s < 10.txt
// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 1.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt
// //
// Collisions are unlikely but still possible so we need the ||. // Collisions are unlikely but still possible so we need the ||.
// RUN: %env_asan_opts=halt_on_error=false %run %t 10 20 >10.txt 2>&1 || true // RUN: %env_asan_opts=halt_on_error=false %run %t 10 20 >10.txt 2>&1 || true
// This one is racy although _very_ unlikely to fail: // RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 10.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 10.txt
// RUN: FileCheck %s < 10.txt
// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 1.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <pthread.h> #include <pthread.h>
#include <time.h> #include <time.h>
#include <sanitizer/asan_interface.h> #include <sanitizer/asan_interface.h>
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines