This is an archive of the discontinued LLVM Phabricator instance.

Differential D22179

[sanitizer] Use %clangxx in objc++ test files
ClosedPublic

Authored by kastiglione on Jul 8 2016, 3:33 PM.

Details

Reviewers
compnerd
samsonov
kubamracek
Summary

These test in this change are objc++, but are built using %clang, not %clangxx. The reason this works is the driver has been adding -lc++ for sanitizer enabled builds. By making these tests use %clangxx, they no longer depend on the driver linking to c++. The reason I want to make this change is to re-land http://reviews.llvm.org/D22018, which caused these tests to stop working.

Diff Detail

Event Timeline

kastiglione updated this revision to Diff 63334.Jul 8 2016, 3:33 PM
kastiglione retitled this revision from to [sanitizer] Use %clangxx in objc++ test files.
kastiglione updated this object.
kastiglione added reviewers: samsonov, compnerd.
kastiglione added a subscriber: llvm-commits.
Herald added a subscriber: kubamracek. · View Herald TranscriptJul 8 2016, 3:33 PM
kubamracek accepted this revision.Jul 9 2016, 3:30 AM
kubamracek added a reviewer: kubamracek.
kubamracek edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 9 2016, 3:31 AM
compnerd closed this revision.Jul 9 2016, 2:21 PM
compnerd edited edge metadata.

LGTM; Committed as SVN r274989.

Revision Contents

Diff 63334

test/asan/TestCases/Darwin/address-range-limit.mm

// Regression test for https://code.google.com/p/address-sanitizer/issues/detail?id=368. // Regression test for https://code.google.com/p/address-sanitizer/issues/detail?id=368.
// RUN: %clang_asan %s -Wno-deprecated-declarations -flat_namespace -bundle -undefined suppress -o %t.bundle // RUN: %clangxx_asan %s -Wno-deprecated-declarations -flat_namespace -bundle -undefined suppress -o %t.bundle
// RUN: %clang_asan %s -Wno-deprecated-declarations -o %t -framework Foundation && not %run %t 2>&1 | FileCheck %s // RUN: %clangxx_asan %s -Wno-deprecated-declarations -o %t -framework Foundation && not %run %t 2>&1 | FileCheck %s
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
#import <mach-o/dyld.h> #import <mach-o/dyld.h>
#include <string> #include <string>
int main(int argc, char *argv[]) { int main(int argc, char *argv[]) {
for (int i = 0; i < 10; i++) { for (int i = 0; i < 10; i++) {
Show All 26 Lines

test/tsan/Darwin/gcd-blocks.mm

// RUN: %clang_tsan %s -o %t -framework Foundation // RUN: %clangxx_tsan %s -o %t -framework Foundation
// RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
int main() { int main() {
fprintf(stderr, "start\n"); fprintf(stderr, "start\n");
dispatch_queue_t background_q = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0); dispatch_queue_t background_q = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);
Show All 25 Lines

test/tsan/Darwin/gcd-groups-destructor.mm

// RUN: %clang_tsan %s -o %t -framework Foundation // RUN: %clangxx_tsan %s -o %t -framework Foundation
// RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
#import <memory> #import <memory>
#import <stdatomic.h> #import <stdatomic.h>
_Atomic(long) destructor_counter = 0; _Atomic(long) destructor_counter = 0;
Show All 34 Lines

test/tsan/Darwin/libcxx-shared-ptr-recursive.mm

// RUN: %clang_tsan %s -o %t -framework Foundation // RUN: %clangxx_tsan %s -o %t -framework Foundation
// RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
#import <memory> #import <memory>
struct InnerStruct { struct InnerStruct {
~InnerStruct() { ~InnerStruct() {
Show All 27 Lines

test/tsan/Darwin/libcxx-shared-ptr-stress.mm

// RUN: %clang_tsan %s -o %t -framework Foundation // RUN: %clangxx_tsan %s -o %t -framework Foundation
// RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
#import <assert.h> #import <assert.h>
#import <memory> #import <memory>
#import <stdatomic.h> #import <stdatomic.h>
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines

test/tsan/Darwin/libcxx-shared-ptr.mm

// RUN: %clang_tsan %s -o %t -framework Foundation // RUN: %clangxx_tsan %s -o %t -framework Foundation
// RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
#import <memory> #import <memory>
#import "../test.h" #import "../test.h"
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines

test/tsan/Darwin/osatomics-add.mm

// RUN: %clang_tsan %s -o %t -framework Foundation -std=c++11 // RUN: %clangxx_tsan %s -o %t -framework Foundation -std=c++11
// RUN: %run %t 2>&1 | FileCheck %s // RUN: %run %t 2>&1 | FileCheck %s
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
#import <libkern/OSAtomic.h> #import <libkern/OSAtomic.h>
#include <thread> #include <thread>
volatile int64_t retainCount = 0; volatile int64_t retainCount = 0;
Show All 39 Lines

test/tsan/Darwin/osatomics-list.mm

// RUN: %clang_tsan %s -o %t -framework Foundation -std=c++11 // RUN: %clangxx_tsan %s -o %t -framework Foundation -std=c++11
// RUN: %run %t 2>&1 | FileCheck %s // RUN: %run %t 2>&1 | FileCheck %s
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
#import <libkern/OSAtomic.h> #import <libkern/OSAtomic.h>
#include <thread> #include <thread>
#include "../test.h" #include "../test.h"
Show All 34 Lines