This is an archive of the discontinued LLVM Phabricator instance.

Differential D22177

[OpenMP] remove duplicate code in ActOnOpenMPRegionStart
ClosedPublic

Authored by kkwli0 on Jul 8 2016, 3:01 PM.

Details

Reviewers
ABataev
Commits
rG70a12c5dd1bf: [OpenMP] remove duplicate code in ActOnOpenMPRegionStart
rC275323: [OpenMP] remove duplicate code in ActOnOpenMPRegionStart
rL275323: [OpenMP] remove duplicate code in ActOnOpenMPRegionStart
Summary

This patch is to remove duplicate code in ActOnOpenMPRegionStart.

Diff Detail

Event Timeline

kkwli0 updated this revision to Diff 63326.Jul 8 2016, 3:01 PM
kkwli0 retitled this revision from to [OpenMP] remove duplicate code in ActOnOpenMPRegionStart.
kkwli0 updated this object.
kkwli0 added a reviewer: ABataev.
kkwli0 added subscribers: sfantao, carlo.bertolli, arpith-jacob.
ABataev accepted this revision.Jul 11 2016, 1:52 AM
ABataev edited edge metadata.

LG

This revision is now accepted and ready to land.Jul 11 2016, 1:52 AM
Closed by commit rL275323: [OpenMP] remove duplicate code in ActOnOpenMPRegionStart (authored by kli). · Explain WhyJul 13 2016, 2:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Sema/
174 lines

Diff 63326

lib/Sema/SemaOpenMP.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,577 Lines • ▼ Show 20 Linespublic:
DSAAttrChecker(DSAStackTy *S, Sema &SemaRef, CapturedStmt *CS) DSAAttrChecker(DSAStackTy *S, Sema &SemaRef, CapturedStmt *CS)
: Stack(S), SemaRef(SemaRef), ErrorFound(false), CS(CS) {} : Stack(S), SemaRef(SemaRef), ErrorFound(false), CS(CS) {}
}; };
} // namespace } // namespace
void Sema::ActOnOpenMPRegionStart(OpenMPDirectiveKind DKind, Scope *CurScope) { void Sema::ActOnOpenMPRegionStart(OpenMPDirectiveKind DKind, Scope *CurScope) {
switch (DKind) { switch (DKind) {
case OMPD_parallel: { case OMPD_parallel:
QualType KmpInt32Ty = Context.getIntTypeForBitwidth(32, 1); case OMPD_parallel_for:
QualType KmpInt32PtrTy = case OMPD_parallel_for_simd:
Context.getPointerType(KmpInt32Ty).withConst().withRestrict(); case OMPD_parallel_sections:
Sema::CapturedParamNameType Params[] = { case OMPD_teams: {
std::make_pair(".global_tid.", KmpInt32PtrTy),
std::make_pair(".bound_tid.", KmpInt32PtrTy),
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_simd: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_for: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_for_simd: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_sections: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_section: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_single: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_master: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_critical: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_parallel_for: {
QualType KmpInt32Ty = Context.getIntTypeForBitwidth(32, 1);
QualType KmpInt32PtrTy =
Context.getPointerType(KmpInt32Ty).withConst().withRestrict();
Sema::CapturedParamNameType Params[] = {
std::make_pair(".global_tid.", KmpInt32PtrTy),
std::make_pair(".bound_tid.", KmpInt32PtrTy),
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_parallel_for_simd: {
QualType KmpInt32Ty = Context.getIntTypeForBitwidth(32, 1); QualType KmpInt32Ty = Context.getIntTypeForBitwidth(32, 1);
QualType KmpInt32PtrTy = QualType KmpInt32PtrTy =
Context.getPointerType(KmpInt32Ty).withConst().withRestrict(); Context.getPointerType(KmpInt32Ty).withConst().withRestrict();
Sema::CapturedParamNameType Params[] = { Sema::CapturedParamNameType Params[] = {
std::make_pair(".global_tid.", KmpInt32PtrTy), std::make_pair(".global_tid.", KmpInt32PtrTy),
std::make_pair(".bound_tid.", KmpInt32PtrTy), std::make_pair(".bound_tid.", KmpInt32PtrTy),
std::make_pair(StringRef(), QualType()) // __context with shared vars std::make_pair(StringRef(), QualType()) // __context with shared vars
}; };
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP, ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params); Params);
break; break;
} }
case OMPD_parallel_sections: { case OMPD_simd:
QualType KmpInt32Ty = Context.getIntTypeForBitwidth(32, 1); case OMPD_for:
QualType KmpInt32PtrTy = case OMPD_for_simd:
Context.getPointerType(KmpInt32Ty).withConst().withRestrict(); case OMPD_sections:
case OMPD_section:
case OMPD_single:
case OMPD_master:
case OMPD_critical:
case OMPD_ordered:
case OMPD_atomic:
case OMPD_target_data:
case OMPD_target:
case OMPD_target_parallel:
case OMPD_target_parallel_for:
case OMPD_taskgroup:
case OMPD_distribute: {
Sema::CapturedParamNameType Params[] = { Sema::CapturedParamNameType Params[] = {
std::make_pair(".global_tid.", KmpInt32PtrTy),
std::make_pair(".bound_tid.", KmpInt32PtrTy),
std::make_pair(StringRef(), QualType()) // __context with shared vars std::make_pair(StringRef(), QualType()) // __context with shared vars
}; };
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP, ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params); Params);
break; break;
} }
case OMPD_task: { case OMPD_task: {
QualType KmpInt32Ty = Context.getIntTypeForBitwidth(32, 1); QualType KmpInt32Ty = Context.getIntTypeForBitwidth(32, 1);
Show All 14 Lines ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params); Params);
// Mark this captured region as inlined, because we don't use outlined // Mark this captured region as inlined, because we don't use outlined
// function directly. // function directly.
getCurCapturedRegion()->TheCapturedDecl->addAttr( getCurCapturedRegion()->TheCapturedDecl->addAttr(
AlwaysInlineAttr::CreateImplicit( AlwaysInlineAttr::CreateImplicit(
Context, AlwaysInlineAttr::Keyword_forceinline, SourceRange())); Context, AlwaysInlineAttr::Keyword_forceinline, SourceRange()));
break; break;
} }
case OMPD_ordered: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_atomic: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_target_data:
case OMPD_target:
case OMPD_target_parallel:
case OMPD_target_parallel_for: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_teams: {
QualType KmpInt32Ty = Context.getIntTypeForBitwidth(32, 1);
QualType KmpInt32PtrTy =
Context.getPointerType(KmpInt32Ty).withConst().withRestrict();
Sema::CapturedParamNameType Params[] = {
std::make_pair(".global_tid.", KmpInt32PtrTy),
std::make_pair(".bound_tid.", KmpInt32PtrTy),
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_taskgroup: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_taskloop: case OMPD_taskloop:
case OMPD_taskloop_simd: { case OMPD_taskloop_simd: {
QualType KmpInt32Ty = QualType KmpInt32Ty =
Context.getIntTypeForBitwidth(/*DestWidth=*/32, /*Signed=*/1); Context.getIntTypeForBitwidth(/*DestWidth=*/32, /*Signed=*/1);
QualType KmpUInt64Ty = QualType KmpUInt64Ty =
Context.getIntTypeForBitwidth(/*DestWidth=*/64, /*Signed=*/0); Context.getIntTypeForBitwidth(/*DestWidth=*/64, /*Signed=*/0);
QualType KmpInt64Ty = QualType KmpInt64Ty =
Context.getIntTypeForBitwidth(/*DestWidth=*/64, /*Signed=*/1); Context.getIntTypeForBitwidth(/*DestWidth=*/64, /*Signed=*/1);
Show All 19 Lines ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params); Params);
// Mark this captured region as inlined, because we don't use outlined // Mark this captured region as inlined, because we don't use outlined
// function directly. // function directly.
getCurCapturedRegion()->TheCapturedDecl->addAttr( getCurCapturedRegion()->TheCapturedDecl->addAttr(
AlwaysInlineAttr::CreateImplicit( AlwaysInlineAttr::CreateImplicit(
Context, AlwaysInlineAttr::Keyword_forceinline, SourceRange())); Context, AlwaysInlineAttr::Keyword_forceinline, SourceRange()));
break; break;
} }
case OMPD_distribute: {
Sema::CapturedParamNameType Params[] = {
std::make_pair(StringRef(), QualType()) // __context with shared vars
};
ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
Params);
break;
}
case OMPD_distribute_parallel_for_simd: case OMPD_distribute_parallel_for_simd:
case OMPD_distribute_simd: case OMPD_distribute_simd:
case OMPD_distribute_parallel_for: { case OMPD_distribute_parallel_for: {
QualType KmpInt32Ty = Context.getIntTypeForBitwidth(32, 1); QualType KmpInt32Ty = Context.getIntTypeForBitwidth(32, 1);
QualType KmpInt32PtrTy = QualType KmpInt32PtrTy =
Context.getPointerType(KmpInt32Ty).withConst().withRestrict(); Context.getPointerType(KmpInt32Ty).withConst().withRestrict();
Sema::CapturedParamNameType Params[] = { Sema::CapturedParamNameType Params[] = {
std::make_pair(".global_tid.", KmpInt32PtrTy), std::make_pair(".global_tid.", KmpInt32PtrTy),
▲ Show 20 Lines • Show All 9,794 Lines • Show Last 20 Lines