Page MenuHomePhabricator

AMDGPU: Remove implicit iterator conversions, NFC
ClosedPublic

Authored by dexonsmith on Jul 8 2016, 11:59 AM.

Details

Summary

Remove remaining implicit conversions from MachineInstrBundleIterator to
MachineInstr* from the AMDGPU backend. In most cases, I made them less
attractive by preferring MachineInstr& or using a ranged-based for loop.

Once all the backends are fixed I'll make the operator explicit so that
this doesn't bitrot back.

Diff Detail

Event Timeline

dexonsmith updated this revision to Diff 63276.Jul 8 2016, 11:59 AM
dexonsmith retitled this revision from to AMDGPU: Remove implicit iterator conversions, NFC.
dexonsmith updated this object.
dexonsmith added a subscriber: llvm-commits.
arsenm accepted this revision.Jul 8 2016, 12:11 PM
arsenm added a reviewer: arsenm.

LGTM

This revision is now accepted and ready to land.Jul 8 2016, 12:11 PM

Thanks! r274906.

dexonsmith closed this revision.Jul 8 2016, 12:24 PM