This is an archive of the discontinued LLVM Phabricator instance.

Differential D22010

Add more gcc compatibility names to clang's cpuid.h
ClosedPublic

Authored by dim on Jul 5 2016, 1:20 PM.

Details

Reviewers
joerg
rsmith
Commits
rGd10126296d5e: Merging r277307:
rGf8099f256d46: Add more gcc compatibility names to clang's cpuid.h
rC277307: Add more gcc compatibility names to clang's cpuid.h
rL277307: Add more gcc compatibility names to clang's cpuid.h
Summary

Some cpuid bit defines are named slightly different from how gcc's cpuid.h calls them.

Define a few more compatibility names to appease software built for gcc:

  • bit_PCLMUL alias of bit_PCLMULQDQ
  • bit_SSE4_1 alias of bit_SSE41
  • bit_SSE4_2 alias of bit_SSE42
  • bit_AES alias of bit_AESNI
  • bit_CMPXCHG8B alias of bit_CX8

While here, add the misssing 29th bit, bit_F16C.

Diff Detail

Repository
rL LLVM

Event Timeline

dim updated this revision to Diff 62781.Jul 5 2016, 1:20 PM
dim retitled this revision from to Add more gcc compatibility names to clang's cpuid.h.
dim updated this object.
dim added reviewers: joerg, rsmith.
dim added a subscriber: cfe-commits.
dim added a comment.Jul 13 2016, 2:54 AM

Ping.

bruno added a subscriber: bruno.Jul 18 2016, 11:40 AM
bruno added inline comments.
lib/Headers/cpuid.h
114 ↗(On Diff #62781)

Isn't this one also meant for gcc compat?

dim added inline comments.Jul 21 2016, 12:05 PM
lib/Headers/cpuid.h
114 ↗(On Diff #62781)

Well, we didn't have any clang-specific define, so might as well choose the same name that gcc has used?

Closed by commit rL277307: Add more gcc compatibility names to clang's cpuid.h (authored by dim). · Explain WhyJul 31 2016, 1:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
lib/
Headers/
8 lines

Diff 66250

cfe/trunk/lib/Headers/cpuid.h

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines
/* VORTEX: "Vortex86 SoC" */ /* VORTEX: "Vortex86 SoC" */
#define signature_VORTEX_ebx 0x74726f56 #define signature_VORTEX_ebx 0x74726f56
#define signature_VORTEX_edx 0x36387865 #define signature_VORTEX_edx 0x36387865
#define signature_VORTEX_ecx 0x436f5320 #define signature_VORTEX_ecx 0x436f5320
/* Features in %ecx for level 1 */ /* Features in %ecx for level 1 */
#define bit_SSE3 0x00000001 #define bit_SSE3 0x00000001
#define bit_PCLMULQDQ 0x00000002 #define bit_PCLMULQDQ 0x00000002
#define bit_PCLMUL bit_PCLMULQDQ /* for gcc compat */
#define bit_DTES64 0x00000004 #define bit_DTES64 0x00000004
#define bit_MONITOR 0x00000008 #define bit_MONITOR 0x00000008
#define bit_DSCPL 0x00000010 #define bit_DSCPL 0x00000010
#define bit_VMX 0x00000020 #define bit_VMX 0x00000020
#define bit_SMX 0x00000040 #define bit_SMX 0x00000040
#define bit_EIST 0x00000080 #define bit_EIST 0x00000080
#define bit_TM2 0x00000100 #define bit_TM2 0x00000100
#define bit_SSSE3 0x00000200 #define bit_SSSE3 0x00000200
#define bit_CNXTID 0x00000400 #define bit_CNXTID 0x00000400
#define bit_FMA 0x00001000 #define bit_FMA 0x00001000
#define bit_CMPXCHG16B 0x00002000 #define bit_CMPXCHG16B 0x00002000
#define bit_xTPR 0x00004000 #define bit_xTPR 0x00004000
#define bit_PDCM 0x00008000 #define bit_PDCM 0x00008000
#define bit_PCID 0x00020000 #define bit_PCID 0x00020000
#define bit_DCA 0x00040000 #define bit_DCA 0x00040000
#define bit_SSE41 0x00080000 #define bit_SSE41 0x00080000
#define bit_SSE4_1 bit_SSE41 /* for gcc compat */
#define bit_SSE42 0x00100000 #define bit_SSE42 0x00100000
#define bit_SSE4_2 bit_SSE42 /* for gcc compat */
#define bit_x2APIC 0x00200000 #define bit_x2APIC 0x00200000
#define bit_MOVBE 0x00400000 #define bit_MOVBE 0x00400000
#define bit_POPCNT 0x00800000 #define bit_POPCNT 0x00800000
#define bit_TSCDeadline 0x01000000 #define bit_TSCDeadline 0x01000000
#define bit_AESNI 0x02000000 #define bit_AESNI 0x02000000
#define bit_AES bit_AESNI /* for gcc compat */
#define bit_XSAVE 0x04000000 #define bit_XSAVE 0x04000000
#define bit_OSXSAVE 0x08000000 #define bit_OSXSAVE 0x08000000
#define bit_AVX 0x10000000 #define bit_AVX 0x10000000
#define bit_F16C 0x20000000
#define bit_RDRND 0x40000000 #define bit_RDRND 0x40000000
/* Features in %edx for level 1 */ /* Features in %edx for level 1 */
#define bit_FPU 0x00000001 #define bit_FPU 0x00000001
#define bit_VME 0x00000002 #define bit_VME 0x00000002
#define bit_DE 0x00000004 #define bit_DE 0x00000004
#define bit_PSE 0x00000008 #define bit_PSE 0x00000008
#define bit_TSC 0x00000010 #define bit_TSC 0x00000010
#define bit_MSR 0x00000020 #define bit_MSR 0x00000020
#define bit_PAE 0x00000040 #define bit_PAE 0x00000040
#define bit_MCE 0x00000080 #define bit_MCE 0x00000080
#define bit_CX8 0x00000100 #define bit_CX8 0x00000100
#define bit_CMPXCHG8B bit_CX8 /* for gcc compat */
#define bit_APIC 0x00000200 #define bit_APIC 0x00000200
#define bit_SEP 0x00000800 #define bit_SEP 0x00000800
#define bit_MTRR 0x00001000 #define bit_MTRR 0x00001000
#define bit_PGE 0x00002000 #define bit_PGE 0x00002000
#define bit_MCA 0x00004000 #define bit_MCA 0x00004000
#define bit_CMOV 0x00008000 #define bit_CMOV 0x00008000
#define bit_PAT 0x00010000 #define bit_PAT 0x00010000
#define bit_PSE36 0x00020000 #define bit_PSE36 0x00020000
#define bit_PSN 0x00040000 #define bit_PSN 0x00040000
#define bit_CLFSH 0x00080000 #define bit_CLFSH 0x00080000
#define bit_DS 0x00200000 #define bit_DS 0x00200000
#define bit_ACPI 0x00400000 #define bit_ACPI 0x00400000
#define bit_MMX 0x00800000 #define bit_MMX 0x00800000
#define bit_FXSR 0x01000000 #define bit_FXSR 0x01000000
#define bit_FXSAVE bit_FXSR /* for gcc compat */ #define bit_FXSAVE bit_FXSR /* for gcc compat */
#define bit_SSE 0x02000000 #define bit_SSE 0x02000000
#define bit_SSE2 0x04000000 #define bit_SSE2 0x04000000
#define bit_SS 0x08000000 #define bit_SS 0x08000000
#define bit_HTT 0x10000000 #define bit_HTT 0x10000000
#define bit_TM 0x20000000 #define bit_TM 0x20000000
#define bit_PBE 0x80000000 #define bit_PBE 0x80000000
/* Features in %ebx for level 7 sub-leaf 0 */ /* Features in %ebx for level 7 sub-leaf 0 */
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines