This is an archive of the discontinued LLVM Phabricator instance.

[X86] add _mm_loadu_si64
ClosedPublic

Authored by AsafBadouh on Jun 19 2016, 6:06 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

AsafBadouh updated this revision to Diff 61199.Jun 19 2016, 6:06 AM
AsafBadouh retitled this revision from to [X86] add _mm_loadu_si64.
AsafBadouh updated this object.
AsafBadouh added reviewers: delena, igorb, m_zuckerman.
AsafBadouh set the repository for this revision to rL LLVM.
AsafBadouh added a subscriber: cfe-commits.
RKSimon added inline comments.
tools/clang/test/CodeGen/sse2-builtins.c
1527 ↗(On Diff #61199)

Replace the hardcoded %4 argument with a general pattern match

1530 ↗(On Diff #61199)

Is the store/load necessary? This appears to be just the -O0 stack behaviour

AsafBadouh updated this revision to Diff 61200.Jun 19 2016, 8:22 AM

small changes according to Simon review.

RKSimon added inline comments.Jun 22 2016, 3:17 PM
tools/clang/test/CodeGen/sse2-builtins.c
1526 ↗(On Diff #61200)

Please can add the alignment operand to the CHECK (it should be align 1)?

AsafBadouh updated this revision to Diff 61661.Jun 23 2016, 3:53 AM

add align to CHECK

craig.topper added inline comments.
tools/clang/test/CodeGen/sse2-builtins.c
1526 ↗(On Diff #61661)

You need {{$}} after the 1 to indicate end of line or it can match 16 too.

RKSimon accepted this revision.Jun 26 2016, 5:11 AM
RKSimon added a reviewer: RKSimon.

LGTM

This revision is now accepted and ready to land.Jun 26 2016, 5:11 AM
Closed by commit rL273812: [X86] add _mm_loadu_si64 (authored by abadouh). · Explain WhyJun 26 2016, 6:58 AM
This revision was automatically updated to reflect the committed changes.