Page MenuHomePhabricator

[mips] Emit a JALR with $rd equal to $zero, instead of a JR in MIPS32R6.
ClosedPublic

Authored by vkalintiris on Jun 15 2016, 4:12 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

vkalintiris retitled this revision from to [mips] Emit a JALR with $rd equal to $zero, instead of a JR in MIPS32R6..
vkalintiris updated this object.
vkalintiris added reviewers: dsanders, sdardis.
vkalintiris added a subscriber: llvm-commits.
sdardis accepted this revision.Jun 16 2016, 7:53 AM
sdardis edited edge metadata.

LGTM.

In principle, you could exploit a redundancy in the pre-MIPSR6 instruction set to simply always emit "jalr, $zero, $at" rather than switching on the ISA.

I believe it is best that we do switch on ISA for clearer disassembly though.

This revision is now accepted and ready to land.Jun 16 2016, 7:53 AM
This revision was automatically updated to reflect the committed changes.