This is an archive of the discontinued LLVM Phabricator instance.

Add a negative TBAA test
ClosedPublic

Authored by rogfer01 on Jun 13 2016, 9:21 AM.

Details

Summary

This commit extends tbaa.cpp to just make sure that tbaa markers are not
emitted when they should not.

Diff Detail

Repository
rL LLVM

Event Timeline

rogfer01 updated this revision to Diff 60543.Jun 13 2016, 9:21 AM
rogfer01 retitled this revision from to Add a negative TBAA test.
rogfer01 updated this object.
rogfer01 added a reviewer: rsmith.
rogfer01 added a subscriber: cfe-commits.
jmolloy added inline comments.
test/CodeGen/tbaa.cpp
57 ↗(On Diff #60543)

Would it just be simpler to do:

// NO-TBAA-NOT: !tbaa

at the top of the file?

rogfer01 added inline comments.Jun 13 2016, 9:53 AM
test/CodeGen/tbaa.cpp
57 ↗(On Diff #60543)

I'll check that. If it works the patch will become so much simpler!

rogfer01 updated this revision to Diff 60667.Jun 14 2016, 5:28 AM

Much simpler version thanks to @jmolloy comment.

Ping? Thank you.

Private reply:

fine by me but a clang person needs to a accept it.

Ping?

Thank you very much!

Anastasia accepted this revision.Jul 5 2016, 8:54 AM
Anastasia edited edge metadata.

LGTM!

Has this test case been missing from the original commit? If yes, could you point to it please! Thanks!

This revision is now accepted and ready to land.Jul 5 2016, 8:54 AM
rogfer01 removed a reviewer: rsmith.Jul 5 2016, 9:05 AM
rogfer01 added a subscriber: rsmith.

LGTM!

Has this test case been missing from the original commit? If yes, could you point to it please! Thanks!

The original commit is the support for tbaa, when we added support for tbaa, we check that correct tbaa metadata is generated when tbaa is on, but didn't test the other way (i.e no tbaa metadata if tbaa is off).

This revision was automatically updated to reflect the committed changes.