This is an archive of the discontinued LLVM Phabricator instance.

Differential D21256

Improved Visual Studio 2015 visualization of SmallVectorImpl
ClosedPublic

Authored by mspertus on Jun 10 2016, 7:57 PM.

Details

Reviewers
aaron.ballman
aemerson
zturner
mspertus
Summary

When visualizing small vectors in VS2015, show the first few elements in the DisplayString instead of the size. For example, a SmallVector of DeclAccessPair will visualize like

{public typename ...Ts, public typename U}

The visualization in VS2013 remains the same because we continue to include the old visualizer with a lower-than-default priority of MediumLow, and the same SmallVector would continue to be visualized as

{size = 2}

I decided to submit this one for review before commit because as SmallVector is used pretty much everywhere in LLVM and Clang, even though I think this is a huge improvement in practice but wanted to give others a chance to pipe in if they disagree. If no one pipes in, I plan to go ahead and commit in 48 hours

Diff Detail

Event Timeline

mspertus updated this revision to Diff 60434.Jun 10 2016, 7:57 PM
mspertus retitled this revision from to Improved Visual Studio 2015 visualization of SmallVectorImpl.
mspertus updated this object.
mspertus added reviewers: aaron.ballman, zturner, aemerson.
mspertus added a subscriber: cfe-commits.
Diffusion mentioned this in rL272448: Visual Studio visualizers associated with LookupResults.Jun 10 2016, 8:09 PM
mspertus accepted this revision.Jun 12 2016, 6:50 PM
mspertus added a reviewer: mspertus.

No adverse (or otherwise) comments received, so committing as revision 272525

This revision is now accepted and ready to land.Jun 12 2016, 6:50 PM
mspertus closed this revision.Jun 12 2016, 7:01 PM

revision 272525

dblaikie added a subscriber: dblaikie.Jun 13 2016, 8:16 AM

As for the original change proposed: My guiding principle would be "do
whatever std::vector does". (& that's what I did when implementing GDB
pretty printers for SmallVector/SmallString/ArrayRef, etc... )

An aside: We generally don't do time limited reviews like this. Either
something needs review because you're not sure about it, or it doesn't. It
sounds like the feedback you were looking for probably would've been fine a
post-commit review feedback just as easily & perhaps might've been a better
option. (while in this case it was fine - it's sort of a community
habit/standards thing - we don't want to create the idea that lack of
feedback is consent/approval in the review process)

Revision Contents

PathSize
27 lines

Diff 60434

llvm.natvis

<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<!-- <!--
Visual Studio Native Debugging Visualizers for LLVM Visual Studio Native Debugging Visualizers for LLVM
For Visual Studio 2013 only, put this file into For Visual Studio 2013 only, put this file into
"%USERPROFILE%\Documents\Visual Studio 2013\Visualizers" or create a symbolic link so it updates automatically. "%USERPROFILE%\Documents\Visual Studio 2013\Visualizers" or create a symbolic link so it updates automatically.
For later versions of Visual Studio, no setup is required. For later versions of Visual Studio, no setup is required.
--> -->
<AutoVisualizer xmlns="http://schemas.microsoft.com/vstudio/debugger/natvis/2010"> <AutoVisualizer xmlns="http://schemas.microsoft.com/vstudio/debugger/natvis/2010">
<!-- VS2013 -->
<Type Name="llvm::SmallVectorImpl&lt;*&gt;"> <Type Name="llvm::SmallVectorImpl&lt;*&gt;" Priority="MediumLow">
<DisplayString Condition="(($T1*)EndX - ($T1*)BeginX) == 0">empty</DisplayString> <DisplayString Condition="(($T1*)EndX - ($T1*)BeginX) == 0">empty</DisplayString>
<DisplayString Condition="(($T1*)EndX - ($T1*)BeginX) != 0">{{ size={($T1*)EndX - ($T1*)BeginX} }}</DisplayString> <DisplayString Condition="(($T1*)EndX - ($T1*)BeginX) != 0">{{ size={($T1*)EndX - ($T1*)BeginX} }}</DisplayString>
<Expand> <Expand>
<Item Name="[size]">($T1*)EndX - ($T1*)BeginX</Item> <Item Name="[size]">($T1*)EndX - ($T1*)BeginX</Item>
<Item Name="[capacity]">($T1*)CapacityX - ($T1*)BeginX</Item> <Item Name="[capacity]">($T1*)CapacityX - ($T1*)BeginX</Item>
<ArrayItems> <ArrayItems>
<Size>($T1*)EndX - ($T1*)BeginX</Size> <Size>($T1*)EndX - ($T1*)BeginX</Size>
<ValuePointer>($T1*)BeginX</ValuePointer> <ValuePointer>($T1*)BeginX</ValuePointer>
</ArrayItems> </ArrayItems>
</Expand> </Expand>
</Type> </Type>
<!-- VS2015 and up -->
<Type Name="llvm::SmallVectorImpl&lt;*&gt;">
<DisplayString IncludeView ="elt0" Condition="(($T1*)EndX - ($T1*)BeginX) == 0"></DisplayString>
<DisplayString IncludeView ="elt0">{(($T1*)BeginX)[0]}{*this,view(elt1)}</DisplayString>
<DisplayString IncludeView ="elt1" Condition="(($T1*)EndX - ($T1*)BeginX) == 1"></DisplayString>
<DisplayString IncludeView ="elt1">, {(($T1*)BeginX)[1]}{*this,view(elt2)}</DisplayString>
<DisplayString IncludeView ="elt2" Condition="(($T1*)EndX - ($T1*)BeginX) == 2"></DisplayString>
<DisplayString IncludeView ="elt2">, {(($T1*)BeginX)[2]}{*this,view(elt3)}</DisplayString>
<DisplayString IncludeView ="elt3" Condition="(($T1*)EndX - ($T1*)BeginX) == 3"></DisplayString>
<DisplayString IncludeView ="elt3">, {(($T1*)BeginX)[2]}{*this,view(elt4)}</DisplayString>
<DisplayString IncludeView ="elt4" Condition="(($T1*)EndX - ($T1*)BeginX) == 4"></DisplayString>
<DisplayString IncludeView ="elt4">, /* {(($T1*)EndX - ($T1*)BeginX) - 4} more*/ </DisplayString>
<DisplayString Condition="(($T1*)EndX - ($T1*)BeginX) == 0">empty</DisplayString>
<DisplayString Condition="(($T1*)EndX - ($T1*)BeginX) != 0">{{{*this,view(elt0)}}}</DisplayString>
<Expand>
<Item Name="[size]">($T1*)EndX - ($T1*)BeginX</Item>
<Item Name="[capacity]">($T1*)CapacityX - ($T1*)BeginX</Item>
<ArrayItems>
<Size>($T1*)EndX - ($T1*)BeginX</Size>
<ValuePointer>($T1*)BeginX</ValuePointer>
</ArrayItems>
</Expand>
</Type>
<Type Name="llvm::ArrayRef&lt;*&gt;"> <Type Name="llvm::ArrayRef&lt;*&gt;">
<DisplayString Condition="Length == 0">empty</DisplayString> <DisplayString Condition="Length == 0">empty</DisplayString>
<DisplayString Condition="Length != 0">{{ size={Length} }}</DisplayString> <DisplayString Condition="Length != 0">{{ size={Length} }}</DisplayString>
<Expand> <Expand>
<Item Name="[size]">Length</Item> <Item Name="[size]">Length</Item>
<ArrayItems> <ArrayItems>
<Size>Length</Size> <Size>Length</Size>
<ValuePointer>Data</ValuePointer> <ValuePointer>Data</ValuePointer>
▲ Show 20 Lines • Show All 192 Lines • Show Last 20 Lines