This is an archive of the discontinued LLVM Phabricator instance.

Differential D21197

Invoke PruneEH pass before Sample Profile pass.
ClosedPublic

Authored by danielcdh on Jun 9 2016, 2:19 PM.

Details

Reviewers
dnovillo
davidxl
Commits
rG1997d8684f3e: Invoke PruneEH pass before Sample Profile pass.
rC273298: Invoke PruneEH pass before Sample Profile pass.
rL273298: Invoke PruneEH pass before Sample Profile pass.
Summary

We need to call PruneEH pass before AutoFDO pass so that some EH-related calls can get inlined in Sample Profile pass.

Diff Detail

Event Timeline

danielcdh updated this revision to Diff 60234.Jun 9 2016, 2:19 PM
danielcdh retitled this revision from to Invoke PruneEH pass before Sample Profile pass..
danielcdh updated this object.
danielcdh added reviewers: davidxl, dnovillo.
danielcdh added a subscriber: llvm-commits.
dnovillo edited edge metadata.Jun 9 2016, 3:47 PM

A small test case, perhaps?

Thanks. Diego.

junbuml added a subscriber: junbuml.Jun 14 2016, 6:49 AM
danielcdh updated this revision to Diff 61403.Jun 21 2016, 10:28 AM
danielcdh edited edge metadata.

add test

dnovillo accepted this revision.Jun 21 2016, 12:21 PM
dnovillo edited edge metadata.

LGTM. Thanks!

This revision is now accepted and ready to land.Jun 21 2016, 12:21 PM
danielcdh closed this revision.Jun 21 2016, 12:23 PM
leonardchan mentioned this in D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data.Jun 21 2019, 11:41 AM

Revision Contents

PathSize
lib/
CodeGen/
1 line
test/
CodeGen/
Inputs/
2 lines
6 lines

Diff 61403

lib/CodeGen/BackendUtil.cpp

Show First 20 Lines • Show All 482 Lines • ▼ Show 20 Lines if (!CodeGenOpts.InstrProfileOutput.empty())
PMBuilder.PGOInstrGen = CodeGenOpts.InstrProfileOutput; PMBuilder.PGOInstrGen = CodeGenOpts.InstrProfileOutput;
else else
PMBuilder.PGOInstrGen = "default.profraw"; PMBuilder.PGOInstrGen = "default.profraw";
} }
if (CodeGenOpts.hasProfileIRUse()) if (CodeGenOpts.hasProfileIRUse())
PMBuilder.PGOInstrUse = CodeGenOpts.ProfileInstrumentUsePath; PMBuilder.PGOInstrUse = CodeGenOpts.ProfileInstrumentUsePath;
if (!CodeGenOpts.SampleProfileFile.empty()) { if (!CodeGenOpts.SampleProfileFile.empty()) {
MPM->add(createPruneEHPass());
MPM->add(createSampleProfileLoaderPass(CodeGenOpts.SampleProfileFile)); MPM->add(createSampleProfileLoaderPass(CodeGenOpts.SampleProfileFile));
PMBuilder.addExtension(PassManagerBuilder::EP_EarlyAsPossible, PMBuilder.addExtension(PassManagerBuilder::EP_EarlyAsPossible,
addInstructionCombiningPass); addInstructionCombiningPass);
} }
PMBuilder.populateFunctionPassManager(*FPM); PMBuilder.populateFunctionPassManager(*FPM);
PMBuilder.populateModulePassManager(*MPM); PMBuilder.populateModulePassManager(*MPM);
} }
▲ Show 20 Lines • Show All 405 Lines • Show Last 20 Lines

test/CodeGen/Inputs/pgo-sample.prof

  • This file was added.
bar:100:100
1: 2000

test/CodeGen/pgo-sample.c

  • This file was added.
// Test if PGO sample use passes are invoked.
//
// Ensure Pass PGOInstrumentationGenPass is invoked.
// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample.prof %s -mllvm -debug-pass=Structure -emit-llvm -o - 2>&1 | FileCheck %s
// CHECK: Remove unused exception handling info
// CHECK: Sample profile pass