Page MenuHomePhabricator

[pdb] Dump symbol records in publics stream
ClosedPublic

Authored by zturner on May 24 2016, 10:39 AM.

Details

Summary

This abandons use of the hash table in favor of just iterating over each of the symbol records and dumping their full contents. So now instead of just the symbol names, we dump full record details of symbols in the publics stream.

Diff Detail

Event Timeline

zturner updated this revision to Diff 58271.May 24 2016, 10:39 AM
zturner retitled this revision from to [pdb] Dump symbol records in publics stream.
zturner updated this object.
zturner added reviewers: rnk, ruiu, amccarth.
zturner added a subscriber: llvm-commits.
ruiu edited edge metadata.May 24 2016, 10:41 AM

PublicSym32 and ProcRefSym classes are mostly the same. Are you going to add more classes like that?

The layout is the same but the field names are different. In the future I have some ideas how to reduce this code duplication, but for now it is needed. If you look at SymbolRecord.h you will see there is already quite a bit of it.

ruiu accepted this revision.May 24 2016, 10:51 AM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 24 2016, 10:51 AM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in r270597. Please specify Differential revision in commit message.