Clean up vestigial remnants of locking primitives

[compnerd]

Summary

This finally removes the use of the Mutex and Condition classes. This is an
intricate patch as the Mutex and Condition classes were tied together.
Furthermore, many places had slightly differing uses of time values. Convert
timeout values to relative everywhere to permit the use of
std::chrono::duration, which is required for the use of
std::condition_variable's timeout. Adjust all Condition and related Mutex
classes over to std::{,recursive_}mutex and std::condition_variable.

This change primarily comes at the cost of breaking the TracingMutex which was
based around the Mutex class. It would be possible to write a wrapper to
provide similar functionality, but that is beyond the scope of this change.

[clayborg]

We should think about converting everyone over to using std::chrono::microseconds for any timeout parameters that are currently "uint32_t timeout_usec". But we can do that in a future change.

source/Core/Communication.cpp

163–165

Should we convert the "timeout_usec" argument over to be a std::chrono::microseconds type?

[compnerd]

Yeah, I was thinking that once this clean up is done, we should remove the use of TimeValue in favor of std::chrono::duration.

[zturner]

I can try this on Windows tomorrow

[zturner]

I'm still getting a lot of crashes after this, but this will at least fix the compiler errors. I will try to look at the crashes on Monday.

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

354–355

Need to use auto here, otherwise there's a compiler error.

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

844

this needs to use std::chrono::duration_cast<std::chrono::microseconds>(until - std::chrono::system_clock::now()). Maybe raise this into a temporary variable (also make sure to use auto on the result just in case).

860

duration_cast again.

source/Target/Process.cpp

5547

Delete the cast here. Just use std::chrono::system_clock::now().

5551

Change to timeout.time_since_epoch()

[zturner]

Here is a patch you can apply on top of your patch to fix the compiler and
runtime errors (on Windows at least).

Most of the compiler errors were around the use of duration_cast. I've
never used std::chrono before, but my best guess is that system_time::now()
is a different type on Windows and other platforms, and so explicitly
specifying the type to store it to results in implicit conversion errors.
Apparently this is exactly what duration_cast is for, so I used it.

There was a semantic change in the event handler that caused runtime
errors. Basically in WaitForEventsInternal() if it didn't find an event
the first time, it would wait for a condition variable, then try again.
But in the changed code, it would wait for a condition variable and then
immediately return failure without retrying. So I fixed this and
everything seems to be going smooth.I would encourage Greg or someone else
to actually test this on OSX, but at least on Windows it looks good with
the attached patch.

• patch.txt5 KBDownload

[Eugene.Zelenko]

I think will be good idea to try to commit these changes before 3.9 branching.

[compnerd]

Ugh, yeah, I had forgotten about this. Ill try to get to this tonight/tomorrow.

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

354–355

Yeah, noticed that on Linux; Ill upload a new version of the patch. I ended up just doing the math in a second step.

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

844

Yeah, hoisting that into a local var sounds good.

860

Yeah.

source/Target/Process.cpp

5547

Yeah.

5551

This doesn't work for me. timeout is a std::duration, and std::time_point is needed.

[compnerd]

*hadn't

[compnerd]

Updated to the current tree.

[compnerd]

Tested against Linux-x86_64, tests state seems unchanged across the patch. @zturner you want to run another round on Windows before I merge this?

[emaste]

I'm testing on FreeBSD now

[emaste]

With this patch, test results on FreeBSD are consistent.

[emaste]

Is this ready to be committed?

[compnerd]

@emaste I think so. I was hoping that @zturner or @sas would be able to get a windows run. However, Linux and FreeBSD should give us some assurance that this is good. How about I go ahead and commit this tomorrow?

[compnerd]

SVN r277011

include/lldb/Core/Event.h

     }
 
     bool
-    WaitForEventReceived (const TimeValue *abstime = nullptr, bool *timed_out = nullptr)
+    WaitForEventReceived(const std::chrono::microseconds &abstime = std::chrono::microseconds(0),
+                         bool *timed_out = nullptr)
     {
         return m_predicate.WaitForValueEqualTo(true, abstime, timed_out);
     }

include/lldb/Core/Listener.h

 
 // C Includes
 // C++ Includes
+#include <chrono>
 #include <list>
 #include <map>
 #include <mutex>

 // Project includes
 #include "lldb/lldb-private.h"
 #include "lldb/Core/Broadcaster.h"
-#include "lldb/Host/Condition.h"
 #include "lldb/Core/Event.h"
 
 namespace lldb_private {

 
     // Returns true if an event was received, false if we timed out.
     bool
-    WaitForEvent (const TimeValue *timeout,
-                  lldb::EventSP &event_sp);
+    WaitForEvent(const std::chrono::microseconds &timeout, lldb::EventSP &event_sp);
 
     bool
-    WaitForEventForBroadcaster (const TimeValue *timeout,
-                                Broadcaster *broadcaster,
-                                lldb::EventSP &event_sp);
+    WaitForEventForBroadcaster(const std::chrono::microseconds &timeout, Broadcaster *broadcaster,
+                               lldb::EventSP &event_sp);
 
     bool
-    WaitForEventForBroadcasterWithType (const TimeValue *timeout,
-                                        Broadcaster *broadcaster,
-                                        uint32_t event_type_mask,
-                                        lldb::EventSP &event_sp);
+    WaitForEventForBroadcasterWithType(const std::chrono::microseconds &timeout, Broadcaster *broadcaster,
+                                       uint32_t event_type_mask, lldb::EventSP &event_sp);
 
     Event *
     PeekAtNextEvent ();

     typedef std::vector<lldb::BroadcasterManagerWP> broadcaster_manager_collection;
 
     bool
-    FindNextEventInternal(Mutex::Locker& lock,
+    FindNextEventInternal(std::unique_lock<std::mutex> &lock,
                           Broadcaster *broadcaster,   // nullptr for any broadcaster
                           const ConstString *sources, // nullptr for any event
-                          uint32_t num_sources,
-                          uint32_t event_type_mask,
-                          lldb::EventSP &event_sp,
-                          bool remove);
+                          uint32_t num_sources, uint32_t event_type_mask, lldb::EventSP &event_sp, bool remove);
 
     bool
     GetNextEventInternal(Broadcaster *broadcaster,   // nullptr for any broadcaster

                          lldb::EventSP &event_sp);
 
     bool
-    WaitForEventsInternal(const TimeValue *timeout,
+    WaitForEventsInternal(const std::chrono::microseconds &timeout,
                           Broadcaster *broadcaster,   // nullptr for any broadcaster
                           const ConstString *sources, // nullptr for any event
-                          uint32_t num_sources,
-                          uint32_t event_type_mask,
-                          lldb::EventSP &event_sp);
+                          uint32_t num_sources, uint32_t event_type_mask, lldb::EventSP &event_sp);
 
     std::string m_name;
     broadcaster_collection m_broadcasters;
     std::recursive_mutex m_broadcasters_mutex; // Protects m_broadcasters
     event_collection m_events;
-    Mutex m_events_mutex; // Protects m_broadcasters and m_events
-    Condition m_events_condition;
+    std::mutex m_events_mutex; // Protects m_broadcasters and m_events
+    std::condition_variable m_events_condition;
     broadcaster_manager_collection m_broadcaster_managers;
 
     void

include/lldb/Core/ThreadSafeDenseMap.h

 
 // C Includes
 // C++ Includes
+#include <mutex>
 
 // Other libraries and framework includes
 #include "llvm/ADT/DenseMap.h"
 
 // Project includes
-#include "lldb/Host/Mutex.h"
 
 namespace lldb_private {
-    
-template <typename _KeyType, typename _ValueType>
-class ThreadSafeDenseMap
+template <typename _KeyType, typename _ValueType, typename _MutexType = std::mutex> class ThreadSafeDenseMap
 {
 public:
     typedef llvm::DenseMap<_KeyType,_ValueType> LLVMMapType;
-    
-    ThreadSafeDenseMap(unsigned map_initial_capacity = 0,
-                       Mutex::Type mutex_type = Mutex::eMutexTypeNormal) :
-        m_map(map_initial_capacity),
-        m_mutex(mutex_type)
-    {
-    }
-    
+    ThreadSafeDenseMap(unsigned map_initial_capacity = 0) : m_map(map_initial_capacity), m_mutex() {}
+
     void
     Insert (_KeyType k, _ValueType v)
     {
-        Mutex::Locker locker(m_mutex);
+        std::lock_guard<_MutexType> guard(m_mutex);
         m_map.insert(std::make_pair(k,v));
     }
     
     void
     Erase (_KeyType k)
     {
-        Mutex::Locker locker(m_mutex);
+        std::lock_guard<_MutexType> guard(m_mutex);
         m_map.erase(k);
     }
     
     _ValueType
     Lookup (_KeyType k)
     {
-        Mutex::Locker locker(m_mutex);
+        std::lock_guard<_MutexType> guard(m_mutex);
         return m_map.lookup(k);
     }
 

     Lookup (_KeyType k,
             _ValueType& v)
     {
-        Mutex::Locker locker(m_mutex);
+        std::lock_guard<_MutexType> guard(m_mutex);
         auto iter = m_map.find(k),
              end = m_map.end();
         if (iter == end)

     void
     Clear ()
     {
-        Mutex::Locker locker(m_mutex);
+        std::lock_guard<_MutexType> guard(m_mutex);
         m_map.clear();
     }
 
 protected:
     LLVMMapType m_map;
-    Mutex m_mutex;
+    _MutexType m_mutex;
 };
 
 } // namespace lldb_private

include/lldb/Core/ThreadSafeDenseSet.h

 
 // C Includes
 // C++ Includes
+#include <mutex>
 
 // Other libraries and framework includes
 #include "llvm/ADT/DenseSet.h"
 
 // Project includes
-#include "lldb/Host/Mutex.h"
 
 namespace lldb_private {
-    
-    template <typename _ElementType>
-    class ThreadSafeDenseSet
+template <typename _ElementType, typename _MutexType = std::mutex> class ThreadSafeDenseSet
+{
+public:
+    typedef llvm::DenseSet<_ElementType> LLVMSetType;
+
+    ThreadSafeDenseSet(unsigned set_initial_capacity = 0) : m_set(set_initial_capacity), m_mutex() {}
+
+    void
+    Insert(_ElementType e)
+    {
+        std::lock_guard<_MutexType> guard(m_mutex);
+        m_set.insert(e);
+    }
+
+    void
+    Erase(_ElementType e)
     {
-    public:
-        typedef llvm::DenseSet<_ElementType> LLVMSetType;
-        
-        ThreadSafeDenseSet(unsigned set_initial_capacity = 0,
-                           Mutex::Type mutex_type = Mutex::eMutexTypeNormal) :
-        m_set(set_initial_capacity),
-        m_mutex(mutex_type)
-        {
-        }
-        
-        void
-        Insert (_ElementType e)
-        {
-            Mutex::Locker locker(m_mutex);
-            m_set.insert(e);
-        }
-        
-        void
-        Erase (_ElementType e)
-        {
-            Mutex::Locker locker(m_mutex);
-            m_set.erase(e);
-        }
-        
-        bool
-        Lookup (_ElementType e)
-        {
-            Mutex::Locker locker(m_mutex);
-            return (m_set.count(e) > 0);
-        }
-        
-        void
-        Clear ()
-        {
-            Mutex::Locker locker(m_mutex);
-            m_set.clear();
-        }
-        
-    protected:
-        LLVMSetType m_set;
-        Mutex m_mutex;
+        std::lock_guard<_MutexType> guard(m_mutex);
+        m_set.erase(e);
+    }
+
+    bool
+    Lookup(_ElementType e)
+    {
+        std::lock_guard<_MutexType> guard(m_mutex);
+        return (m_set.count(e) > 0);
+    }
+
+    void
+    Clear()
+    {
+        std::lock_guard<_MutexType> guard(m_mutex);
+        m_set.clear();
+    }
+
+protected:
+    LLVMSetType m_set;
+    _MutexType m_mutex;
     };
     
 } // namespace lldb_private

include/lldb/Host/Condition.h

-//===-- Condition.h ---------------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef liblldb_Condition_h_
-#define liblldb_Condition_h_
-
-// C Includes
-// C++ Includes
-// Other libraries and framework includes
-// Project includes
-#include "lldb/lldb-types.h"
-#include "lldb/Host/Mutex.h"
-
-namespace lldb_private {
-
-class TimeValue;
-
-//----------------------------------------------------------------------
-/// @class Condition Condition.h "lldb/Host/Condition.h"
-/// @brief A C++ wrapper class for pthread condition variables.
-///
-/// A class that wraps up a pthread condition (pthread_cond_t). The
-/// class will create a pthread condition when an instance is
-/// constructed, and destroy it when it is destructed. It also provides
-/// access to the standard pthread condition calls.
-//----------------------------------------------------------------------
-class Condition
-{
-public:
-    //------------------------------------------------------------------
-    /// Default constructor
-    ///
-    /// The default constructor will initialize a new pthread condition
-    /// and maintain the condition in the object state.
-    //------------------------------------------------------------------
-    Condition ();
-
-    //------------------------------------------------------------------
-    /// Destructor
-    ///
-    /// Destroys the pthread condition that the object owns.
-    //------------------------------------------------------------------
-    ~Condition ();
-
-    //------------------------------------------------------------------
-    /// Unblock all threads waiting for a condition variable
-    ///
-    /// @return
-    ///     The return value from \c pthread_cond_broadcast()
-    //------------------------------------------------------------------
-    int
-    Broadcast ();
-
-    //------------------------------------------------------------------
-    /// Unblocks one thread waiting for the condition variable
-    ///
-    /// @return
-    ///     The return value from \c pthread_cond_signal()
-    //------------------------------------------------------------------
-    int
-    Signal ();
-
-    //------------------------------------------------------------------
-    /// Wait for the condition variable to be signaled.
-    ///
-    /// The Wait() function atomically blocks the current thread
-    /// waiting on this object's condition variable, and unblocks
-    /// \a mutex. The waiting thread unblocks only after another thread
-    /// signals or broadcasts this object's condition variable.
-    ///
-    /// If \a abstime is non-nullptr, this function will return when the
-    /// system time reaches the time specified in \a abstime if the
-    /// condition variable doesn't get unblocked. If \a abstime is nullptr
-    /// this function will wait for an infinite amount of time for the
-    /// condition variable to be unblocked.
-    ///
-    /// The current thread re-acquires the lock on \a mutex following
-    /// the wait.
-    ///
-    /// @param[in] mutex
-    ///     The mutex to use in the \c pthread_cond_timedwait() or
-    ///     \c pthread_cond_wait() calls.
-    ///
-    /// @param[in] abstime
-    ///     An absolute time at which to stop waiting if non-nullptr, else
-    ///     wait an infinite amount of time for the condition variable
-    ///     toget signaled.
-    ///
-    /// @param[out] timed_out
-    ///     If not nullptr, will be set to true if the wait timed out, and
-    //      false otherwise.
-    ///
-    /// @see Condition::Broadcast()
-    /// @see Condition::Signal()
-    //------------------------------------------------------------------
-    int
-    Wait(Mutex &mutex, const TimeValue *abstime = nullptr, bool *timed_out = nullptr);
-
-protected:
-    //------------------------------------------------------------------
-    // Member variables
-    //------------------------------------------------------------------
-    lldb::condition_t m_condition; ///< The condition variable.
-    
-    //------------------------------------------------------------------
-    /// Get accessor to the pthread condition object.
-    ///
-    /// @return
-    ///     A pointer to the condition variable owned by this object.
-    //------------------------------------------------------------------
-    lldb::condition_t *
-    GetCondition ();
-};
-
-} // namespace lldb_private
-
-#endif // liblldb_Condition_h_

include/lldb/Host/Editline.h

 #include <string>
 #include <vector>
 
-#include "lldb/Host/Condition.h"
 #include "lldb/Host/ConnectionFileDescriptor.h"
 #include "lldb/Host/FileSpec.h"
 #include "lldb/Host/Predicate.h"

include/lldb/Host/Mutex.h

-//===-- Mutex.h -------------------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef liblldb_Mutex_h_
-#define liblldb_Mutex_h_
-
-// C Includes
-// C++ Includes
-#ifdef LLDB_CONFIGURATION_DEBUG
-#include <string>
-#endif
-
-// Other libraries and framework includes
-// Project includes
-#include "lldb/lldb-types.h"
-
-namespace lldb_private {
-
-//----------------------------------------------------------------------
-/// @class Mutex Mutex.h "lldb/Host/Mutex.h"
-/// @brief A C++ wrapper class for pthread mutexes.
-//----------------------------------------------------------------------
-class Mutex
-{
-public:
-    friend class Locker;
-    friend class Condition;
-    
-    enum Type
-    {
-        eMutexTypeNormal,       ///< Mutex that can't recursively entered by the same thread
-        eMutexTypeRecursive     ///< Mutex can be recursively entered by the same thread
-    };
-
-    //------------------------------------------------------------------
-    /// @class Mutex::Locker
-    ///
-    /// A scoped locking class that allows a variety of pthread mutex
-    /// objects to have a mutex locked when an Mutex::Locker
-    /// object is created, and unlocked when it goes out of scope or
-    /// when the Mutex::Locker::Reset(pthread_mutex_t *)
-    /// is called. This provides an exception safe way to lock a mutex
-    /// in a scope.
-    //------------------------------------------------------------------
-    class Locker
-    {
-    public:
-        //--------------------------------------------------------------
-        /// Default constructor.
-        ///
-        /// This will create a scoped mutex locking object that doesn't
-        /// have a mutex to lock. One will need to be provided using the
-        /// Mutex::Locker::Reset(pthread_mutex_t *) method.
-        ///
-        /// @see Mutex::Locker::Reset(pthread_mutex_t *)
-        //--------------------------------------------------------------
-        Locker();
-
-        //--------------------------------------------------------------
-        /// Constructor with a Mutex object.
-        ///
-        /// This will create a scoped mutex locking object that extracts
-        /// the mutex owned by \a m and locks it.
-        ///
-        /// @param[in] m
-        ///     An instance of a Mutex object that contains a
-        ///     valid mutex object.
-        //--------------------------------------------------------------
-        Locker(Mutex& m);
-
-        //--------------------------------------------------------------
-        /// Constructor with a Mutex object pointer.
-        ///
-        /// This will create a scoped mutex locking object that extracts
-        /// the mutex owned by a m and locks it.
-        ///
-        /// @param[in] m
-        ///     A pointer to instance of a Mutex object that
-        ///     contains a valid mutex object.
-        //--------------------------------------------------------------
-        Locker(Mutex* m);
-
-        //--------------------------------------------------------------
-        /// Destructor
-        ///
-        /// Unlocks any valid pthread_mutex_t that this object may
-        /// contain.
-        //--------------------------------------------------------------
-        ~Locker();
-
-        //--------------------------------------------------------------
-        /// Change the contained mutex.
-        ///
-        /// Unlock the current mutex in this object (if it contains a
-        /// valid mutex) and lock the new \a mutex object if it is
-        /// non-nullptr.
-        //--------------------------------------------------------------
-        void
-        Lock (Mutex &mutex);
-        
-        void
-        Lock (Mutex *mutex)
-        {
-            if (mutex)
-                Lock(*mutex);
-        }
-
-        //--------------------------------------------------------------
-        /// Change the contained mutex only if the mutex can be locked.
-        ///
-        /// Unlock the current mutex in this object (if it contains a
-        /// valid mutex) and try to lock \a mutex. If \a mutex can be 
-        /// locked this object will take ownership of the lock and will
-        /// unlock it when it goes out of scope or Reset or TryLock are
-        /// called again. If the mutex is already locked, this object
-        /// will not take ownership of the mutex.
-        ///
-        /// @return
-        ///     Returns \b true if the lock was acquired and the this
-        ///     object will unlock the mutex when it goes out of scope,
-        ///     returns \b false otherwise.
-        //--------------------------------------------------------------
-        bool
-        TryLock(Mutex &mutex, const char *failure_message = nullptr);
-        
-        bool
-        TryLock(Mutex *mutex, const char *failure_message = nullptr)
-        {
-            if (mutex)
-                return TryLock(*mutex, failure_message);
-            else
-                return false;
-        }
-
-        void
-        Unlock ();
-
-    protected:
-        //--------------------------------------------------------------
-        /// Member variables
-        //--------------------------------------------------------------
-        Mutex *m_mutex_ptr;
-
-    private:
-        Locker(const Locker&);
-        const Locker& operator=(const Locker&);
-    };
-
-    //------------------------------------------------------------------
-    /// Default constructor.
-    ///
-    /// Creates a pthread mutex with no attributes.
-    //------------------------------------------------------------------
-    Mutex();
-
-    //------------------------------------------------------------------
-    /// Default constructor.
-    ///
-    /// Creates a pthread mutex with \a type as the mutex type.
-    /// Valid values for \a type include:
-    ///     @li Mutex::Type::eMutexTypeNormal
-    ///     @li Mutex::Type::eMutexTypeRecursive
-    ///
-    /// @param[in] type
-    ///     The type of the mutex.
-    ///
-    /// @see ::pthread_mutexattr_settype()
-    //------------------------------------------------------------------
-    Mutex(Mutex::Type type);
-
-    //------------------------------------------------------------------
-    /// Destructor.
-    ///
-    /// Destroys the mutex owned by this object.
-    //------------------------------------------------------------------
-#ifdef LLDB_CONFIGURATION_DEBUG
-    virtual
-#endif
-    ~Mutex();
-
-    //------------------------------------------------------------------
-    /// Lock the mutex.
-    ///
-    /// Locks the mutex owned by this object. If the mutex is already
-    /// locked, the calling thread will block until the mutex becomes
-    /// available.
-    ///
-    /// @return
-    ///     The error code from \c pthread_mutex_lock().
-    //------------------------------------------------------------------
-#ifdef LLDB_CONFIGURATION_DEBUG
-    virtual
-#endif
-    int
-    Lock();
-
-    //------------------------------------------------------------------
-    /// Try to lock the mutex.
-    ///
-    /// Attempts to lock the mutex owned by this object without blocking.
-    /// If the mutex is already locked, TryLock() will not block waiting
-    /// for the mutex, but will return an error condition.
-    ///
-    /// @return
-    ///     The error code from \c pthread_mutex_trylock().
-    //------------------------------------------------------------------
-#ifdef LLDB_CONFIGURATION_DEBUG
-    virtual
-#endif
-    int
-    TryLock(const char *failure_message = nullptr);
-
-    //------------------------------------------------------------------
-    /// Unlock the mutex.
-    ///
-    /// If the current thread holds the lock on the owned mutex, then
-    /// Unlock() will unlock the mutex. Calling Unlock() on this object
-    /// when the calling thread does not hold the lock will result in
-    /// undefined behavior.
-    ///
-    /// @return
-    ///     The error code from \c pthread_mutex_unlock().
-    //------------------------------------------------------------------
-#ifdef LLDB_CONFIGURATION_DEBUG
-    virtual
-#endif
-    int
-    Unlock();
-
-protected:
-    //------------------------------------------------------------------
-    // Member variables
-    //------------------------------------------------------------------
-    // TODO: Hide the mutex in the implementation file in case we ever need to port to an
-    // architecture that doesn't have pthread mutexes.
-    lldb::mutex_t m_mutex; ///< The OS mutex object.
-
-private:
-    //------------------------------------------------------------------
-    /// Mutex get accessor.
-    ///
-    /// @return
-    ///     A pointer to the pthread mutex object owned by this object.
-    //------------------------------------------------------------------
-    lldb::mutex_t *
-    GetMutex();
-
-    Mutex(const Mutex&);
-    const Mutex& operator=(const Mutex&);
-};
-
-#ifdef LLDB_CONFIGURATION_DEBUG
-class TrackingMutex : public Mutex
-{
-public:
-    TrackingMutex() : Mutex()  {}
-    TrackingMutex(Mutex::Type type) : Mutex (type) {}
-    
-    virtual
-    ~TrackingMutex() = default;
-    
-    virtual int
-    Unlock ();
-
-    virtual int
-    TryLock(const char *failure_message = nullptr)
-    {
-        int return_value = Mutex::TryLock();
-        if (return_value != 0 && failure_message != nullptr)
-        {
-            m_failure_message.assign(failure_message);
-            m_thread_that_tried = pthread_self();
-        }
-        return return_value;
-    }
-    
-protected:
-    pthread_t m_thread_that_tried;
-    std::string m_failure_message;
-};
-
-class LoggingMutex : public Mutex
-{
-public:
-    LoggingMutex() : Mutex(),m_locked(false)  {}
-    LoggingMutex(Mutex::Type type) : Mutex (type),m_locked(false) {}
-    
-    virtual
-    ~LoggingMutex() = default;
-    
-    virtual int
-    Lock ();
-    
-    virtual int
-    Unlock ();
-    
-    virtual int
-    TryLock(const char *failure_message = nullptr);
-
-protected:
-    bool m_locked;
-};
-#endif // LLDB_CONFIGURATION_DEBUG
-
-} // namespace lldb_private
-
-#endif // liblldb_Mutex_h_

include/lldb/Host/Predicate.h

 #include <time.h>
 
 // C++ Includes
+#include <mutex>
+
 // Other libraries and framework includes
 // Project includes
 #include "lldb/lldb-defines.h"
-#include "lldb/Host/Mutex.h"
-#include "lldb/Host/Condition.h"
 
 //#define DB_PTHREAD_LOG_EVENTS
 

     /// Initializes the mutex, condition and value with their default
     /// constructors.
     //------------------------------------------------------------------
-    Predicate () :
-        m_value(),
-        m_mutex(),
-        m_condition()
-    {
-    }
+    Predicate() : m_value(), m_mutex(), m_condition() {}
 
     //------------------------------------------------------------------
     /// Construct with initial T value \a initial_value.

     /// @param[in] initial_value
     ///     The initial value for our T object.
     //------------------------------------------------------------------
-    Predicate (T initial_value)  :
-        m_value(initial_value),
-        m_mutex(),
-        m_condition()
-    {
-    }
+    Predicate(T initial_value) : m_value(initial_value), m_mutex(), m_condition() {}
 
     //------------------------------------------------------------------
     /// Destructor.

     T
     GetValue () const
     {
-        Mutex::Locker locker(m_mutex);
+        std::lock_guard<std::mutex> guard(m_mutex);
         T value = m_value;
         return value;
     }

     void
     SetValue (T value, PredicateBroadcastType broadcast_type)
     {
-        Mutex::Locker locker(m_mutex);
+        std::lock_guard<std::mutex> guard(m_mutex);
 #ifdef DB_PTHREAD_LOG_EVENTS
         printf("%s (value = 0x%8.8x, broadcast_type = %i)\n", __FUNCTION__, value, broadcast_type);
 #endif

     void
     SetValueBits (T bits, PredicateBroadcastType broadcast_type)
     {
-        Mutex::Locker locker(m_mutex);
+        std::lock_guard<std::mutex> guard(m_mutex);
 #ifdef DB_PTHREAD_LOG_EVENTS
         printf("%s (bits = 0x%8.8x, broadcast_type = %i)\n", __FUNCTION__, bits, broadcast_type);
 #endif

     void
     ResetValueBits (T bits, PredicateBroadcastType broadcast_type)
     {
-        Mutex::Locker locker(m_mutex);
+        std::lock_guard<std::mutex> guard(m_mutex);
 #ifdef DB_PTHREAD_LOG_EVENTS
         printf("%s (bits = 0x%8.8x, broadcast_type = %i)\n", __FUNCTION__, bits, broadcast_type);
 #endif

     ///     occurred.
     //------------------------------------------------------------------
     T
-    WaitForSetValueBits(T bits, const TimeValue *abstime = nullptr)
+    WaitForSetValueBits(T bits, const std::chrono::microseconds &timeout = std::chrono::microseconds(0))
     {
-        int err = 0;
         // pthread_cond_timedwait() or pthread_cond_wait() will atomically
         // unlock the mutex and wait for the condition to be set. When either
         // function returns, they will re-lock the mutex. We use an auto lock/unlock
         // class (Mutex::Locker) to allow us to return at any point in this
         // function and not have to worry about unlocking the mutex.
-        Mutex::Locker locker(m_mutex);
+        std::unique_lock<std::mutex> lock(m_mutex);
+
 #ifdef DB_PTHREAD_LOG_EVENTS
-        printf("%s (bits = 0x%8.8x, abstime = %p), m_value = 0x%8.8x\n", __FUNCTION__, bits, abstime, m_value);
+        printf("%s (bits = 0x%8.8x, timeout = %llu), m_value = 0x%8.8x\n", __FUNCTION__, bits, timeout.count(),
+               m_value);
 #endif
-        while (err == 0 && ((m_value & bits) == 0))
+        while ((m_value & bits) == 0)
         {
-            err = m_condition.Wait (m_mutex, abstime);
+            if (timeout == std::chrono::microseconds(0))
+            {
+                m_condition.wait(lock);
+            }
+            else
+            {
+                std::cv_status result = m_condition.wait_for(lock, timeout);
+                if (result == std::cv_status::timeout)
+                    break;
+            }
         }
 #ifdef DB_PTHREAD_LOG_EVENTS
         printf("%s (bits = 0x%8.8x), m_value = 0x%8.8x, returning 0x%8.8x\n", __FUNCTION__, bits, m_value, m_value & bits);

     ///     unrecoverable error occurs.
     //------------------------------------------------------------------
     T
-    WaitForResetValueBits(T bits, const TimeValue *abstime = nullptr)
+    WaitForResetValueBits(T bits, const std::chrono::microseconds &timeout = std::chrono::microseconds(0))
     {
-        int err = 0;
-
         // pthread_cond_timedwait() or pthread_cond_wait() will atomically
         // unlock the mutex and wait for the condition to be set. When either
         // function returns, they will re-lock the mutex. We use an auto lock/unlock
         // class (Mutex::Locker) to allow us to return at any point in this
         // function and not have to worry about unlocking the mutex.
-        Mutex::Locker locker(m_mutex);
+        std::unique_lock<std::mutex> lock(m_mutex);
 
 #ifdef DB_PTHREAD_LOG_EVENTS
-        printf("%s (bits = 0x%8.8x, abstime = %p), m_value = 0x%8.8x\n", __FUNCTION__, bits, abstime, m_value);
+        printf("%s (bits = 0x%8.8x, timeout = %llu), m_value = 0x%8.8x\n", __FUNCTION__, bits, timeout.count(),
+               m_value);
 #endif
-        while (err == 0 && ((m_value & bits) != 0))
+        while ((m_value & bits) != 0)
         {
-            err = m_condition.Wait (m_mutex, abstime);
+            if (timeout == std::chrono::microseconds(0))
+            {
+                m_condition.wait(lock);
+            }
+            else
+            {
+                std::cv_status result = m_condition.wait_for(lock, timeout);
+                if (result == std::cv_status::timeout)
+                    break;
+            }
         }
 
 #ifdef DB_PTHREAD_LOG_EVENTS

     ///     @li \b false otherwise
     //------------------------------------------------------------------
     bool
-    WaitForValueEqualTo(T value, const TimeValue *abstime = nullptr, bool *timed_out = nullptr)
+    WaitForValueEqualTo(T value, const std::chrono::microseconds &timeout = std::chrono::microseconds(0),
+                        bool *timed_out = nullptr)
     {
-        int err = 0;
         // pthread_cond_timedwait() or pthread_cond_wait() will atomically
         // unlock the mutex and wait for the condition to be set. When either
         // function returns, they will re-lock the mutex. We use an auto lock/unlock
         // class (Mutex::Locker) to allow us to return at any point in this
         // function and not have to worry about unlocking the mutex.
-        Mutex::Locker locker(m_mutex);
+        std::unique_lock<std::mutex> lock(m_mutex);
 
 #ifdef DB_PTHREAD_LOG_EVENTS
-        printf("%s (value = 0x%8.8x, abstime = %p), m_value = 0x%8.8x\n", __FUNCTION__, value, abstime, m_value);
+        printf("%s (value = 0x%8.8x, timeout = %llu), m_value = 0x%8.8x\n", __FUNCTION__, value, timeout.count(),
+               m_value);
 #endif
         if (timed_out)
             *timed_out = false;
 
-        while (err == 0 && m_value != value)
+        while (m_value != value)
         {
-            err = m_condition.Wait (m_mutex, abstime, timed_out);
+            if (timeout == std::chrono::microseconds(0))
+            {
+                m_condition.wait(lock);
+            }
+            else
+            {
+                std::cv_status result = m_condition.wait_for(lock, timeout);
+                if (result == std::cv_status::timeout)
+                {
+                    if (timed_out)
+                        *timed_out = true;
+                    break;
+                }
+            }
         }
 
         return m_value == value;

     //------------------------------------------------------------------
     bool
     WaitForValueEqualToAndSetValueTo(T wait_value, T new_value,
-                                     const TimeValue *abstime = nullptr,
+                                     const std::chrono::microseconds &timeout = std::chrono::microseconds(0),
                                      bool *timed_out = nullptr)
     {
         int err = 0;

         // function returns, they will re-lock the mutex. We use an auto lock/unlock
         // class (Mutex::Locker) to allow us to return at any point in this
         // function and not have to worry about unlocking the mutex.
-        Mutex::Locker locker(m_mutex);
+        std::unique_lock<std::mutex> lock(m_mutex);
 
 #ifdef DB_PTHREAD_LOG_EVENTS
-        printf("%s (wait_value = 0x%8.8x, new_value = 0x%8.8x, abstime = %p), m_value = 0x%8.8x\n", __FUNCTION__, wait_value, new_value, abstime, m_value);
+        printf("%s (wait_value = 0x%8.8x, new_value = 0x%8.8x, timeout = %llu), m_value = 0x%8.8x\n", __FUNCTION__,
+               wait_value, new_value, timeout.count(), m_value);
 #endif
         if (timed_out)
             *timed_out = false;
 
         while (err == 0 && m_value != wait_value)
         {
-            err = m_condition.Wait (m_mutex, abstime, timed_out);
+            if (timeout == std::chrono::microseconds(0))
+                m_condition.wait(lock);
+            else
+                err = m_condition.wait_for(lock, timeout);
         }
 
         if (m_value == wait_value)

     ///     @li \b false otherwise
     //------------------------------------------------------------------
     bool
-    WaitForValueNotEqualTo(T value, T &new_value, const TimeValue *abstime = nullptr)
+    WaitForValueNotEqualTo(T value, T &new_value,
+                           const std::chrono::microseconds &timeout = std::chrono::microseconds(0))
     {
         int err = 0;
         // pthread_cond_timedwait() or pthread_cond_wait() will atomically

         // function returns, they will re-lock the mutex. We use an auto lock/unlock
         // class (Mutex::Locker) to allow us to return at any point in this
         // function and not have to worry about unlocking the mutex.
-        Mutex::Locker locker(m_mutex);
+        std::unique_lock<std::mutex> lock(m_mutex);
+
 #ifdef DB_PTHREAD_LOG_EVENTS
-        printf("%s (value = 0x%8.8x, abstime = %p), m_value = 0x%8.8x\n", __FUNCTION__, value, abstime, m_value);
+        printf("%s (value = 0x%8.8x, timeout = %llu), m_value = 0x%8.8x\n", __FUNCTION__, value, timeout.count(),
+               m_value);
 #endif
         while (err == 0 && m_value == value)
         {
-            err = m_condition.Wait (m_mutex, abstime);
+            if (timeout == std::chrono::microseconds(0))
+                m_condition.wait(lock);
+            else
+                m_condition.wait_for(lock, timeout);
         }
 
         if (m_value != value)

     // blocking between the main thread and the spotlight index thread.
     //----------------------------------------------------------------------
     T           m_value;        ///< The templatized value T that we are protecting access to
-    mutable Mutex m_mutex;      ///< The mutex to use when accessing the data
-    Condition   m_condition;    ///< The pthread condition variable to use for signaling that data available or changed.
+    mutable std::mutex m_mutex; ///< The mutex to use when accessing the data
+    std::condition_variable
+        m_condition; ///< The pthread condition variable to use for signaling that data available or changed.
 
 private:
     //------------------------------------------------------------------

         printf("%s (old_value = 0x%8.8x, broadcast_type = %i) m_value = 0x%8.8x, broadcast = %u\n", __FUNCTION__, old_value, broadcast_type, m_value, broadcast);
 #endif
         if (broadcast)
-            m_condition.Broadcast();
+            m_condition.notify_all();
     }
 
     DISALLOW_COPY_AND_ASSIGN(Predicate);

include/lldb/Host/ProcessRunLock.h

 // Other libraries and framework includes
 // Project includes
 #include "lldb/lldb-defines.h"
-#include "lldb/Host/Condition.h"
 
 //----------------------------------------------------------------------
 /// Enumerations for broadcasting.

include/lldb/Target/Process.h

     SyncIOHandler (uint32_t iohandler_id, uint64_t timeout_msec);
 
     lldb::StateType
-    WaitForStateChangedEvents(const TimeValue *timeout,
-                              lldb::EventSP &event_sp,
+    WaitForStateChangedEvents(const std::chrono::microseconds &timeout, lldb::EventSP &event_sp,
                               lldb::ListenerSP hijack_listener); // Pass an empty ListenerSP to use builtin listener
 
     //--------------------------------------------------------------------------------------

     HaltPrivate();
 
     lldb::StateType
-    WaitForProcessStopPrivate (const TimeValue *timeout, lldb::EventSP &event_sp);
+    WaitForProcessStopPrivate(const std::chrono::microseconds &timeout, lldb::EventSP &event_sp);
 
     // This waits for both the state change broadcaster, and the control broadcaster.
     // If control_only, it only waits for the control broadcaster.
 
     bool
-    WaitForEventsPrivate (const TimeValue *timeout, lldb::EventSP &event_sp, bool control_only);
+    WaitForEventsPrivate(const std::chrono::microseconds &timeout, lldb::EventSP &event_sp, bool control_only);
 
     lldb::StateType
-    WaitForStateChangedEventsPrivate (const TimeValue *timeout, lldb::EventSP &event_sp);
+    WaitForStateChangedEventsPrivate(const std::chrono::microseconds &timeout, lldb::EventSP &event_sp);
 
     lldb::StateType
-    WaitForState (const TimeValue *timeout,
-                  const lldb::StateType *match_states,
-                  const uint32_t num_match_states);
+    WaitForState(const std::chrono::microseconds &timeout, const lldb::StateType *match_states,
+                 const uint32_t num_match_states);
 
     size_t
     WriteMemoryPrivate (lldb::addr_t addr, const void *buf, size_t size, Error &error);

source/API/SBListener.cpp

 
     if (m_opaque_sp)
     {
-        TimeValue time_value;
+        std::chrono::microseconds timeout = std::chrono::microseconds(0);
         if (timeout_secs != UINT32_MAX)
         {
-            assert (timeout_secs != 0); // Take this out after all calls with timeout set to zero have been removed....
-            time_value = TimeValue::Now();
-            time_value.OffsetWithSeconds (timeout_secs);
+            assert(timeout_secs != 0); // Take this out after all calls with timeout set to zero have been removed....
+            timeout = std::chrono::seconds(timeout_secs);
         }
         EventSP event_sp;
-        if (m_opaque_sp->WaitForEvent (time_value.IsValid() ? &time_value : NULL, event_sp))
+        if (m_opaque_sp->WaitForEvent(timeout, event_sp))
         {
             event.reset (event_sp);
             success = true;

 {
     if (m_opaque_sp && broadcaster.IsValid())
     {
-        TimeValue time_value;
+        std::chrono::microseconds timeout;
         if (num_seconds != UINT32_MAX)
-        {
-            time_value = TimeValue::Now();
-            time_value.OffsetWithSeconds (num_seconds);
-        }
+            timeout = std::chrono::seconds(num_seconds);
+
         EventSP event_sp;
-        if (m_opaque_sp->WaitForEventForBroadcaster (time_value.IsValid() ? &time_value : NULL,
-                                                         broadcaster.get(),
-                                                         event_sp))
+        if (m_opaque_sp->WaitForEventForBroadcaster(timeout, broadcaster.get(), event_sp))
         {
             event.reset (event_sp);
             return true;

 {
     if (m_opaque_sp && broadcaster.IsValid())
     {
-        TimeValue time_value;
+        std::chrono::microseconds timeout;
         if (num_seconds != UINT32_MAX)
-        {
-            time_value = TimeValue::Now();
-            time_value.OffsetWithSeconds (num_seconds);
-        }
+            timeout = std::chrono::seconds(num_seconds);
         EventSP event_sp;
-        if (m_opaque_sp->WaitForEventForBroadcasterWithType (time_value.IsValid() ? &time_value : NULL,
-                                                              broadcaster.get(),
-                                                              event_type_mask,
-                                                              event_sp))
+        if (m_opaque_sp->WaitForEventForBroadcasterWithType(timeout, broadcaster.get(), event_type_mask, event_sp))
         {
             event.reset (event_sp);
             return true;

source/Core/Communication.cpp

             status = eConnectionStatusNoConnection;
             return 0;
         }
-        // Set the timeout appropriately
-        TimeValue timeout_time;
-        if (timeout_usec != UINT32_MAX)
-        {
-            timeout_time = TimeValue::Now();
-            timeout_time.OffsetWithMicroSeconds (timeout_usec);
-        }
 
         ListenerSP listener_sp(Listener::MakeListener("Communication::Read"));
         listener_sp->StartListeningForEvents (this, eBroadcastBitReadThreadGotBytes | eBroadcastBitReadThreadDidExit);
         EventSP event_sp;
-        while (listener_sp->WaitForEvent (timeout_time.IsValid() ? &timeout_time : nullptr, event_sp))
+        while (listener_sp->WaitForEvent((timeout_usec == UINT32_MAX) ? std::chrono::microseconds(0)
+                                                                      : std::chrono::microseconds(timeout_usec),
+                                         event_sp))
         {
             const uint32_t event_type = event_sp->GetType();
             if (event_type & eBroadcastBitReadThreadGotBytes)

 
     // Wait for the synchronization event.
     EventSP event_sp;
-    listener_sp->WaitForEvent(nullptr, event_sp);
+    listener_sp->WaitForEvent(std::chrono::microseconds(0), event_sp);
 }
 
 void

source/Core/Debugger.cpp

     while (!done)
     {
         EventSP event_sp;
-        if (listener_sp->WaitForEvent(nullptr, event_sp))
+        if (listener_sp->WaitForEvent(std::chrono::microseconds(0), event_sp))
         {
             if (event_sp)
             {

         // eBroadcastBitEventThreadIsListening so we don't need to check the event, we just need
         // to wait an infinite amount of time for it (nullptr timeout as the first parameter)
         lldb::EventSP event_sp;
-        listener_sp->WaitForEvent(nullptr, event_sp);
+        listener_sp->WaitForEvent(std::chrono::microseconds(0), event_sp);
     }
     return m_event_handler_thread.IsJoinable();
 }

source/Core/Listener.cpp

 } // anonymous namespace
 
 Listener::Listener(const char *name)
-    : m_name(name), m_broadcasters(), m_broadcasters_mutex(), m_events(), m_events_mutex(Mutex::eMutexTypeNormal)
+    : m_name(name), m_broadcasters(), m_broadcasters_mutex(), m_events(), m_events_mutex()
 {
-    Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_OBJECT));
+    Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_OBJECT));
     if (log != nullptr)
-        log->Printf ("%p Listener::Listener('%s')",
-                     static_cast<void*>(this), m_name.c_str());
+        log->Printf("%p Listener::Listener('%s')", static_cast<void *>(this), m_name.c_str());
 }
 
 Listener::~Listener()

 Listener::Clear()
 {
     Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_OBJECT));
-    std::lock_guard<std::recursive_mutex> guard(m_broadcasters_mutex);
+    std::lock_guard<std::recursive_mutex> broadcasters_guard(m_broadcasters_mutex);
     broadcaster_collection::iterator pos, end = m_broadcasters.end();
     for (pos = m_broadcasters.begin(); pos != end; ++pos)
     {

     }
     m_broadcasters.clear();
 
-    Mutex::Locker event_locker(m_events_mutex);
+    std::lock_guard<std::mutex> events_guard(m_events_mutex);
     m_events.clear();
     size_t num_managers = m_broadcaster_managers.size();
 

 
     // Scope for "event_locker"
     {
-        Mutex::Locker event_locker(m_events_mutex);
+        std::lock_guard<std::mutex> guard(m_events_mutex);
         // Remove all events for this broadcaster object.
         event_collection::iterator pos = m_events.begin();
         while (pos != m_events.end())

                      static_cast<void*>(this), m_name.c_str(),
                      static_cast<void*>(event_sp.get()));
 
-    Mutex::Locker locker(m_events_mutex);
+    std::lock_guard<std::mutex> guard(m_events_mutex);
     m_events.push_back (event_sp);
-    m_events_condition.Broadcast();
+    m_events_condition.notify_all();
 }
 
 class EventBroadcasterMatches

 };
 
 bool
-Listener::FindNextEventInternal
-(
-    Mutex::Locker& lock,
-    Broadcaster *broadcaster,   // nullptr for any broadcaster
-    const ConstString *broadcaster_names, // nullptr for any event
-    uint32_t num_broadcaster_names,
-    uint32_t event_type_mask,
-    EventSP &event_sp,
-    bool remove)
+Listener::FindNextEventInternal(std::unique_lock<std::mutex> &lock,
+                                Broadcaster *broadcaster,             // nullptr for any broadcaster
+                                const ConstString *broadcaster_names, // nullptr for any event
+                                uint32_t num_broadcaster_names, uint32_t event_type_mask, EventSP &event_sp,
+                                bool remove)
 {
     // NOTE: callers of this function must lock m_events_mutex using a Mutex::Locker
     // and pass the locker as the first argument. m_events_mutex is no longer recursive.

             // Unlock the event queue here.  We've removed this event and are about to return
             // it so it should be okay to get the next event off the queue here - and it might
             // be useful to do that in the "DoOnRemoval".
-            lock.Unlock();
+            lock.unlock();
             event_sp->DoOnRemoval();
         }
         return true;

 Event *
 Listener::PeekAtNextEvent ()
 {
-    Mutex::Locker lock(m_events_mutex);
+    std::unique_lock<std::mutex> guard(m_events_mutex);
     EventSP event_sp;
-    if (FindNextEventInternal(lock, nullptr, nullptr, 0, 0, event_sp, false))
+    if (FindNextEventInternal(guard, nullptr, nullptr, 0, 0, event_sp, false))
         return event_sp.get();
     return nullptr;
 }

 Event *
 Listener::PeekAtNextEventForBroadcaster (Broadcaster *broadcaster)
 {
-    Mutex::Locker lock(m_events_mutex);
+    std::unique_lock<std::mutex> guard(m_events_mutex);
     EventSP event_sp;
-    if (FindNextEventInternal(lock, broadcaster, nullptr, 0, 0, event_sp, false))
+    if (FindNextEventInternal(guard, broadcaster, nullptr, 0, 0, event_sp, false))
         return event_sp.get();
     return nullptr;
 }

 Event *
 Listener::PeekAtNextEventForBroadcasterWithType (Broadcaster *broadcaster, uint32_t event_type_mask)
 {
-    Mutex::Locker lock(m_events_mutex);
+    std::unique_lock<std::mutex> guard(m_events_mutex);
     EventSP event_sp;
-    if (FindNextEventInternal(lock, broadcaster, nullptr, 0, event_type_mask, event_sp, false))
+    if (FindNextEventInternal(guard, broadcaster, nullptr, 0, event_type_mask, event_sp, false))
         return event_sp.get();
     return nullptr;
 }

                                uint32_t event_type_mask,
                                EventSP &event_sp)
 {
-    Mutex::Locker lock(m_events_mutex);
-    return FindNextEventInternal (lock, broadcaster, broadcaster_names, num_broadcaster_names, event_type_mask, event_sp, true);
+    std::unique_lock<std::mutex> guard(m_events_mutex);
+    return FindNextEventInternal(guard, broadcaster, broadcaster_names, num_broadcaster_names, event_type_mask,
+                                 event_sp, true);
 }
 
 bool

 }
 
 bool
-Listener::WaitForEventsInternal(const TimeValue *timeout,
+Listener::WaitForEventsInternal(const std::chrono::microseconds &timeout,
                                 Broadcaster *broadcaster,             // nullptr for any broadcaster
                                 const ConstString *broadcaster_names, // nullptr for any event
-                                uint32_t num_broadcaster_names,
-                                uint32_t event_type_mask,
-                                EventSP &event_sp)
+                                uint32_t num_broadcaster_names, uint32_t event_type_mask, EventSP &event_sp)
 {
     Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_EVENTS));
     if (log != nullptr)
-        log->Printf ("%p Listener::WaitForEventsInternal (timeout = { %p }) for %s",
-                     static_cast<void*>(this), static_cast<const void*>(timeout),
-                     m_name.c_str());
+        log->Printf("%p Listener::WaitForEventsInternal (timeout = %llu us) for %s", static_cast<void *>(this),
+                    timeout.count(), m_name.c_str());
 
-    Mutex::Locker lock(m_events_mutex);
+    std::unique_lock<std::mutex> lock(m_events_mutex);
 
     while (true)
     {

         }
         else
         {
-            bool timed_out = false;
-            if (m_events_condition.Wait(m_events_mutex, timeout, &timed_out) != 0)
+            std::cv_status result = std::cv_status::no_timeout;
+
+            if (timeout == std::chrono::microseconds(0))
+                m_events_condition.wait(lock);
+            else
+                result = m_events_condition.wait_for(lock, timeout);
+
+            if (result == std::cv_status::timeout)
             {
-                if (timed_out)
-                {
-                    log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_EVENTS);
-                    if (log != nullptr)
-                        log->Printf ("%p Listener::WaitForEventsInternal() timed out for %s",
-                                     static_cast<void*>(this), m_name.c_str());
-                }
-                else
-                {
-                    log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_EVENTS);
-                    if (log != nullptr)
-                        log->Printf ("%p Listener::WaitForEventsInternal() unknown error for %s",
-                                     static_cast<void*>(this), m_name.c_str());
-                }
-                return false;
+                log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_EVENTS);
+                if (log != nullptr)
+                    log->Printf("%p Listener::WaitForEventsInternal() timed out for %s", static_cast<void *>(this),
+                                m_name.c_str());
             }
+            else
+            {
+                log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_EVENTS);
+                if (log != nullptr)
+                    log->Printf("%p Listener::WaitForEventsInternal() unknown error for %s", static_cast<void *>(this),
+                                m_name.c_str());
+            }
+            return false;
         }
     }
 

 }
 
 bool
-Listener::WaitForEventForBroadcasterWithType(const TimeValue *timeout,
-                                             Broadcaster *broadcaster,
-                                             uint32_t event_type_mask,
-                                             EventSP &event_sp)
+Listener::WaitForEventForBroadcasterWithType(const std::chrono::microseconds &timeout, Broadcaster *broadcaster,
+                                             uint32_t event_type_mask, EventSP &event_sp)
 {
     return WaitForEventsInternal(timeout, broadcaster, nullptr, 0, event_type_mask, event_sp);
 }
 
 bool
-Listener::WaitForEventForBroadcaster(const TimeValue *timeout,
-                                     Broadcaster *broadcaster,
+Listener::WaitForEventForBroadcaster(const std::chrono::microseconds &timeout, Broadcaster *broadcaster,
                                      EventSP &event_sp)
 {
     return WaitForEventsInternal(timeout, broadcaster, nullptr, 0, 0, event_sp);
 }
 
 bool
-Listener::WaitForEvent (const TimeValue *timeout, EventSP &event_sp)
+Listener::WaitForEvent(const std::chrono::microseconds &timeout, EventSP &event_sp)
 {
     return WaitForEventsInternal(timeout, nullptr, nullptr, 0, 0, event_sp);
 }

source/Host/CMakeLists.txt

 endmacro()
 
 add_host_subdirectory(common
-  common/Condition.cpp
   common/File.cpp
   common/FileCache.cpp
   common/FileSpec.cpp

   common/HostThread.cpp
   common/IOObject.cpp
   common/LockFileBase.cpp
-  common/Mutex.cpp
   common/MonitoringProcessLauncher.cpp
   common/NativeBreakpoint.cpp
   common/NativeBreakpointList.cpp

 
 if (CMAKE_SYSTEM_NAME MATCHES "Windows")
   add_host_subdirectory(windows
-    windows/Condition.cpp
     windows/ConnectionGenericFileWindows.cpp
     windows/EditLineWin.cpp
     windows/FileSystem.cpp

     windows/HostProcessWindows.cpp
     windows/HostThreadWindows.cpp
     windows/LockFileWindows.cpp
-    windows/Mutex.cpp
     windows/PipeWindows.cpp
     windows/ProcessLauncherWindows.cpp
     windows/ProcessRunLock.cpp

source/Host/common/Condition.cpp

-//===-- Condition.cpp -------------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include <errno.h>
-
-#include "lldb/Host/Condition.h"
-#include "lldb/Host/TimeValue.h"
-
-
-using namespace lldb_private;
-
-#ifndef _WIN32
-
-//----------------------------------------------------------------------
-// Default constructor
-//
-// The default constructor will initialize a new pthread condition
-// and maintain the condition in the object state.
-//----------------------------------------------------------------------
-Condition::Condition () :
-    m_condition()
-{
-    ::pthread_cond_init (&m_condition, NULL);
-}
-
-//----------------------------------------------------------------------
-// Destructor
-//
-// Destroys the pthread condition that the object owns.
-//----------------------------------------------------------------------
-Condition::~Condition ()
-{
-    ::pthread_cond_destroy (&m_condition);
-}
-
-//----------------------------------------------------------------------
-// Unblock all threads waiting for a condition variable
-//----------------------------------------------------------------------
-int
-Condition::Broadcast ()
-{
-    return ::pthread_cond_broadcast (&m_condition);
-}
-
-//----------------------------------------------------------------------
-// Unblocks one thread waiting for the condition variable
-//----------------------------------------------------------------------
-int
-Condition::Signal ()
-{
-    return ::pthread_cond_signal (&m_condition);
-}
-
-//----------------------------------------------------------------------
-// The Wait() function atomically blocks the current thread
-// waiting on the owned condition variable, and unblocks the mutex
-// specified by "mutex".  The waiting thread unblocks only after
-// another thread calls Signal(), or Broadcast() with the same
-// condition variable, or if "abstime" is valid (non-NULL) this
-// function will return when the system time reaches the time
-// specified in "abstime". If "abstime" is NULL this function will
-// wait for an infinite amount of time for the condition variable
-// to be signaled or broadcasted.
-//
-// The current thread re-acquires the lock on "mutex".
-//----------------------------------------------------------------------
-int
-Condition::Wait (Mutex &mutex, const TimeValue *abstime, bool *timed_out)
-{
-    int err = 0;
-    do
-    {
-        if (abstime && abstime->IsValid())
-        {
-            struct timespec abstime_ts = abstime->GetAsTimeSpec();
-            err = ::pthread_cond_timedwait (&m_condition, mutex.GetMutex(), &abstime_ts);
-        }
-        else
-            err = ::pthread_cond_wait (&m_condition, mutex.GetMutex());
-    } while (err == EINTR);
-
-    if (timed_out != NULL)
-    {
-        if (err == ETIMEDOUT)
-            *timed_out = true;
-        else
-            *timed_out = false;
-    }
-
-    return err;
-}
-
-#endif
-
-//----------------------------------------------------------------------
-// Get accessor to the pthread condition object
-//----------------------------------------------------------------------
-lldb::condition_t *
-Condition::GetCondition()
-{
-    return &m_condition;
-}

source/Host/common/Host.cpp

     
     if (error.Success())
     {
-        TimeValue *timeout_ptr = nullptr;
-        TimeValue timeout_time(TimeValue::Now());
-        if (timeout_sec > 0) {
-            timeout_time.OffsetWithSeconds(timeout_sec);
-            timeout_ptr = &timeout_time;
-        }
         bool timed_out = false;
-        shell_info_sp->process_reaped.WaitForValueEqualTo(true, timeout_ptr, &timed_out);
+        shell_info_sp->process_reaped.WaitForValueEqualTo(true, std::chrono::seconds(timeout_sec), &timed_out);
         if (timed_out)
         {
             error.SetErrorString("timed out waiting for shell command to complete");

             // Kill the process since it didn't complete within the timeout specified
             Kill (pid, SIGKILL);
             // Wait for the monitor callback to get the message
-            timeout_time = TimeValue::Now();
-            timeout_time.OffsetWithSeconds(1);
             timed_out = false;
-            shell_info_sp->process_reaped.WaitForValueEqualTo(true, &timeout_time, &timed_out);
+            shell_info_sp->process_reaped.WaitForValueEqualTo(true, std::chrono::seconds(1), &timed_out);
         }
         else
         {

source/Host/common/Mutex.cpp

-//===-- Mutex.cpp -----------------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include "lldb/Host/Mutex.h"
-#include "lldb/Host/Host.h"
-
-#ifndef _WIN32
-#include <pthread.h>
-#endif
-#include <string.h>
-#include <stdio.h>
-
-#if 0
-// This logging is way too verbose to enable even for a log channel. 
-// This logging can be enabled by changing the "#if 0", but should be
-// reverted prior to checking in.
-#include <cstdio>
-#define DEBUG_LOG(fmt, ...) printf(fmt, ## __VA_ARGS__)
-#else
-#define DEBUG_LOG(fmt, ...)
-#endif
-
-// Enable extra mutex error checking
-#if 0 // LLDB_CONFIGURATION_DEBUG
-#define ENABLE_MUTEX_ERROR_CHECKING 1
-#include <inttypes.h>
-#endif
-
-#if ENABLE_MUTEX_ERROR_CHECKING
-#include <set>
-
-enum MutexAction
-{
-    eMutexActionInitialized,
-    eMutexActionDestroyed,
-    eMutexActionAssertInitialized
-};
-
-static bool
-error_check_mutex (pthread_mutex_t *m, MutexAction action)
-{
-    typedef std::set<pthread_mutex_t *> mutex_set;
-    static pthread_mutex_t g_mutex_set_mutex = PTHREAD_MUTEX_INITIALIZER;
-    static mutex_set g_initialized_mutex_set;
-    static mutex_set g_destroyed_mutex_set;
-
-    bool success = true;
-    int err;
-    // Manually call lock so we don't to any of this error checking
-    err = ::pthread_mutex_lock (&g_mutex_set_mutex);
-    assert(err == 0);
-    switch (action)
-    {
-        case eMutexActionInitialized:
-            // Make sure this isn't already in our initialized mutex set...
-            assert (g_initialized_mutex_set.find(m) == g_initialized_mutex_set.end());
-            // Remove this from the destroyed set in case it was ever in there
-            g_destroyed_mutex_set.erase(m);
-            // Add the mutex to the initialized set
-            g_initialized_mutex_set.insert(m);
-            break;
-            
-        case eMutexActionDestroyed:
-            // Make sure this isn't already in our destroyed mutex set...
-            assert (g_destroyed_mutex_set.find(m) == g_destroyed_mutex_set.end());
-            // Remove this from the initialized so we can put it into the destroyed set
-            g_initialized_mutex_set.erase(m);
-            // Add the mutex to the destroyed set
-            g_destroyed_mutex_set.insert(m);
-            break;
-        case eMutexActionAssertInitialized:
-            // This function will return true if "m" is in the initialized mutex set
-            success = g_initialized_mutex_set.find(m) != g_initialized_mutex_set.end();
-            assert (success);
-            break;
-    }
-    // Manually call unlock so we don't to any of this error checking
-    err = ::pthread_mutex_unlock (&g_mutex_set_mutex);
-    assert(err == 0);
-    return success;
-}
-
-#endif
-
-using namespace lldb_private;
-
-//----------------------------------------------------------------------
-// Default constructor.
-//
-// This will create a scoped mutex locking object that doesn't have
-// a mutex to lock. One will need to be provided using the Reset()
-// method.
-//----------------------------------------------------------------------
-Mutex::Locker::Locker () :
-    m_mutex_ptr(NULL)
-{
-}
-
-//----------------------------------------------------------------------
-// Constructor with a Mutex object.
-//
-// This will create a scoped mutex locking object that extracts the
-// mutex owned by "m" and locks it.
-//----------------------------------------------------------------------
-Mutex::Locker::Locker (Mutex& m) :
-    m_mutex_ptr(NULL)
-{
-    Lock (m);
-}
-
-//----------------------------------------------------------------------
-// Constructor with a Mutex object pointer.
-//
-// This will create a scoped mutex locking object that extracts the
-// mutex owned by "m" and locks it.
-//----------------------------------------------------------------------
-Mutex::Locker::Locker (Mutex* m) :
-    m_mutex_ptr(NULL)
-{
-    if (m)
-        Lock (m);
-}
-
-//----------------------------------------------------------------------
-// Destructor
-//
-// Unlocks any owned mutex object (if it is valid).
-//----------------------------------------------------------------------
-Mutex::Locker::~Locker ()
-{
-    Unlock();
-}
-
-//----------------------------------------------------------------------
-// Unlock the current mutex in this object (if this owns a valid
-// mutex) and lock the new "mutex" object if it is non-NULL.
-//----------------------------------------------------------------------
-void
-Mutex::Locker::Lock (Mutex &mutex)
-{
-    // We already have this mutex locked or both are NULL...
-    if (m_mutex_ptr == &mutex)
-        return;
-
-    Unlock ();
-
-    m_mutex_ptr = &mutex;
-    m_mutex_ptr->Lock();
-}
-
-void
-Mutex::Locker::Unlock ()
-{
-    if (m_mutex_ptr)
-    {
-        m_mutex_ptr->Unlock ();
-        m_mutex_ptr = NULL;
-    }
-}
-
-bool
-Mutex::Locker::TryLock (Mutex &mutex, const char *failure_message)
-{
-    // We already have this mutex locked!
-    if (m_mutex_ptr == &mutex)
-        return true;
-
-    Unlock ();
-
-    if (mutex.TryLock(failure_message) == 0)
-        m_mutex_ptr = &mutex;
-
-    return m_mutex_ptr != NULL;
-}
-
-#ifndef _WIN32
-
-//----------------------------------------------------------------------
-// Default constructor.
-//
-// Creates a pthread mutex with no attributes.
-//----------------------------------------------------------------------
-Mutex::Mutex () :
-    m_mutex()
-{
-    int err;
-    err = ::pthread_mutex_init (&m_mutex, NULL);
-#if ENABLE_MUTEX_ERROR_CHECKING
-    if (err == 0)
-        error_check_mutex (&m_mutex, eMutexActionInitialized);
-#endif
-    assert(err == 0);
-}
-
-//----------------------------------------------------------------------
-// Default constructor.
-//
-// Creates a pthread mutex with "type" as the mutex type.
-//----------------------------------------------------------------------
-Mutex::Mutex (Mutex::Type type) :
-    m_mutex()
-{
-    int err;
-    ::pthread_mutexattr_t attr;
-    err = ::pthread_mutexattr_init (&attr);
-    assert(err == 0);
-    switch (type)
-    {
-    case eMutexTypeNormal:
-#if ENABLE_MUTEX_ERROR_CHECKING
-        err = ::pthread_mutexattr_settype (&attr, PTHREAD_MUTEX_ERRORCHECK);
-#else
-        err = ::pthread_mutexattr_settype (&attr, PTHREAD_MUTEX_NORMAL);
-#endif
-        break;
-
-    case eMutexTypeRecursive:
-        err = ::pthread_mutexattr_settype (&attr, PTHREAD_MUTEX_RECURSIVE);
-        break;
-    }
-    assert(err == 0);
-    err = ::pthread_mutex_init (&m_mutex, &attr);
-#if ENABLE_MUTEX_ERROR_CHECKING
-    if (err == 0)
-        error_check_mutex (&m_mutex, eMutexActionInitialized);
-#endif
-    assert(err == 0);
-    err = ::pthread_mutexattr_destroy (&attr);
-    assert(err == 0);
-}
-
-//----------------------------------------------------------------------
-// Destructor.
-//
-// Destroys the mutex owned by this object.
-//----------------------------------------------------------------------
-Mutex::~Mutex()
-{
-#if ENABLE_MUTEX_ERROR_CHECKING
-    int err = ::pthread_mutex_destroy (&m_mutex);
-    assert(err == 0);
-    if (err == 0)
-        error_check_mutex (&m_mutex, eMutexActionDestroyed);
-    else
-    {
-        Host::SetCrashDescriptionWithFormat ("%s error: pthread_mutex_destroy() => err = %i (%s)", __PRETTY_FUNCTION__, err, strerror(err));
-        assert(err == 0);
-    }
-    memset (&m_mutex, '\xba', sizeof(m_mutex));
-#else
-    ::pthread_mutex_destroy (&m_mutex);
-#endif
-}
-
-//----------------------------------------------------------------------
-// Locks the mutex owned by this object, if the mutex is already
-// locked, the calling thread will block until the mutex becomes
-// available.
-//
-// RETURNS
-//  The error code from the pthread_mutex_lock() function call.
-//----------------------------------------------------------------------
-int
-Mutex::Lock()
-{
-    DEBUG_LOG ("[%4.4" PRIx64 "/%4.4" PRIx64 "] pthread_mutex_lock (%p)...\n", Host::GetCurrentProcessID(), Host::GetCurrentThreadID(), &m_mutex);
-
-#if ENABLE_MUTEX_ERROR_CHECKING
-    error_check_mutex (&m_mutex, eMutexActionAssertInitialized);
-#endif
-
-    int err = ::pthread_mutex_lock (&m_mutex);
-    
-
-#if ENABLE_MUTEX_ERROR_CHECKING
-    if (err)
-    {
-        Host::SetCrashDescriptionWithFormat ("%s error: pthread_mutex_lock(%p) => err = %i (%s)", __PRETTY_FUNCTION__, &m_mutex, err, strerror(err));
-        assert(err == 0);
-    }
-#endif
-    DEBUG_LOG ("[%4.4" PRIx64 "/%4.4" PRIx64 "] pthread_mutex_lock (%p) => %i\n", Host::GetCurrentProcessID(), Host::GetCurrentThreadID(), &m_mutex, err);
-    return err;
-}
-
-//----------------------------------------------------------------------
-// Attempts to lock the mutex owned by this object without blocking.
-// If the mutex is already locked, TryLock() will not block waiting
-// for the mutex, but will return an error condition.
-//
-// RETURNS
-//  The error code from the pthread_mutex_trylock() function call.
-//----------------------------------------------------------------------
-int
-Mutex::TryLock(const char *failure_message)
-{
-#if ENABLE_MUTEX_ERROR_CHECKING
-    error_check_mutex (&m_mutex, eMutexActionAssertInitialized);
-#endif
-
-    int err = ::pthread_mutex_trylock (&m_mutex);
-    DEBUG_LOG ("[%4.4" PRIx64 "/%4.4" PRIx64 "] pthread_mutex_trylock (%p) => %i\n", Host::GetCurrentProcessID(), Host::GetCurrentThreadID(), &m_mutex, err);
-    return err;
-}
-
-//----------------------------------------------------------------------
-// If the current thread holds the lock on the owned mutex, then
-// Unlock() will unlock the mutex. Calling Unlock() on this object
-// that the calling thread does not hold will result in undefined
-// behavior.
-//
-// RETURNS
-//  The error code from the pthread_mutex_unlock() function call.
-//----------------------------------------------------------------------
-int
-Mutex::Unlock()
-{
-#if ENABLE_MUTEX_ERROR_CHECKING
-    error_check_mutex (&m_mutex, eMutexActionAssertInitialized);
-#endif
-
-    int err = ::pthread_mutex_unlock (&m_mutex);
-
-#if ENABLE_MUTEX_ERROR_CHECKING
-    if (err)
-    {
-        Host::SetCrashDescriptionWithFormat ("%s error: pthread_mutex_unlock(%p) => err = %i (%s)", __PRETTY_FUNCTION__, &m_mutex, err, strerror(err));
-        assert(err == 0);
-    }
-#endif
-    DEBUG_LOG ("[%4.4" PRIx64 "/%4.4" PRIx64 "] pthread_mutex_unlock (%p) => %i\n", Host::GetCurrentProcessID(), Host::GetCurrentThreadID(), &m_mutex, err);
-    return err;
-}
-
-#endif
-
-//----------------------------------------------------------------------
-// Mutex get accessor.
-//----------------------------------------------------------------------
-lldb::mutex_t *
-Mutex::GetMutex()
-{
-    return &m_mutex;
-}
-
-#ifdef LLDB_CONFIGURATION_DEBUG
-int
-TrackingMutex::Unlock ()
-{
-    if (!m_failure_message.empty())
-        Host::SetCrashDescriptionWithFormat ("Unlocking lock (on thread %p) that thread: %p failed to get: %s",
-                                             pthread_self(),
-                                             m_thread_that_tried,
-                                             m_failure_message.c_str());
-    assert (m_failure_message.empty());
-    return Mutex::Unlock();
-}
-
-int
-LoggingMutex::Lock ()
-{
-    printf("locking mutex %p by [%4.4" PRIx64 "/%4.4" PRIx64 "]...", this, Host::GetCurrentProcessID(), Host::GetCurrentThreadID());
-    int x = Mutex::Lock();
-    m_locked = true;
-    printf("%d\n",x);
-    return x;
-}
-
-int
-LoggingMutex::Unlock ()
-{
-    printf("unlocking mutex %p by [%4.4" PRIx64 "/%4.4" PRIx64 "]...", this, Host::GetCurrentProcessID(), Host::GetCurrentThreadID());
-    int x = Mutex::Unlock();
-    m_locked = false;
-    printf("%d\n",x);
-    return x;
-}
-
-int
-LoggingMutex::TryLock (const char *failure_message)
-{
-    printf("trylocking mutex %p by [%4.4" PRIx64 "/%4.4" PRIx64 "]...", this, Host::GetCurrentProcessID(), Host::GetCurrentThreadID());
-    int x = Mutex::TryLock(failure_message);
-    if (x == 0)
-        m_locked = true;
-    printf("%d\n",x);
-    return x;
-}
-
-#endif
-
-

source/Host/posix/ConnectionFileDescriptorPosix.cpp

     if (timeout_sec == UINT32_MAX)
         m_port_predicate.WaitForValueNotEqualTo(0, bound_port);
     else
-    {
-        TimeValue timeout = TimeValue::Now();
-        timeout.OffsetWithSeconds(timeout_sec);
-        m_port_predicate.WaitForValueNotEqualTo(0, bound_port, &timeout);
-    }
+        m_port_predicate.WaitForValueNotEqualTo(0, bound_port, std::chrono::seconds(timeout_sec));
     return bound_port;
 }
 

source/Host/windows/Condition.cpp

-//===-- Condition.cpp -------------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include <errno.h>
-
-#include "lldb/Host/Condition.h"
-#include "lldb/Host/TimeValue.h"
-#include "lldb/Host/windows/windows.h"
-
-
-using namespace lldb_private;
-
-//----------------------------------------------------------------------
-// Default constructor
-//
-// The default constructor will initialize a new pthread condition
-// and maintain the condition in the object state.
-//----------------------------------------------------------------------
-Condition::Condition () :
-    m_condition()
-{
-    m_condition = static_cast<PCONDITION_VARIABLE>(malloc(sizeof(CONDITION_VARIABLE)));
-    InitializeConditionVariable(static_cast<PCONDITION_VARIABLE>(m_condition));
-}
-
-//----------------------------------------------------------------------
-// Destructor
-//
-// Destroys the pthread condition that the object owns.
-//----------------------------------------------------------------------
-Condition::~Condition ()
-{
-    free(m_condition);
-}
-
-//----------------------------------------------------------------------
-// Unblock all threads waiting for a condition variable
-//----------------------------------------------------------------------
-int
-Condition::Broadcast ()
-{
-    WakeAllConditionVariable(static_cast<PCONDITION_VARIABLE>(m_condition));
-    return 0;
-}
-
-//----------------------------------------------------------------------
-// Unblocks one thread waiting for the condition variable
-//----------------------------------------------------------------------
-int
-Condition::Signal ()
-{
-    WakeConditionVariable(static_cast<PCONDITION_VARIABLE>(m_condition));
-    return 0;
-}
-
-//----------------------------------------------------------------------
-// The Wait() function atomically blocks the current thread
-// waiting on the owned condition variable, and unblocks the mutex
-// specified by "mutex".  The waiting thread unblocks only after
-// another thread calls Signal(), or Broadcast() with the same
-// condition variable, or if "abstime" is valid (non-NULL) this
-// function will return when the system time reaches the time
-// specified in "abstime". If "abstime" is NULL this function will
-// wait for an infinite amount of time for the condition variable
-// to be signaled or broadcasted.
-//
-// The current thread re-acquires the lock on "mutex".
-//----------------------------------------------------------------------
-int
-Condition::Wait (Mutex &mutex, const TimeValue *abstime, bool *timed_out)
-{
-    DWORD wait = INFINITE;
-    if (abstime != NULL) {
-        int wval = (*abstime - TimeValue::Now()) / 1000000;
-        if (wval < 0) wval = 0;
-
-        wait = wval;
-    }
-
-    int err = SleepConditionVariableCS(static_cast<PCONDITION_VARIABLE>(m_condition), static_cast<PCRITICAL_SECTION>(mutex.m_mutex), wait);
-
-    if (timed_out != NULL)
-    {
-        if ((err == 0) && GetLastError() == ERROR_TIMEOUT)
-            *timed_out = true;
-        else
-            *timed_out = false;
-    }
-
-    return err == 0;
-}
-

source/Host/windows/Mutex.cpp

-//===-- Mutex.cpp -----------------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include "lldb/Host/Mutex.h"
-#include "lldb/Host/Host.h"
-#include "lldb/Host/windows/windows.h"
-
-#include <string.h>
-#include <stdio.h>
-
-#if 0
-// This logging is way too verbose to enable even for a log channel.
-// This logging can be enabled by changing the "#if 0", but should be
-// reverted prior to checking in.
-#include <cstdio>
-#define DEBUG_LOG(fmt, ...) printf(fmt, ## __VA_ARGS__)
-#else
-#define DEBUG_LOG(fmt, ...)
-#endif
-
-using namespace lldb_private;
-
-//----------------------------------------------------------------------
-// Default constructor.
-//
-// Creates a pthread mutex with no attributes.
-//----------------------------------------------------------------------
-Mutex::Mutex () :
-    m_mutex()
-{
-    m_mutex = static_cast<PCRITICAL_SECTION>(malloc(sizeof(CRITICAL_SECTION)));
-    InitializeCriticalSection(static_cast<PCRITICAL_SECTION>(m_mutex));
-}
-
-//----------------------------------------------------------------------
-// Default constructor.
-//
-// Creates a pthread mutex with "type" as the mutex type.
-//----------------------------------------------------------------------
-Mutex::Mutex (Mutex::Type type) :
-    m_mutex()
-{
-    m_mutex = static_cast<PCRITICAL_SECTION>(malloc(sizeof(CRITICAL_SECTION)));
-    InitializeCriticalSection(static_cast<PCRITICAL_SECTION>(m_mutex));
-}
-
-//----------------------------------------------------------------------
-// Destructor.
-//
-// Destroys the mutex owned by this object.
-//----------------------------------------------------------------------
-Mutex::~Mutex()
-{
-    DeleteCriticalSection(static_cast<PCRITICAL_SECTION>(m_mutex));
-    free(m_mutex);
-}
-
-//----------------------------------------------------------------------
-// Locks the mutex owned by this object, if the mutex is already
-// locked, the calling thread will block until the mutex becomes
-// available.
-//
-// RETURNS
-//  The error code from the pthread_mutex_lock() function call.
-//----------------------------------------------------------------------
-int
-Mutex::Lock()
-{
-    DEBUG_LOG ("[%4.4" PRIx64 "/%4.4" PRIx64 "] pthread_mutex_lock (%p)...\n", Host::GetCurrentProcessID(), Host::GetCurrentThreadID(), m_mutex);
-
-    EnterCriticalSection(static_cast<PCRITICAL_SECTION>(m_mutex));
-    return 0;
-}
-
-//----------------------------------------------------------------------
-// Attempts to lock the mutex owned by this object without blocking.
-// If the mutex is already locked, TryLock() will not block waiting
-// for the mutex, but will return an error condition.
-//
-// RETURNS
-//  The error code from the pthread_mutex_trylock() function call.
-//----------------------------------------------------------------------
-int
-Mutex::TryLock(const char *failure_message)
-{
-    return TryEnterCriticalSection(static_cast<PCRITICAL_SECTION>(m_mutex)) == 0;
-}
-
-//----------------------------------------------------------------------
-// If the current thread holds the lock on the owned mutex, then
-// Unlock() will unlock the mutex. Calling Unlock() on this object
-// that the calling thread does not hold will result in undefined
-// behavior.
-//
-// RETURNS
-//  The error code from the pthread_mutex_unlock() function call.
-//----------------------------------------------------------------------
-int
-Mutex::Unlock()
-{
-    LeaveCriticalSection(static_cast<PCRITICAL_SECTION>(m_mutex));
-    return 0;
-}

source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.h

                                                 uint32_t timeout_usec);
 
     bool
-    WaitForNotRunningPrivate (const lldb_private::TimeValue *timeout_ptr);
+    WaitForNotRunningPrivate(const std::chrono::microseconds &timeout);
 
     void
     MakeRequestPacketHeader (CommandType request_type, 

source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp

     return (lock = std::unique_lock<std::recursive_mutex>(m_sequence_mutex, std::try_to_lock)).owns_lock();
 }
 
-
 bool
-CommunicationKDP::WaitForNotRunningPrivate (const TimeValue *timeout_ptr)
+CommunicationKDP::WaitForNotRunningPrivate(const std::chrono::microseconds &timeout)
 {
-    return m_is_running.WaitForValueEqualTo (false, timeout_ptr, NULL);
+    return m_is_running.WaitForValueEqualTo(false, timeout, NULL);
 }
 
 size_t

source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp

             if (log)
                 log->Printf ("ProcessKDP::AsyncThread (pid = %" PRIu64 ") listener.WaitForEvent (NULL, event_sp)...",
                              pid);
-            if (listener_sp->WaitForEvent (NULL, event_sp))
+            if (listener_sp->WaitForEvent(std::chrono::microseconds(0), event_sp))
             {
                 uint32_t event_type = event_sp->GetType();
                 if (log)

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h

 #include "lldb/Core/Communication.h"
 #include "lldb/Core/Listener.h"
 #include "lldb/Host/HostThread.h"
-#include "lldb/Host/Mutex.h"
 #include "lldb/Host/Predicate.h"
 #include "lldb/Host/TimeValue.h"
 #include "lldb/Interpreter/Args.h"

                         size_t payload_length);
 
     bool
-    GetSequenceMutex(Mutex::Locker& locker, const char *failure_message = nullptr);
+    GetSequenceMutex(std::unique_lock<std::recursive_mutex> &lock);
 
     PacketType
     CheckForPacket (const uint8_t *src, 

     uint32_t m_echo_number;
     LazyBool m_supports_qEcho;
 #ifdef ENABLE_MUTEX_ERROR_CHECKING
+#error TrackingMutex is no longer supported
     TrackingMutex m_sequence_mutex;
 #else
-    Mutex m_sequence_mutex;    // Restrict access to sending/receiving packets to a single thread at a time
+    std::recursive_mutex m_sequence_mutex; // Restrict access to sending/receiving packets to a single thread at a time
 #endif
     Predicate<bool> m_public_is_running;
     Predicate<bool> m_private_is_running;

                                                 bool sync_on_timeout);
 
     bool
-    WaitForNotRunningPrivate (const TimeValue *timeout_ptr);
+    WaitForNotRunningPrivate(const std::chrono::microseconds &timeout);
 
     bool
     CompressionIsEnabled ()

 
 private:
     std::queue<StringExtractorGDBRemote> m_packet_queue; // The packet queue
-    lldb_private::Mutex m_packet_queue_mutex;            // Mutex for accessing queue
-    Condition m_condition_queue_not_empty;               // Condition variable to wait for packets
+    std::mutex m_packet_queue_mutex;                     // Mutex for accessing queue
+    std::condition_variable m_condition_queue_not_empty; // Condition variable to wait for packets
 
     HostThread m_listen_thread;
     std::string m_listen_url;

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

 using namespace lldb_private;
 using namespace lldb_private::process_gdb_remote;
 
-GDBRemoteCommunication::History::History (uint32_t size) :
-    m_packets(),
-    m_curr_idx (0),
-    m_total_packet_count (0),
-    m_dumped_to_log (false)
+GDBRemoteCommunication::History::History(uint32_t size)
+    : m_packets(), m_curr_idx(0), m_total_packet_count(0), m_dumped_to_log(false)
 {
     m_packets.resize(size);
 }

 //----------------------------------------------------------------------
 // GDBRemoteCommunication constructor
 //----------------------------------------------------------------------
-GDBRemoteCommunication::GDBRemoteCommunication(const char *comm_name, 
-                                               const char *listener_name) :
-    Communication(comm_name),
+GDBRemoteCommunication::GDBRemoteCommunication(const char *comm_name, const char *listener_name)
+    : Communication(comm_name),
 #ifdef LLDB_CONFIGURATION_DEBUG
-    m_packet_timeout (1000),
+      m_packet_timeout(1000),
 #else
-    m_packet_timeout (1),
+      m_packet_timeout(1),
 #endif
       m_echo_number(0),
-    m_supports_qEcho (eLazyBoolCalculate),
-    m_sequence_mutex (Mutex::eMutexTypeRecursive),
-    m_public_is_running (false),
-    m_private_is_running (false),
-    m_history (512),
-    m_send_acks (true),
-    m_compression_type (CompressionType::None),
-    m_listen_url ()
+      m_supports_qEcho(eLazyBoolCalculate),
+      m_sequence_mutex(),
+      m_public_is_running(false),
+      m_private_is_running(false),
+      m_history(512),
+      m_send_acks(true),
+      m_compression_type(CompressionType::None),
+      m_listen_url()
 {
 }
 

 GDBRemoteCommunication::PacketResult
 GDBRemoteCommunication::SendPacket (const char *payload, size_t payload_length)
 {
-    Mutex::Locker locker(m_sequence_mutex);
+    std::lock_guard<std::recursive_mutex> guard(m_sequence_mutex);
     return SendPacketNoLock (payload, payload_length);
 }
 

 }
 
 bool
-GDBRemoteCommunication::GetSequenceMutex (Mutex::Locker& locker, const char *failure_message)
+GDBRemoteCommunication::GetSequenceMutex(std::unique_lock<std::recursive_mutex> &lock)
 {
     if (IsRunning())
-        return locker.TryLock (m_sequence_mutex, failure_message);
+        return (lock = std::unique_lock<std::recursive_mutex>(m_sequence_mutex, std::try_to_lock)).owns_lock();
 
-    locker.Lock (m_sequence_mutex);
+    lock = std::unique_lock<std::recursive_mutex>(m_sequence_mutex);
     return true;
 }
 
-
 bool
-GDBRemoteCommunication::WaitForNotRunningPrivate (const TimeValue *timeout_ptr)
+GDBRemoteCommunication::WaitForNotRunningPrivate(const std::chrono::microseconds &timeout)
 {
-    return m_private_is_running.WaitForValueEqualTo (false, timeout_ptr, NULL);
+    return m_private_is_running.WaitForValueEqualTo(false, timeout, NULL);
 }
 
 GDBRemoteCommunication::PacketResult

 GDBRemoteCommunication::PacketResult
 GDBRemoteCommunication::PopPacketFromQueue (StringExtractorGDBRemote &response, uint32_t timeout_usec)
 {
-    // Calculate absolute timeout value
-    TimeValue timeout = TimeValue::Now();
-    timeout.OffsetWithMicroSeconds(timeout_usec);
+    std::chrono::time_point<std::chrono::system_clock, std::chrono::microseconds> until =
+        std::chrono::system_clock::now() + std::chrono::microseconds(timeout_usec);
 
-    do
+    while (true)
     {
         // scope for the mutex
         {
             // lock down the packet queue
-            Mutex::Locker locker(m_packet_queue_mutex);
+            std::unique_lock<std::mutex> lock(m_packet_queue_mutex);
 
             // Wait on condition variable.
             if (m_packet_queue.size() == 0)
-                m_condition_queue_not_empty.Wait(m_packet_queue_mutex, &timeout);
+            {
+                std::cv_status result = m_condition_queue_not_empty.wait_until(lock, until);
+                if (result == std::cv_status::timeout)
+                    break;
+            }
 
             if (m_packet_queue.size() > 0)
             {

          // Disconnected
          if (!IsConnected())
              return PacketResult::ErrorDisconnected;
-
-      // Loop while not timed out
-    } while (TimeValue::Now() < timeout);
+    }
 
     return PacketResult::ErrorReplyTimeout;
 }

             // scope for the mutex
             {
                 // lock down the packet queue
-                Mutex::Locker locker(m_packet_queue_mutex);
+                std::lock_guard<std::mutex> guard(m_packet_queue_mutex);
                 // push a new packet into the queue
                 m_packet_queue.push(packet);
                 // Signal condition variable that we have a packet
-                m_condition_queue_not_empty.Signal();
-
+                m_condition_queue_not_empty.notify_one();
             }
         }
 

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h

     SendAsyncSignal (int signo);
 
     bool
-    SendInterrupt (Mutex::Locker &locker, 
-                   uint32_t seconds_to_wait_for_stop, 
-                   bool &timed_out);
+    SendInterrupt(std::unique_lock<std::recursive_mutex> &lock, uint32_t seconds_to_wait_for_stop, bool &timed_out);
 
     lldb::pid_t
     GetCurrentProcessID (bool allow_lazy = true);

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

     std::string &response_string
 )
 {
-    Mutex::Locker locker;
-    if (!GetSequenceMutex(locker,
-                          "ProcessGDBRemote::SendPacketsAndConcatenateResponses() failed due to not getting the sequence mutex"))
+    std::unique_lock<std::recursive_mutex> lock;
+    if (!GetSequenceMutex(lock))
     {
         Log *log (ProcessGDBRemoteLog::GetLogIfAnyCategoryIsSet (GDBR_LOG_PROCESS | GDBR_LOG_PACKETS));
         if (log)

 )
 {
     PacketResult packet_result = PacketResult::ErrorSendFailed;
-    Mutex::Locker locker;
+    std::unique_lock<std::recursive_mutex> lock;
     Log *log (ProcessGDBRemoteLog::GetLogIfAllCategoriesSet (GDBR_LOG_PROCESS));
 
     // In order to stop async notifications from being processed in the middle of the

     static ListenerSP hijack_listener_sp(Listener::MakeListener("lldb.NotifyHijacker"));
     HijackBroadcaster(hijack_listener_sp, eBroadcastBitGdbReadThreadGotNotify);
 
-    if (GetSequenceMutex (locker))
+    if (GetSequenceMutex(lock))
     {
         packet_result = SendPacketAndWaitForResponseNoLock (payload, payload_length, response);
     }

                     log->Printf ("async: async packet = %s", m_async_packet.c_str());
 
                 bool timed_out = false;
-                if (SendInterrupt(locker, 2, timed_out))
+                if (SendInterrupt(lock, 2, timed_out))
                 {
                     if (m_interrupt_sent)
                     {
                         m_interrupt_sent = false;
-                        TimeValue timeout_time;
-                        timeout_time = TimeValue::Now();
-                        timeout_time.OffsetWithSeconds (m_packet_timeout);
 
                         if (log) 
                             log->Printf ("async: sent interrupt");
 
-                        if (m_async_packet_predicate.WaitForValueEqualTo (false, &timeout_time, &timed_out))
+                        std::chrono::time_point<std::chrono::system_clock> until =
+                            std::chrono::system_clock::now() + std::chrono::seconds(m_packet_timeout);
+
+                        if (m_async_packet_predicate.WaitForValueEqualTo(
+                                false, until - std::chrono::system_clock::now(), &timed_out))
                         {
                             if (log) 
                                 log->Printf ("async: got response");

                             if (log) 
                                 log->Printf ("async: timed out waiting for response");
                         }
-                        
                         // Make sure we wait until the continue packet has been sent again...
-                        if (m_private_is_running.WaitForValueEqualTo (true, &timeout_time, &timed_out))
+                        if (m_private_is_running.WaitForValueEqualTo(true, until - std::chrono::system_clock::now(),
+                                                                     &timed_out))
                         {
                             if (log)
                             {

         log->Printf("GDBRemoteCommunicationClient::%s ()", __FUNCTION__);
 
     // we want to lock down packet sending while we continue
-    Mutex::Locker locker(m_sequence_mutex);
+    std::lock_guard<std::recursive_mutex> guard(m_sequence_mutex);
 
     // here we broadcast this before we even send the packet!!
     // this signals doContinue() to exit

     if (log)
         log->Printf ("GDBRemoteCommunicationClient::%s ()", __FUNCTION__);
 
-    Mutex::Locker locker(m_sequence_mutex);
+    std::lock_guard<std::recursive_mutex> guard(m_sequence_mutex);
     StateType state = eStateRunning;
 
     m_public_is_running.SetValue (true, eBroadcastNever);

     std::lock_guard<std::recursive_mutex> guard(m_async_mutex);
     m_async_signal = signo;
     bool timed_out = false;
-    Mutex::Locker locker;
-    if (SendInterrupt (locker, 1, timed_out))
+    std::unique_lock<std::recursive_mutex> lock;
+    if (SendInterrupt(lock, 1, timed_out))
         return true;
     m_async_signal = -1;
     return false;

 // (gdb remote protocol requires this), and do what we need to do, then resume.
 
 bool
-GDBRemoteCommunicationClient::SendInterrupt
-(
-    Mutex::Locker& locker, 
-    uint32_t seconds_to_wait_for_stop,             
-    bool &timed_out
-)
+GDBRemoteCommunicationClient::SendInterrupt(std::unique_lock<std::recursive_mutex> &lock,
+                                            uint32_t seconds_to_wait_for_stop, bool &timed_out)
 {
     timed_out = false;
     Log *log (ProcessGDBRemoteLog::GetLogIfAnyCategoryIsSet (GDBR_LOG_PROCESS | GDBR_LOG_PACKETS));

     if (IsRunning())
     {
         // Only send an interrupt if our debugserver is running...
-        if (GetSequenceMutex (locker))
+        if (GetSequenceMutex(lock))
         {
             if (log)
                 log->Printf ("SendInterrupt () - got sequence mutex without having to interrupt");

                 m_interrupt_sent = true;
                 if (seconds_to_wait_for_stop)
                 {
-                    TimeValue timeout;
-                    if (seconds_to_wait_for_stop)
-                    {
-                        timeout = TimeValue::Now();
-                        timeout.OffsetWithSeconds (seconds_to_wait_for_stop);
-                    }
-                    if (m_private_is_running.WaitForValueEqualTo (false, &timeout, &timed_out))
+                    if (m_private_is_running.WaitForValueEqualTo(false, std::chrono::seconds(seconds_to_wait_for_stop),
+                                                                 &timed_out))
                     {
                         if (log)
                             log->PutCString ("SendInterrupt () - sent interrupt, private state stopped");

 GDBRemoteCommunicationClient::GetCurrentThreadIDs (std::vector<lldb::tid_t> &thread_ids, 
                                                    bool &sequence_mutex_unavailable)
 {
-    Mutex::Locker locker;
+    std::unique_lock<std::recursive_mutex> lock;
     thread_ids.clear();
-    
-    if (GetSequenceMutex (locker, "ProcessGDBRemote::UpdateThreadList() failed due to not getting the sequence mutex"))
+    if (GetSequenceMutex(lock))
     {
         sequence_mutex_unavailable = false;
         StringExtractorGDBRemote response;

 bool
 GDBRemoteCommunicationClient::ReadRegister(lldb::tid_t tid, uint32_t reg, StringExtractorGDBRemote &response)
 {
-    Mutex::Locker locker;
-    if (GetSequenceMutex (locker, "Didn't get sequence mutex for p packet."))
+    std::unique_lock<std::recursive_mutex> lock;
+    if (GetSequenceMutex(lock))
     {
         const bool thread_suffix_supported = GetThreadSuffixSupported();
         

 bool
 GDBRemoteCommunicationClient::ReadAllRegisters (lldb::tid_t tid, StringExtractorGDBRemote &response)
 {
-    Mutex::Locker locker;
-    if (GetSequenceMutex (locker, "Didn't get sequence mutex for g packet."))
+    std::unique_lock<std::recursive_mutex> lock;
+    if (GetSequenceMutex(lock))
     {
         const bool thread_suffix_supported = GetThreadSuffixSupported();
 

         return false;
     
     m_supports_QSaveRegisterState = eLazyBoolYes;
-    Mutex::Locker locker;
-    if (GetSequenceMutex (locker, "Didn't get sequence mutex for QSaveRegisterState."))
+    std::unique_lock<std::recursive_mutex> lock;
+    if (GetSequenceMutex(lock))
     {
         const bool thread_suffix_supported = GetThreadSuffixSupported();
         if (thread_suffix_supported || SetCurrentThread(tid))

     // order to be useful
     if (m_supports_QSaveRegisterState == eLazyBoolNo)
         return false;
-    
-    Mutex::Locker locker;
-    if (GetSequenceMutex (locker, "Didn't get sequence mutex for QRestoreRegisterState."))
+    std::unique_lock<std::recursive_mutex> lock;
+    if (GetSequenceMutex(lock))
     {
         const bool thread_suffix_supported = GetThreadSuffixSupported();
         if (thread_suffix_supported || SetCurrentThread(tid))

 
     if (m_supports_qSymbol && m_qSymbol_requests_done == false)
     {
-        Mutex::Locker locker;
-        if (GetSequenceMutex(locker, "GDBRemoteCommunicationClient::ServeSymbolLookups() failed due to not getting the sequence mutex"))
+        std::unique_lock<std::recursive_mutex> lock;
+        if (GetSequenceMutex(lock))
         {
             StreamString packet;
             packet.PutCString ("qSymbol::");

source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp

                                   reg_info->byte_size,          // dst length
                                   m_reg_data.GetByteOrder()))   // dst byte order
     {
-        Mutex::Locker locker;
-        if (gdb_comm.GetSequenceMutex (locker, "Didn't get sequence mutex for write register."))
+        std::unique_lock<std::recursive_mutex> lock;
+        if (gdb_comm.GetSequenceMutex(lock))
         {
             const bool thread_suffix_supported = gdb_comm.GetThreadSuffixSupported();
             ProcessSP process_sp (m_thread.GetProcess());

 
     const bool use_g_packet = gdb_comm.AvoidGPackets ((ProcessGDBRemote *)process) == false;
 
-    Mutex::Locker locker;
-    if (gdb_comm.GetSequenceMutex (locker, "Didn't get sequence mutex for read all registers."))
+    std::unique_lock<std::recursive_mutex> lock;
+    if (gdb_comm.GetSequenceMutex(lock))
     {
         SyncThreadState(process);
         

     const bool use_g_packet = gdb_comm.AvoidGPackets ((ProcessGDBRemote *)process) == false;
 
     StringExtractorGDBRemote response;
-    Mutex::Locker locker;
-    if (gdb_comm.GetSequenceMutex (locker, "Didn't get sequence mutex for write all registers."))
+    std::unique_lock<std::recursive_mutex> lock;
+    if (gdb_comm.GetSequenceMutex(lock))
     {
         const bool thread_suffix_supported = gdb_comm.GetThreadSuffixSupported();
         ProcessSP process_sp (m_thread.GetProcess());

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

         else
         {
             EventSP event_sp;
-            TimeValue timeout;
-            timeout = TimeValue::Now();
-            timeout.OffsetWithSeconds (5);
             if (!m_async_thread.IsJoinable())
             {
                 error.SetErrorString ("Trying to resume but the async thread is dead.");

 
             m_async_broadcaster.BroadcastEvent (eBroadcastBitAsyncContinue, new EventDataBytes (continue_packet.GetData(), continue_packet.GetSize()));
 
-            if (listener_sp->WaitForEvent (&timeout, event_sp) == false)
+            if (listener_sp->WaitForEvent(std::chrono::seconds(5), event_sp) == false)
             {
                 error.SetErrorString("Resume timed out.");
                 if (log)

     Error error;
 
     bool timed_out = false;
-    Mutex::Locker locker;
+    std::unique_lock<std::recursive_mutex> lock;
 
     if (m_public_state.GetValue() == eStateAttaching)
     {

     }
     else
     {
-        if (!m_gdb_comm.SendInterrupt (locker, 2, timed_out))
+        if (!m_gdb_comm.SendInterrupt(lock, 2, timed_out))
         {
             if (timed_out)
                 error.SetErrorString("timed out sending interrupt packet");

     {
         if (log)
             log->Printf ("ProcessGDBRemote::%s (arg = %p, pid = %" PRIu64 ") listener.WaitForEvent (NULL, event_sp)...", __FUNCTION__, arg, process->GetID());
-        if (process->m_async_listener_sp->WaitForEvent (NULL, event_sp))
+        if (process->m_async_listener_sp->WaitForEvent(std::chrono::microseconds(0), event_sp))
         {
             const uint32_t event_type = event_sp->GetType();
             if (event_sp->BroadcasterIs (&process->m_async_broadcaster))

source/Target/Process.cpp

     if (!m_process_input_reader)
         return;
 
-    TimeValue timeout = TimeValue::Now();
-    timeout.OffsetWithMicroSeconds(timeout_msec*1000);
     uint32_t new_iohandler_id = 0;
-    m_iohandler_sync.WaitForValueNotEqualTo(iohandler_id, new_iohandler_id, &timeout);
+    m_iohandler_sync.WaitForValueNotEqualTo(iohandler_id, new_iohandler_id, std::chrono::milliseconds(timeout_msec));
 
     Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_PROCESS));
     if (log)

     while (state != eStateInvalid)
     {
         EventSP event_sp;
-        state = WaitForStateChangedEvents (timeout, event_sp, hijack_listener_sp);
+        state = WaitForStateChangedEvents(std::chrono::milliseconds(0), event_sp, hijack_listener_sp);
         if (event_sp_ptr && event_sp)
             *event_sp_ptr = event_sp;
 

 }
 
 StateType
-Process::WaitForState(const TimeValue *timeout,
-                      const StateType *match_states,
+Process::WaitForState(const std::chrono::microseconds &timeout, const StateType *match_states,
                       const uint32_t num_match_states)
 {
     EventSP event_sp;

 }
 
 StateType
-Process::WaitForStateChangedEvents (const TimeValue *timeout, EventSP &event_sp, ListenerSP hijack_listener_sp)
+Process::WaitForStateChangedEvents(const std::chrono::microseconds &timeout, EventSP &event_sp,
+                                   ListenerSP hijack_listener_sp)
 {
     Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_PROCESS));
 
     if (log)
-        log->Printf ("Process::%s (timeout = %p, event_sp)...", __FUNCTION__,
-                     static_cast<const void*>(timeout));
+        log->Printf("Process::%s (timeout = %llu, event_sp)...", __FUNCTION__, timeout.count());
 
     ListenerSP listener_sp = hijack_listener_sp;
     if (!listener_sp)
         listener_sp = m_listener_sp;
 
     StateType state = eStateInvalid;
-    if (listener_sp->WaitForEventForBroadcasterWithType (timeout,
-                                                         this,
-                                                         eBroadcastBitStateChanged | eBroadcastBitInterrupt,
-                                                         event_sp))
+    if (listener_sp->WaitForEventForBroadcasterWithType(timeout, this,
+                                                        eBroadcastBitStateChanged | eBroadcastBitInterrupt, event_sp))
     {
         if (event_sp && event_sp->GetType() == eBroadcastBitStateChanged)
             state = Process::ProcessEventData::GetStateFromEvent(event_sp.get());

     }
 
     if (log)
-        log->Printf ("Process::%s (timeout = %p, event_sp) => %s",
-                     __FUNCTION__, static_cast<const void*>(timeout),
-                     StateAsCString(state));
+        log->Printf("Process::%s (timeout = %llu, event_sp) => %s", __FUNCTION__, timeout.count(),
+                    StateAsCString(state));
     return state;
 }
 

 }
 
 StateType
-Process::WaitForStateChangedEventsPrivate (const TimeValue *timeout, EventSP &event_sp)
+Process::WaitForStateChangedEventsPrivate(const std::chrono::microseconds &timeout, EventSP &event_sp)
 {
     Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_PROCESS));
 
     if (log)
-        log->Printf ("Process::%s (timeout = %p, event_sp)...", __FUNCTION__,
-                     static_cast<const void*>(timeout));
+        log->Printf("Process::%s (timeout = %llu, event_sp)...", __FUNCTION__, timeout.count());
 
     StateType state = eStateInvalid;
     if (m_private_state_listener_sp->WaitForEventForBroadcasterWithType (timeout,

     // to the command-line, and that could disable the log, which would render the
     // log we got above invalid.
     if (log)
-        log->Printf ("Process::%s (timeout = %p, event_sp) => %s",
-                     __FUNCTION__, static_cast<const void *>(timeout),
-                     state == eStateInvalid ? "TIMEOUT" : StateAsCString(state));
+        log->Printf("Process::%s (timeout = %llu, event_sp) => %s", __FUNCTION__, timeout.count(),
+                    state == eStateInvalid ? "TIMEOUT" : StateAsCString(state));
     return state;
 }
 
 bool
-Process::WaitForEventsPrivate (const TimeValue *timeout, EventSP &event_sp, bool control_only)
+Process::WaitForEventsPrivate(const std::chrono::microseconds &timeout, EventSP &event_sp, bool control_only)
 {
     Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_PROCESS));
 
     if (log)
-        log->Printf ("Process::%s (timeout = %p, event_sp)...", __FUNCTION__,
-                     static_cast<const void*>(timeout));
+        log->Printf("Process::%s (timeout = %llu, event_sp)...", __FUNCTION__, timeout.count());
 
     if (control_only)
         return m_private_state_listener_sp->WaitForEventForBroadcaster(timeout, &m_private_state_control_broadcaster, event_sp);

 }
 
 StateType
-Process::WaitForProcessStopPrivate (const TimeValue *timeout, EventSP &event_sp)
+Process::WaitForProcessStopPrivate(const std::chrono::microseconds &timeout, EventSP &event_sp)
 {
     StateType state;
     // Now wait for the process to launch and return control to us, and then

                 else
                 {
                     EventSP event_sp;
-                    TimeValue timeout_time;
-                    timeout_time = TimeValue::Now();
-                    timeout_time.OffsetWithSeconds(10);
-                    StateType state = WaitForProcessStopPrivate(&timeout_time, event_sp);
+                    StateType state = WaitForProcessStopPrivate(std::chrono::seconds(18), event_sp);
 
                     if (state == eStateInvalid || !event_sp)
                     {

 
         // Wait indefinitely for a stopped event since we just posted one above...
         lldb::EventSP event_sp;
-        listener_sp->WaitForEvent (nullptr, event_sp);
+        listener_sp->WaitForEvent(std::chrono::microseconds(0), event_sp);
         StateType state = ProcessEventData::GetStateFromEvent(event_sp.get());
 
         if (!StateIsStoppedState (state, false))

         if (GetID() != LLDB_INVALID_PROCESS_ID)
         {
             EventSP event_sp;
-            StateType state = WaitForProcessStopPrivate(nullptr, event_sp);
-        
+            StateType state = WaitForProcessStopPrivate(std::chrono::microseconds(0), event_sp);
             if (state == eStateStopped || state == eStateCrashed)
             {
                 // If we attached and actually have a process on the other end, then 

             while (!receipt_received)
             {
                 bool timed_out = false;
-                TimeValue timeout_time;
-                timeout_time = TimeValue::Now();
-                timeout_time.OffsetWithSeconds(2);
                 // Check for a receipt for 2 seconds and then check if the private state
                 // thread is still around.
-                receipt_received = event_receipt_sp->WaitForEventReceived (&timeout_time, &timed_out);
+                receipt_received = event_receipt_sp->WaitForEventReceived(std::chrono::seconds(2), &timed_out);
                 if (!receipt_received)
                 {
                     // Check if the private state thread is still around. If it isn't then we are done waiting

     while (!exit_now)
     {
         EventSP event_sp;
-        WaitForEventsPrivate(nullptr, event_sp, control_only);
+        WaitForEventsPrivate(std::chrono::microseconds(0), event_sp, control_only);
         if (event_sp->BroadcasterIs(&m_private_state_control_broadcaster))
         {
             if (log)

         lldb::EventSP event_sp;
         lldb::StateType stop_state = lldb::eStateInvalid;
 
-        TimeValue* timeout_ptr = nullptr;
-        TimeValue real_timeout;
-
         bool before_first_timeout = true;  // This is set to false the first time that we have to halt the target.
         bool do_resume = true;
         bool handle_running_event = true;

         // The expression evaluation should still succeed.
         bool miss_first_event = true;
 #endif
-        TimeValue one_thread_timeout;
         TimeValue final_timeout;
+        std::chrono::microseconds timeout = std::chrono::microseconds(0);
 
         while (true)
         {

                     }
                 }
 
-                TimeValue resume_timeout = TimeValue::Now();
-                resume_timeout.OffsetWithMicroSeconds(500000);
-
-                got_event = listener_sp->WaitForEvent(&resume_timeout, event_sp);
+                got_event = listener_sp->WaitForEvent(std::chrono::microseconds(500000), event_sp);
                 if (!got_event)
                 {
                     if (log)

             if (before_first_timeout)
             {
                 if (options.GetTryAllThreads())
-                {
-                    one_thread_timeout = TimeValue::Now();
-                    one_thread_timeout.OffsetWithMicroSeconds(one_thread_timeout_usec);
-                    timeout_ptr = &one_thread_timeout;
-                }
+                    timeout = std::chrono::microseconds(one_thread_timeout_usec);
                 else
-                {
-                    if (timeout_usec == 0)
-                        timeout_ptr = nullptr;
-                    else
-                    {
-                        final_timeout = TimeValue::Now();
-                        final_timeout.OffsetWithMicroSeconds (timeout_usec);
-                        timeout_ptr = &final_timeout;
-                    }
-                }
+                    timeout = std::chrono::microseconds(timeout_usec);
             }
             else
             {
                 if (timeout_usec == 0)
-                    timeout_ptr = nullptr;
+                    timeout = std::chrono::microseconds(0);
                 else
-                {
-                    final_timeout = TimeValue::Now();
-                    final_timeout.OffsetWithMicroSeconds (all_threads_timeout_usec);
-                    timeout_ptr = &final_timeout;
-                }
+                    timeout = std::chrono::microseconds(all_threads_timeout_usec);
             }
 
             do_resume = true;

 
             if (log)
             {
-                if (timeout_ptr)
+                if (timeout.count())
                 {
-                    log->Printf ("Process::RunThreadPlan(): about to wait - now is %" PRIu64 " - endpoint is %" PRIu64,
-                                 TimeValue::Now().GetAsMicroSecondsSinceJan1_1970(),
-                                 timeout_ptr->GetAsMicroSecondsSinceJan1_1970());
+                    log->Printf("Process::RunThreadPlan(): about to wait - now is %llu - endpoint is %llu",
+                                std::chrono::time_point<std::chrono::system_clock, std::chrono::microseconds>(
+                                    std::chrono::system_clock::now())
+                                    .time_since_epoch()
+                                    .count(),
+                                std::chrono::time_point<std::chrono::system_clock, std::chrono::microseconds>(timeout)
+                                    .time_since_epoch()
+                                    .count());
                 }
                 else
                 {

             }
             else
 #endif
-            got_event = listener_sp->WaitForEvent (timeout_ptr, event_sp);
+                got_event = listener_sp->WaitForEvent(timeout, event_sp);
 
             if (got_event)
             {

                         if (log)
                             log->PutCString ("Process::RunThreadPlan(): Halt succeeded.");
 
-                        real_timeout = TimeValue::Now();
-                        real_timeout.OffsetWithMicroSeconds(500000);
-
-                        got_event = listener_sp->WaitForEvent(&real_timeout, event_sp);
+                        got_event = listener_sp->WaitForEvent(std::chrono::microseconds(500000), event_sp);
 
                         if (got_event)
                         {