This is an archive of the discontinued LLVM Phabricator instance.

Differential D20313

[Mips] Set mips32 as default CPU for MIPS32 Android
ClosedPublic

Authored by petarj on May 16 2016, 5:03 PM.

Details

Reviewers
atanasyan
Commits
rG009494fe093f: [Mips] Set mips32 as default CPU for MIPS32 Android
rC269754: [Mips] Set mips32 as default CPU for MIPS32 Android
rL269754: [Mips] Set mips32 as default CPU for MIPS32 Android
Summary

Change default CPU for MIPS32 Android. Now it is mips32 (rev1).

Diff Detail

Repository
rL LLVM

Event Timeline

petarj updated this revision to Diff 57423.May 16 2016, 5:03 PM
petarj retitled this revision from to [Mips] Set mips32 as default CPU for MIPS32 Android.
petarj updated this object.
petarj added a reviewer: atanasyan.
petarj added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer. · View Herald TranscriptMay 16 2016, 5:03 PM
atanasyan accepted this revision.May 17 2016, 12:09 AM
atanasyan edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 17 2016, 12:09 AM
Closed by commit rL269754: [Mips] Set mips32 as default CPU for MIPS32 Android (authored by petarj). · Explain WhyMay 17 2016, 3:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
lib/
Driver/
4 lines
test/
Driver/
2 lines

Diff 57454

cfe/trunk/lib/Driver/Tools.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,177 Lines • ▼ Show 20 Linesvoid mips::getMipsCPUAndABI(const ArgList &Args, const llvm::Triple &Triple,
// default for mips64(el)?-img-linux-gnu. // default for mips64(el)?-img-linux-gnu.
if (Triple.getVendor() == llvm::Triple::ImaginationTechnologies && if (Triple.getVendor() == llvm::Triple::ImaginationTechnologies &&
Triple.getEnvironment() == llvm::Triple::GNU) { Triple.getEnvironment() == llvm::Triple::GNU) {
DefMips32CPU = "mips32r6"; DefMips32CPU = "mips32r6";
DefMips64CPU = "mips64r6"; DefMips64CPU = "mips64r6";
} }
// MIPS64r6 is the default for Android MIPS64 (mips64el-linux-android). // MIPS64r6 is the default for Android MIPS64 (mips64el-linux-android).
if (Triple.isAndroid()) if (Triple.isAndroid()) {
DefMips32CPU = "mips32";
DefMips64CPU = "mips64r6"; DefMips64CPU = "mips64r6";
}
// MIPS3 is the default for mips64*-unknown-openbsd. // MIPS3 is the default for mips64*-unknown-openbsd.
if (Triple.getOS() == llvm::Triple::OpenBSD) if (Triple.getOS() == llvm::Triple::OpenBSD)
DefMips64CPU = "mips3"; DefMips64CPU = "mips3";
if (Arg *A = Args.getLastArg(options::OPT_march_EQ, options::OPT_mcpu_EQ)) if (Arg *A = Args.getLastArg(options::OPT_march_EQ, options::OPT_mcpu_EQ))
CPUName = A->getValue(); CPUName = A->getValue();
▲ Show 20 Lines • Show All 9,882 Lines • Show Last 20 Lines

cfe/trunk/test/Driver/clang-translation.c

Show First 20 Lines • Show All 239 Lines • ▼ Show 20 Lines
// MIPSEL: "-cc1" // MIPSEL: "-cc1"
// MIPSEL: "-target-cpu" "mips32r2" // MIPSEL: "-target-cpu" "mips32r2"
// MIPSEL: "-mfloat-abi" "hard" // MIPSEL: "-mfloat-abi" "hard"
// RUN: %clang -target mipsel-linux-android -### -S %s 2>&1 | \ // RUN: %clang -target mipsel-linux-android -### -S %s 2>&1 | \
// RUN: FileCheck -check-prefix=MIPSEL-ANDROID %s // RUN: FileCheck -check-prefix=MIPSEL-ANDROID %s
// MIPSEL-ANDROID: clang // MIPSEL-ANDROID: clang
// MIPSEL-ANDROID: "-cc1" // MIPSEL-ANDROID: "-cc1"
// MIPSEL-ANDROID: "-target-cpu" "mips32r2" // MIPSEL-ANDROID: "-target-cpu" "mips32"
// MIPSEL-ANDROID: "-mfloat-abi" "hard" // MIPSEL-ANDROID: "-mfloat-abi" "hard"
// RUN: %clang -target mips64-linux-gnu -### -S %s 2>&1 | \ // RUN: %clang -target mips64-linux-gnu -### -S %s 2>&1 | \
// RUN: FileCheck -check-prefix=MIPS64 %s // RUN: FileCheck -check-prefix=MIPS64 %s
// MIPS64: clang // MIPS64: clang
// MIPS64: "-cc1" // MIPS64: "-cc1"
// MIPS64: "-target-cpu" "mips64r2" // MIPS64: "-target-cpu" "mips64r2"
// MIPS64: "-mfloat-abi" "hard" // MIPS64: "-mfloat-abi" "hard"
Show All 14 Lines