This is an archive of the discontinued LLVM Phabricator instance.

Add preliminary bits for Plugins/Process/NetBSD
AbandonedPublic

Authored by krytarowski on May 15 2016, 8:04 AM.

Details

Summary

It's still not functional (there are bugs), but it has all or mostly all
of the code needed for amd64.

This code is based on FreeBSD with removed unsupported features, missing
in the current version of NetBSD.

It will be easier to keep development it in sync with HEAD and should be
usable for other teams to take it into account in further changes.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski retitled this revision from to Add preliminary bits for Plugins/Process/NetBSD.
krytarowski updated this object.
krytarowski added reviewers: joerg, emaste, clayborg.
krytarowski set the repository for this revision to rL LLVM.
krytarowski added a subscriber: lldb-commits.

Addressed few nits pointed out by @joerg

clayborg requested changes to this revision.May 16 2016, 10:24 AM
clayborg edited edge metadata.

If you want remote debugging, you should actually implement the lldb-server code and not do a native Process plug-in. What linux and macosx do is even when debugging locally we run through lldb-server (a GDB remote protocol server). This way when you need to remotely debug, it doesn't change anything. I would highly suggest that we go this route. Todd Fiala can help guide you with this. Does remote debugging interest you?

This revision now requires changes to proceed.May 16 2016, 10:25 AM
emaste edited edge metadata.May 16 2016, 1:09 PM

What linux and macosx do is even when debugging locally we run through lldb-server (a GDB remote protocol server).

And this is the way we plan to go on FreeBSD as well and will drop the in-process debugging support when that's ready.

Does remote debugging interest you?

Yes.

However, on the other hand it's low priority for me right now. I will rebase to FreeBSD once I will get improved system support in ptrace(2) and functional process/core instrumentation.

krytarowski abandoned this revision.May 26 2016, 9:34 AM

It no longer builds due to mutex refactoring. Remove as it will need to be redone for remote debugging.