Page MenuHomePhabricator

[clang-rename] Fix broken dependency on shared build.
ClosedPublic

Authored by etienneb on May 13 2016, 8:27 AM.

Details

Summary

The build is broken due to a missing dependency.

To repro: [Release + Shared]

-DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON

Which produce this error:

tools/clang/tools/extra/clang-rename/CMakeFiles/clangRename.dir/USRLocFinder.cpp.o: In function `clang::RecursiveASTVisitor<clang::rename::(anonymous namespace)::USRLocFindingASTVisitor>::TraverseCXXConstructorDecl(clang::CXXConstructorDecl*)':
USRLocFinder.cpp:(.text._ZN5clang19RecursiveASTVisitorINS_6rename12_GLOBAL__N_123USRLocFindingASTVisitorEE26TraverseCXXConstructorDeclEPNS_18CXXConstructorDeclE+0x170): undefined reference to `clang::Lexer::getSourceText(clang::CharSourceRange, clang::SourceManager const&, clang::LangOptions const&, bool*)'

Diff Detail

Event Timeline

etienneb updated this revision to Diff 57195.May 13 2016, 8:27 AM
etienneb retitled this revision from to [clang-rename] Fix broken dependency on shared build..
etienneb updated this object.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
yaron.keren accepted this revision.May 13 2016, 8:31 AM
yaron.keren added a reviewer: yaron.keren.
yaron.keren added a subscriber: yaron.keren.

result of r269402, LGTM

This revision is now accepted and ready to land.May 13 2016, 8:31 AM

thanks, landing as soon as my other checkouts complete their tests (few minutes).

etienneb closed this revision.May 13 2016, 8:44 AM

Thanks for fixing the problem I introduced. :-)

Thanks for fixing the problem I introduced. :-)

No worries, I did the same twice this week.