This is an archive of the discontinued LLVM Phabricator instance.

clang-format: [JS] fix template string width counting.
ClosedPublic

Authored by mprobst on May 12 2016, 8:55 AM.

Details

Summary

Simply looking at the final text greatly simplifies the algorithm and also
fixes a reported issue. This requires duplicating the "actual encoding width"
logic, but that seems cleaner than the column acrobatics before.

Diff Detail

Event Timeline

mprobst updated this revision to Diff 57047.May 12 2016, 8:55 AM
mprobst retitled this revision from to clang-format: [JS] fix template string width counting..
mprobst updated this object.
mprobst added reviewers: djasper, bkramer.
mprobst added a subscriber: cfe-commits.
mprobst updated this revision to Diff 57066.May 12 2016, 10:23 AM
  • simplify logic by parsing forward, reduce complexity to O(n) from O(n^2)
djasper accepted this revision.May 16 2016, 11:11 PM
djasper edited edge metadata.

Nice.

This revision is now accepted and ready to land.May 16 2016, 11:11 PM
This revision was automatically updated to reflect the committed changes.