FYI I think I fixed the actual problem in the follow up,
https://reviews.llvm.org/D118448.

Landed in https://github.com/llvm/llvm-project/commit/c6d5efb5d98093c4bd7578b2ea52c9032d20dea3

• make test break if we used alphasort

Superseded by https://reviews.llvm.org/D118363 (sorry for the diff confusion).

• review comments

added test for merging

• test for avoiding merges

• review comments

PTAL, addressed review comments.

address review comments.

For posterity: there was a question whether this is legal syntax in JSDoc in the first place (e.g. whether it should be escaped). That remains unclear - Closure Compiler parser however does ignore JSDoc tags if the line does not start with an @ tag. So the safe thing is to do what this revision does, avoid wrapping.

• fix comment

See my comment on the upstream bug, let's chat a bit about whether we need this.

• fix formatting

Thanks for the feedback. Indeed, whitelisting the JS keywords is better, but we still needed a way to blacklist all C++ keywords then - Krasimir's suggestion with the #include did the trick, thanks.

• - improve handling of keywors - rather than blacklisting all C++

That has landed a while ago in https://reviews.llvm.org/rGa324fcf1ae6, not sure what's up with the differential revision not closing. Will do manually.

This has landed as https://reviews.llvm.org/rGa324fcf1ae6 (not sure why this hasn't closed automatically).

• - only run comma insertion for JavaScript.
• review fixes
• Fix col limit
• test for comma insertion
• - validate options, reject bin packing + trailing commas

PTAL.

• - only run comma insertion for JavaScript.
• review fixes
• Fix col limit
• test for comma insertion

• Disable arrow functions on single lines by default.

If that's the case, consider adding the option to the style in a follow-up patch:

GoogleStyle.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All;

that would have an advantage of making clear which test case diffs are result of the implementation and which are result of the style flip.

• - only run comma insertion for JavaScript.

This is required by JavaScript style, but this change as is optimistically runs the tool for any language. I think that's probably not what we want here initially, just throwing it out there. WDYT?

FYI I've started a conversation on whether SLS_All should be the default Google style. But the option I think is useful in either case.