Page MenuHomePhabricator

mprobst (Martin Probst)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2015, 5:19 AM (243 w, 1 d)

Recent Activity

Aug 26 2019

mprobst committed rL369916: clang-format: [JS] handle `as const`..
clang-format: [JS] handle `as const`.
Aug 26 2019, 8:47 AM
mprobst committed rG5836472ac488: clang-format: [JS] handle `as const`. (authored by mprobst).
clang-format: [JS] handle `as const`.
Aug 26 2019, 8:39 AM
mprobst closed D66736: clang-format: [JS] handle `as const`..
Aug 26 2019, 8:39 AM · Restricted Project
mprobst created D66736: clang-format: [JS] handle `as const`..
Aug 26 2019, 5:55 AM · Restricted Project

Mar 25 2019

mprobst removed a reviewer for D59684: [clang-format] [PR41187] moves Java import statements to the wrong location if code contains statements that start with the word import: mprobst.
Mar 25 2019, 4:24 AM · Restricted Project, Restricted Project

Mar 19 2019

mprobst committed rG26a484f479d5: [clang-format] [JS] handle private members. (authored by mprobst).
[clang-format] [JS] handle private members.
Mar 19 2019, 5:29 AM
mprobst committed rC356449: [clang-format] [JS] handle private members..
[clang-format] [JS] handle private members.
Mar 19 2019, 5:28 AM
mprobst committed rL356449: [clang-format] [JS] handle private members..
[clang-format] [JS] handle private members.
Mar 19 2019, 5:28 AM
mprobst closed D59292: [clang-format] messes up indentation when using JavaScript private fields and methods.

Landed in r356449, thanks!

Mar 19 2019, 5:28 AM · Restricted Project
mprobst removed reviewers for D59292: [clang-format] messes up indentation when using JavaScript private fields and methods: djasper, klimek, JonasToth, reuk, krasimir, alexfh.
Mar 19 2019, 5:25 AM · Restricted Project
mprobst accepted D59292: [clang-format] messes up indentation when using JavaScript private fields and methods.

Actually I'll fix the nits.

Mar 19 2019, 5:19 AM · Restricted Project
mprobst closed D59527: [clang-format] Don't insert break between JS template string and tag identifier.

Landed as r356447.

Mar 19 2019, 4:28 AM · Restricted Project
mprobst committed rGb274d3d79930: [clang-format] [JS] Don't break between template string and tag (authored by mprobst).
[clang-format] [JS] Don't break between template string and tag
Mar 19 2019, 4:15 AM
mprobst committed rC356447: [clang-format] [JS] Don't break between template string and tag.
[clang-format] [JS] Don't break between template string and tag
Mar 19 2019, 4:14 AM
mprobst committed rL356447: [clang-format] [JS] Don't break between template string and tag.
[clang-format] [JS] Don't break between template string and tag
Mar 19 2019, 4:14 AM
mprobst accepted D59527: [clang-format] Don't insert break between JS template string and tag identifier.

LGTM.

Mar 19 2019, 3:23 AM · Restricted Project

Jan 7 2019

mprobst committed rC350516: clang-format: [JS] support goog.requireType..
clang-format: [JS] support goog.requireType.
Jan 7 2019, 5:18 AM
mprobst committed rL350516: clang-format: [JS] support goog.requireType..
clang-format: [JS] support goog.requireType.
Jan 7 2019, 5:18 AM
mprobst closed D56385: clang-format: [JS] support goog.requireType..
Jan 7 2019, 5:18 AM
mprobst created D56385: clang-format: [JS] support goog.requireType..
Jan 7 2019, 4:08 AM

Nov 20 2018

mprobst accepted D54753: [clang-format] JS: don't treat is: as a type matcher.
Nov 20 2018, 6:13 AM

Sep 26 2018

mprobst committed rC343179: clang-format: [JS] conditional types..
clang-format: [JS] conditional types.
Sep 26 2018, 11:53 PM
mprobst committed rL343179: clang-format: [JS] conditional types..
clang-format: [JS] conditional types.
Sep 26 2018, 11:53 PM
mprobst closed D52536: clang-format: [JS] conditional types..
Sep 26 2018, 11:53 PM
mprobst updated the diff for D52536: clang-format: [JS] conditional types..
  • comment in test
Sep 26 2018, 11:49 PM
mprobst created D52536: clang-format: [JS] conditional types..
Sep 26 2018, 2:02 AM
mprobst committed rL343080: clang-format: [JS] space after parameter naming..
clang-format: [JS] space after parameter naming.
Sep 26 2018, 1:30 AM
mprobst committed rC343080: clang-format: [JS] space after parameter naming..
clang-format: [JS] space after parameter naming.
Sep 26 2018, 1:30 AM
mprobst closed D52535: clang-format: [JS] space after parameter naming..
Sep 26 2018, 1:30 AM
mprobst closed D52535: clang-format: [JS] space after parameter naming..
Sep 26 2018, 1:30 AM
mprobst created D52535: clang-format: [JS] space after parameter naming..
Sep 26 2018, 1:14 AM

Aug 7 2018

mprobst accepted D50378: [clang-format] comment reflow: add last line's penalty when ending broken.
Aug 7 2018, 3:16 AM

Aug 3 2018

mprobst committed rL338890: clang-format: [JS] don't break comments before any '{'.
clang-format: [JS] don't break comments before any '{'
Aug 3 2018, 6:59 AM
mprobst committed rC338890: clang-format: [JS] don't break comments before any '{'.
clang-format: [JS] don't break comments before any '{'
Aug 3 2018, 6:59 AM
mprobst closed D50249: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 6:59 AM
mprobst created D50249: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 6:01 AM
mprobst added a comment to rC338837: clang-format: [JS] don't break comments before any '{'.

Roger: thanks for looking, will fix.

Aug 3 2018, 5:55 AM
mprobst committed rL338837: clang-format: [JS] don't break comments before any '{'.
clang-format: [JS] don't break comments before any '{'
Aug 3 2018, 2:35 AM
mprobst committed rC338837: clang-format: [JS] don't break comments before any '{'.
clang-format: [JS] don't break comments before any '{'
Aug 3 2018, 2:35 AM
mprobst closed D50230: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 2:35 AM
mprobst updated the diff for D50230: clang-format: [JS] don't break comments before any '{'.

Also handle multiple numbered list tokens.

Aug 3 2018, 1:57 AM
mprobst created D50230: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 1:53 AM

Aug 2 2018

mprobst committed rC338706: clang-format: fix a crash in comment wraps..
clang-format: fix a crash in comment wraps.
Aug 2 2018, 4:52 AM
mprobst committed rL338706: clang-format: fix a crash in comment wraps..
clang-format: fix a crash in comment wraps.
Aug 2 2018, 4:52 AM
mprobst closed D50177: clang-format: fix a crash in comment wraps..
Aug 2 2018, 4:52 AM
mprobst created D50177: clang-format: fix a crash in comment wraps..
Aug 2 2018, 4:19 AM

Aug 1 2018

mprobst accepted D50138: [clang-format] Add @private to the list of jsdoc annotations.
Aug 1 2018, 4:34 AM

Jul 27 2018

mprobst added inline comments to D49797: [clang-format] Indent after breaking Javadoc annotated line.
Jul 27 2018, 11:29 PM
mprobst accepted D49797: [clang-format] Indent after breaking Javadoc annotated line.
Jul 27 2018, 7:14 AM
mprobst added inline comments to D49797: [clang-format] Indent after breaking Javadoc annotated line.
Jul 27 2018, 2:11 AM

Jul 26 2018

mprobst added inline comments to D49797: [clang-format] Indent after breaking Javadoc annotated line.
Jul 26 2018, 5:22 AM

Jun 11 2018

mprobst committed rC334415: clang-format: [JS] strict prop init annotation..
clang-format: [JS] strict prop init annotation.
Jun 11 2018, 9:26 AM
mprobst committed rL334415: clang-format: [JS] strict prop init annotation..
clang-format: [JS] strict prop init annotation.
Jun 11 2018, 9:26 AM
mprobst closed D48030: clang-format: [JS] strict prop init annotation..
Jun 11 2018, 9:26 AM
mprobst updated the diff for D48030: clang-format: [JS] strict prop init annotation..

fix typo in test

Jun 11 2018, 8:46 AM
mprobst created D48030: clang-format: [JS] strict prop init annotation..
Jun 11 2018, 8:46 AM

May 22 2018

mprobst committed rL332968: clang-format: [JS] do not wrap before any `is`..
clang-format: [JS] do not wrap before any `is`.
May 22 2018, 3:43 AM
mprobst committed rC332968: clang-format: [JS] do not wrap before any `is`..
clang-format: [JS] do not wrap before any `is`.
May 22 2018, 3:43 AM
mprobst closed D47193: clang-format: [JS] do not wrap before any `is`..
May 22 2018, 3:43 AM
mprobst created D47193: clang-format: [JS] do not wrap before any `is`..
May 22 2018, 3:32 AM

Feb 19 2018

mprobst committed rC325489: clang-format: [JS] fix `of` detection..
clang-format: [JS] fix `of` detection.
Feb 19 2018, 4:34 AM
mprobst committed rL325489: clang-format: [JS] fix `of` detection..
clang-format: [JS] fix `of` detection.
Feb 19 2018, 4:34 AM
mprobst closed D43440: clang-format: [JS] fix `of` detection..
Feb 19 2018, 4:34 AM

Feb 18 2018

mprobst created D43440: clang-format: [JS] fix `of` detection..
Feb 18 2018, 6:49 AM

Jan 26 2018

mprobst committed rC323532: clang-format: [JS] Prevent ASI before [ and (..
clang-format: [JS] Prevent ASI before [ and (.
Jan 26 2018, 7:11 AM
mprobst committed rL323532: clang-format: [JS] Prevent ASI before [ and (..
clang-format: [JS] Prevent ASI before [ and (.
Jan 26 2018, 7:11 AM
mprobst closed D42570: clang-format: [JS] Prevent ASI before [ and (..
Jan 26 2018, 7:11 AM
mprobst created D42570: clang-format: [JS] Prevent ASI before [ and (..
Jan 26 2018, 2:19 AM

Nov 30 2017

mprobst committed rC319415: clang-format: [JS] do not wrap after async/await..
clang-format: [JS] do not wrap after async/await.
Nov 30 2017, 2:25 AM
mprobst committed rL319415: clang-format: [JS] do not wrap after async/await..
clang-format: [JS] do not wrap after async/await.
Nov 30 2017, 2:25 AM
mprobst closed D40642: clang-format: [JS] do not wrap after async/await. by committing rL319415: clang-format: [JS] do not wrap after async/await..
Nov 30 2017, 2:25 AM
mprobst created D40642: clang-format: [JS] do not wrap after async/await..
Nov 30 2017, 2:10 AM

Nov 25 2017

mprobst committed rL318976: clang-format: [JS] do not collapse short classes..
clang-format: [JS] do not collapse short classes.
Nov 25 2017, 1:36 AM
mprobst closed D40430: clang-format: [JS] do not collapse short classes. by committing rL318976: clang-format: [JS] do not collapse short classes..
Nov 25 2017, 1:35 AM
mprobst edited reviewers for D38636: [clang-format] Cannot disable array initializer bin packing, added: djasper; removed: mprobst.
Nov 25 2017, 1:35 AM · Restricted Project, Restricted Project, Restricted Project
mprobst committed rL318975: clang-format: [JS] handle semis in generic types..
clang-format: [JS] handle semis in generic types.
Nov 25 2017, 1:34 AM
mprobst closed D40424: clang-format: [JS] handle semis in generic types. by committing rL318975: clang-format: [JS] handle semis in generic types..
Nov 25 2017, 1:34 AM
mprobst committed rL318974: clang-format: [JS] handle `for` as object label..
clang-format: [JS] handle `for` as object label.
Nov 25 2017, 1:24 AM
mprobst closed D40441: clang-format: [JS] handle `for` as object label. by committing rL318974: clang-format: [JS] handle `for` as object label..
Nov 25 2017, 1:24 AM
mprobst committed rL318973: clang-format: [JS] disable ASI on decorators..
clang-format: [JS] disable ASI on decorators.
Nov 25 2017, 1:20 AM
mprobst closed D40410: clang-format: [JS] disable ASI on decorators. by committing rL318973: clang-format: [JS] disable ASI on decorators..
Nov 25 2017, 1:20 AM

Nov 24 2017

mprobst added inline comments to D40441: clang-format: [JS] handle `for` as object label..
Nov 24 2017, 9:08 AM
mprobst updated the diff for D40441: clang-format: [JS] handle `for` as object label..
  • fix test
Nov 24 2017, 9:08 AM
mprobst committed rL318959: clang-format: [JS] do not break in ArrayType[]..
clang-format: [JS] do not break in ArrayType[].
Nov 24 2017, 9:07 AM
mprobst closed D40436: clang-format: [JS] do not break in ArrayType[]. by committing rL318959: clang-format: [JS] do not break in ArrayType[]..
Nov 24 2017, 9:06 AM
mprobst committed rL318958: clang-format: [JS] do not wrap before yield..
clang-format: [JS] do not wrap before yield.
Nov 24 2017, 9:06 AM
mprobst closed D40431: clang-format: [JS] do not wrap before yield. by committing rL318958: clang-format: [JS] do not wrap before yield..
Nov 24 2017, 9:06 AM
mprobst committed rL318957: clang-format: [JS] space between ! assert and in..
clang-format: [JS] space between ! assert and in.
Nov 24 2017, 9:05 AM
mprobst closed D40433: clang-format: [JS] space between ! assert and in. by committing rL318957: clang-format: [JS] space between ! assert and in..
Nov 24 2017, 9:05 AM
mprobst created D40441: clang-format: [JS] handle `for` as object label..
Nov 24 2017, 6:52 AM
mprobst created D40436: clang-format: [JS] do not break in ArrayType[]..
Nov 24 2017, 6:11 AM
mprobst created D40433: clang-format: [JS] space between ! assert and in..
Nov 24 2017, 5:58 AM
mprobst created D40431: clang-format: [JS] do not wrap before yield..
Nov 24 2017, 5:53 AM
mprobst created D40430: clang-format: [JS] do not collapse short classes..
Nov 24 2017, 5:38 AM
mprobst created D40424: clang-format: [JS] handle semis in generic types..
Nov 24 2017, 4:07 AM
mprobst committed rL318942: clang-format: [JS] handle destructuring `of`..
clang-format: [JS] handle destructuring `of`.
Nov 24 2017, 2:48 AM
mprobst closed D40411: clang-format: [JS] handle destructuring `of`. by committing rL318942: clang-format: [JS] handle destructuring `of`..
Nov 24 2017, 2:48 AM
mprobst created D40411: clang-format: [JS] handle destructuring `of`..
Nov 24 2017, 2:38 AM
mprobst created D40410: clang-format: [JS] disable ASI on decorators..
Nov 24 2017, 2:29 AM

Nov 17 2017

mprobst committed rL318537: clang-format: remove trailing lines in lamdas and arrow functions..
clang-format: remove trailing lines in lamdas and arrow functions.
Nov 17 2017, 10:06 AM