Page MenuHomePhabricator

mprobst (Martin Probst)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2015, 5:19 AM (390 w, 5 d)

Recent Activity

Jan 28 2022

mprobst updated subscribers of rGf750c3d95a0c: Revert "clang-format: [JS] sort import aliases.".

FYI I think I fixed the actual problem in the follow up,
https://reviews.llvm.org/D118448.

Jan 28 2022, 4:02 AM
mprobst committed rGc26729251588: clang-format: [JS] fix uninitialized memory. (authored by mprobst).
clang-format: [JS] fix uninitialized memory.
Jan 28 2022, 3:38 AM
mprobst closed D118448: clang-format: [JS] fix uninitialized memory..
Jan 28 2022, 3:38 AM · Restricted Project
mprobst requested review of D118448: clang-format: [JS] fix uninitialized memory..
Jan 28 2022, 3:18 AM · Restricted Project
mprobst added a reverting change for rGf750c3d95a0c: Revert "clang-format: [JS] sort import aliases.": rG03c59765b3eb: clang-format: [JS] sort import aliases. Users can define aliases for long….
Jan 28 2022, 2:52 AM
mprobst committed rG03c59765b3eb: clang-format: [JS] sort import aliases. Users can define aliases for long… (authored by mprobst).
clang-format: [JS] sort import aliases. Users can define aliases for long…
Jan 28 2022, 2:52 AM
mprobst closed D118446: clang-format: [JS] sort import aliases. Users can define aliases for long symbols using import aliases:.
Jan 28 2022, 2:51 AM · Restricted Project
mprobst added a reverting change for rGf750c3d95a0c: Revert "clang-format: [JS] sort import aliases.": D118446: clang-format: [JS] sort import aliases. Users can define aliases for long symbols using import aliases:.
Jan 28 2022, 2:15 AM
mprobst requested review of D118446: clang-format: [JS] sort import aliases. Users can define aliases for long symbols using import aliases:.
Jan 28 2022, 2:15 AM · Restricted Project

Jan 27 2022

mprobst closed D118363: clang-format: [JS] sort import aliases..

Landed in https://github.com/llvm/llvm-project/commit/c6d5efb5d98093c4bd7578b2ea52c9032d20dea3

Jan 27 2022, 7:28 AM · Restricted Project, Restricted Project
mprobst committed rGc6d5efb5d980: clang-format: [JS] sort import aliases. (authored by mprobst).
clang-format: [JS] sort import aliases.
Jan 27 2022, 7:17 AM
mprobst updated the diff for D118361: clang-format: [JS] sort import aliases..
  • make test break if we used alphasort
Jan 27 2022, 7:14 AM · Restricted Project, Restricted Project, Restricted Project
mprobst abandoned D118361: clang-format: [JS] sort import aliases..

Superseded by https://reviews.llvm.org/D118363 (sorry for the diff confusion).

Jan 27 2022, 6:40 AM · Restricted Project, Restricted Project, Restricted Project
mprobst requested review of D118363: clang-format: [JS] sort import aliases..
Jan 27 2022, 6:38 AM · Restricted Project, Restricted Project
mprobst requested review of D118361: clang-format: [JS] sort import aliases..
Jan 27 2022, 6:35 AM · Restricted Project, Restricted Project, Restricted Project

Jan 14 2022

mprobst added inline comments to D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types.
Jan 14 2022, 8:42 AM · Restricted Project, Restricted Project
mprobst added inline comments to D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types.
Jan 14 2022, 1:21 AM · Restricted Project, Restricted Project

Jan 13 2022

mprobst added inline comments to D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types.
Jan 13 2022, 2:28 AM · Restricted Project, Restricted Project
mprobst added inline comments to D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types.
Jan 13 2022, 1:29 AM · Restricted Project, Restricted Project
mprobst added inline comments to D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types.
Jan 13 2022, 12:59 AM · Restricted Project, Restricted Project

Jan 5 2022

mprobst added inline comments to D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0.
Jan 5 2022, 7:57 AM · Restricted Project, Restricted Project, Restricted Project
mprobst added inline comments to D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0.
Jan 5 2022, 4:18 AM · Restricted Project, Restricted Project, Restricted Project

Dec 6 2021

mprobst committed rG327d966365d7: clang-format: [JS] test case for numeric separators. (authored by mprobst).
clang-format: [JS] test case for numeric separators.
Dec 6 2021, 10:02 AM
mprobst closed D115147: clang-format: [JS] test case for numeric separators..
Dec 6 2021, 10:01 AM · Restricted Project, Restricted Project
mprobst requested review of D115147: clang-format: [JS] test case for numeric separators..
Dec 6 2021, 5:18 AM · Restricted Project, Restricted Project

Jul 1 2021

mprobst accepted D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript.
Jul 1 2021, 4:36 AM · Restricted Project, Restricted Project

Jun 29 2021

mprobst added inline comments to D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript.
Jun 29 2021, 11:27 AM · Restricted Project, Restricted Project

Jun 11 2021

mprobst committed rG63042d46bb0c: clang-format: [JS] don't sort named imports if off. (authored by mprobst).
clang-format: [JS] don't sort named imports if off.
Jun 11 2021, 3:03 AM
mprobst closed D104101: clang-format: [JS] don't sort named imports if off..
Jun 11 2021, 3:03 AM · Restricted Project
mprobst requested review of D104101: clang-format: [JS] don't sort named imports if off..
Jun 11 2021, 2:45 AM · Restricted Project

Apr 30 2021

mprobst committed rGb2780cd744ea: clang-format: [JS] handle "off" in imports (authored by mprobst).
clang-format: [JS] handle "off" in imports
Apr 30 2021, 5:19 AM
mprobst closed D101515: clang-format: [JS] handle "off" in imports.
Apr 30 2021, 5:19 AM · Restricted Project
mprobst updated the diff for D101515: clang-format: [JS] handle "off" in imports.
  • review comments
Apr 30 2021, 5:16 AM · Restricted Project
mprobst added a comment to D101515: clang-format: [JS] handle "off" in imports.

added test for merging

Apr 30 2021, 2:34 AM · Restricted Project
mprobst updated the diff for D101515: clang-format: [JS] handle "off" in imports.
  • test for avoiding merges
Apr 30 2021, 2:33 AM · Restricted Project
mprobst updated the diff for D101515: clang-format: [JS] handle "off" in imports.
  • review comments
Apr 30 2021, 2:33 AM · Restricted Project
mprobst added a comment to D101515: clang-format: [JS] handle "off" in imports.

PTAL, addressed review comments.

Apr 30 2021, 2:32 AM · Restricted Project

Apr 29 2021

mprobst requested review of D101515: clang-format: [JS] handle "off" in imports.
Apr 29 2021, 2:38 AM · Restricted Project

Apr 22 2021

mprobst committed rGfbc6f42dbee5: clang-format: [JS] do not merge side-effect imports. (authored by mprobst).
clang-format: [JS] do not merge side-effect imports.
Apr 22 2021, 1:37 AM
mprobst closed D101020: clang-format: [JS] do not merge side-effect imports..
Apr 22 2021, 1:37 AM · Restricted Project

Apr 21 2021

mprobst requested review of D101020: clang-format: [JS] do not merge side-effect imports..
Apr 21 2021, 10:54 PM · Restricted Project
mprobst committed rG70ae843d9980: clang-format: [JS] do not wrap after `asserts` (authored by mprobst).
clang-format: [JS] do not wrap after `asserts`
Apr 21 2021, 7:34 AM
mprobst closed D100953: clang-format: [JS] do not wrap after `asserts`.
Apr 21 2021, 7:34 AM · Restricted Project
mprobst requested review of D100953: clang-format: [JS] do not wrap after `asserts`.
Apr 21 2021, 6:45 AM · Restricted Project

Apr 20 2021

mprobst committed rG3d4a6037ff46: clang-format: [JS] do not merge imports and exports. (authored by mprobst).
clang-format: [JS] do not merge imports and exports.
Apr 20 2021, 4:08 AM
mprobst closed D100752: clang-format: [JS] do not merge imports and exports..
Apr 20 2021, 4:08 AM · Restricted Project

Apr 19 2021

mprobst requested review of D100752: clang-format: [JS] do not merge imports and exports..
Apr 19 2021, 4:33 AM · Restricted Project

Apr 14 2021

mprobst committed rG2fe4909748b5: clang-format: fix undefined behavior. (authored by mprobst).
clang-format: fix undefined behavior.
Apr 14 2021, 11:11 AM
mprobst committed rG4d195f1b4dd6: review comments (authored by mprobst).
review comments
Apr 14 2021, 8:21 AM
mprobst committed rGd45df0d29f70: clang-format: [JS] merge import lines. (authored by mprobst).
clang-format: [JS] merge import lines.
Apr 14 2021, 8:20 AM
mprobst closed D100466: clang-format: [JS] merge import lines..
Apr 14 2021, 8:20 AM · Restricted Project
mprobst added inline comments to D100466: clang-format: [JS] merge import lines..
Apr 14 2021, 8:06 AM · Restricted Project
mprobst updated the diff for D100466: clang-format: [JS] merge import lines..

address review comments.

Apr 14 2021, 8:04 AM · Restricted Project
mprobst requested review of D100466: clang-format: [JS] merge import lines..
Apr 14 2021, 4:44 AM · Restricted Project

Mar 30 2021

mprobst committed rG2b30bd2be0a8: clang-format: [JS] do not collapse - - to --. (authored by mprobst).
clang-format: [JS] do not collapse - - to --.
Mar 30 2021, 5:32 AM
mprobst closed D99495: clang-format: [JS] do not collapse - - to --..
Mar 30 2021, 5:32 AM · Restricted Project

Mar 29 2021

mprobst requested review of D99495: clang-format: [JS] do not collapse - - to --..
Mar 29 2021, 4:16 AM · Restricted Project

Nov 10 2020

mprobst added a comment to D91078: [clang-format] do not break before @tags in JS comments.

For posterity: there was a question whether this is legal syntax in JSDoc in the first place (e.g. whether it should be escaped). That remains unclear - Closure Compiler parser however does ignore JSDoc tags if the line does not start with an @ tag. So the safe thing is to do what this revision does, avoid wrapping.

Nov 10 2020, 12:29 AM · Restricted Project, Restricted Project
mprobst accepted D91078: [clang-format] do not break before @tags in JS comments.
Nov 10 2020, 12:28 AM · Restricted Project, Restricted Project
mprobst committed rG16212b8b3e4f: clang-format: [JS] support new assignment operators. (authored by mprobst).
clang-format: [JS] support new assignment operators.
Nov 10 2020, 12:27 AM
mprobst closed D91132: clang-format: [JS] support new assignment operators..
Nov 10 2020, 12:27 AM · Restricted Project
mprobst updated the diff for D91132: clang-format: [JS] support new assignment operators..
  • fix comment
Nov 10 2020, 12:22 AM · Restricted Project
mprobst requested review of D91132: clang-format: [JS] support new assignment operators..
Nov 10 2020, 12:18 AM · Restricted Project

Nov 9 2020

mprobst added a comment to D91078: [clang-format] do not break before @tags in JS comments.

See my comment on the upstream bug, let's chat a bit about whether we need this.

Nov 9 2020, 7:51 AM · Restricted Project, Restricted Project

Nov 6 2020

mprobst accepted D90908: [clang-format] do not break before { in JS comments.
Nov 6 2020, 1:00 AM · Restricted Project, Restricted Project

Apr 6 2020

mprobst committed rG92201505cdec: clang-format: [JS] handle pseudo-keywords. (authored by mprobst).
clang-format: [JS] handle pseudo-keywords.
Apr 6 2020, 8:39 AM
mprobst closed D77548: clang-format: [JS] handle pseudo-keywords..
Apr 6 2020, 8:39 AM · Restricted Project
mprobst created D77548: clang-format: [JS] handle pseudo-keywords..
Apr 6 2020, 7:00 AM · Restricted Project

Apr 3 2020

mprobst committed rG146d685cd657: clang-format: [JS] detect C++ keywords. (authored by mprobst).
clang-format: [JS] detect C++ keywords.
Apr 3 2020, 5:53 AM
mprobst closed D77311: clang-format: [JS] detect C++ keywords..
Apr 3 2020, 5:52 AM · Restricted Project, Restricted Project
mprobst added inline comments to D77311: clang-format: [JS] detect C++ keywords..
Apr 3 2020, 5:20 AM · Restricted Project, Restricted Project
mprobst updated the diff for D77311: clang-format: [JS] detect C++ keywords..
  • fix formatting
Apr 3 2020, 3:43 AM · Restricted Project, Restricted Project
mprobst added a comment to D77311: clang-format: [JS] detect C++ keywords..

Thanks for the feedback. Indeed, whitelisting the JS keywords is better, but we still needed a way to blacklist all C++ keywords then - Krasimir's suggestion with the #include did the trick, thanks.

Apr 3 2020, 3:43 AM · Restricted Project, Restricted Project
mprobst updated the diff for D77311: clang-format: [JS] detect C++ keywords..
  • - improve handling of keywors - rather than blacklisting all C++
Apr 3 2020, 3:43 AM · Restricted Project, Restricted Project

Apr 2 2020

mprobst created D77311: clang-format: [JS] detect C++ keywords..
Apr 2 2020, 8:06 AM · Restricted Project, Restricted Project

Feb 3 2020

mprobst added a comment to rGdc04c54fc1f6: clang-format: [JS] document InsertTrailingCommas..

That has landed a while ago in https://reviews.llvm.org/rGa324fcf1ae6, not sure what's up with the differential revision not closing. Will do manually.

Feb 3 2020, 1:05 AM
mprobst closed D73354: clang-format: insert trailing commas into containers..

This has landed as https://reviews.llvm.org/rGa324fcf1ae6 (not sure why this hasn't closed automatically).

Feb 3 2020, 1:05 AM · Restricted Project, Restricted Project

Feb 2 2020

mprobst committed rGdc04c54fc1f6: clang-format: [JS] document InsertTrailingCommas. (authored by mprobst).
clang-format: [JS] document InsertTrailingCommas.
Feb 2 2020, 11:52 PM
mprobst closed D73768: clang-format: [JS] document InsertTrailingCommas..
Feb 2 2020, 11:52 PM · Restricted Project

Jan 31 2020

mprobst created D73768: clang-format: [JS] document InsertTrailingCommas..
Jan 31 2020, 1:27 AM · Restricted Project

Jan 29 2020

mprobst committed rGa324fcf1ae62: clang-format: insert trailing commas into containers. (authored by mprobst).
clang-format: insert trailing commas into containers.
Jan 29 2020, 4:28 AM
mprobst added inline comments to D73354: clang-format: insert trailing commas into containers..
Jan 29 2020, 4:28 AM · Restricted Project, Restricted Project
mprobst added inline comments to D73354: clang-format: insert trailing commas into containers..
Jan 29 2020, 3:49 AM · Restricted Project, Restricted Project

Jan 28 2020

mprobst updated the diff for D73354: clang-format: insert trailing commas into containers..
  • - only run comma insertion for JavaScript.
  • review fixes
  • Fix col limit
  • test for comma insertion
  • - validate options, reject bin packing + trailing commas
Jan 28 2020, 7:17 AM · Restricted Project, Restricted Project
mprobst added a comment to D73354: clang-format: insert trailing commas into containers..

PTAL.

Jan 28 2020, 7:17 AM · Restricted Project, Restricted Project
mprobst added inline comments to D73335: clang-format: [JS] options for arrow functions..
Jan 28 2020, 6:05 AM · Restricted Project, Restricted Project
mprobst added inline comments to D73354: clang-format: insert trailing commas into containers..
Jan 28 2020, 6:04 AM · Restricted Project, Restricted Project
mprobst updated the diff for D73354: clang-format: insert trailing commas into containers..
  • - only run comma insertion for JavaScript.
  • review fixes
  • Fix col limit
  • test for comma insertion
Jan 28 2020, 5:54 AM · Restricted Project, Restricted Project

Jan 27 2020

mprobst committed rG02656f29abda: clang-format: [JS] options for arrow functions. (authored by mprobst).
clang-format: [JS] options for arrow functions.
Jan 27 2020, 7:28 AM
mprobst closed D73335: clang-format: [JS] options for arrow functions..
Jan 27 2020, 7:28 AM · Restricted Project, Restricted Project

Jan 24 2020

mprobst updated the diff for D73335: clang-format: [JS] options for arrow functions..
  • Disable arrow functions on single lines by default.
Jan 24 2020, 7:55 AM · Restricted Project, Restricted Project
mprobst added a comment to D73335: clang-format: [JS] options for arrow functions..

If that's the case, consider adding the option to the style in a follow-up patch:

GoogleStyle.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All;

that would have an advantage of making clear which test case diffs are result of the implementation and which are result of the style flip.

Jan 24 2020, 7:55 AM · Restricted Project, Restricted Project
mprobst updated the diff for D73354: clang-format: insert trailing commas into containers..
  • - only run comma insertion for JavaScript.
Jan 24 2020, 7:35 AM · Restricted Project, Restricted Project
mprobst added a comment to D73354: clang-format: insert trailing commas into containers..

This is required by JavaScript style, but this change as is optimistically runs the tool for any language. I think that's probably not what we want here initially, just throwing it out there. WDYT?

Jan 24 2020, 7:27 AM · Restricted Project, Restricted Project
mprobst created D73354: clang-format: insert trailing commas into containers..
Jan 24 2020, 7:26 AM · Restricted Project, Restricted Project
mprobst added a comment to D73335: clang-format: [JS] options for arrow functions..

FYI I've started a conversation on whether SLS_All should be the default Google style. But the option I think is useful in either case.

Jan 24 2020, 2:46 AM · Restricted Project, Restricted Project
mprobst created D73335: clang-format: [JS] options for arrow functions..
Jan 24 2020, 2:35 AM · Restricted Project, Restricted Project

Jan 20 2020

mprobst committed rG4c9d6914453d: clang-format: [JS] fix `??` opreator wrapping. (authored by mprobst).
clang-format: [JS] fix `??` opreator wrapping.
Jan 20 2020, 8:08 AM
mprobst closed D73026: clang-format: [JS] fix `??` opreator wrapping..
Jan 20 2020, 8:08 AM · Restricted Project, Restricted Project
mprobst created D73026: clang-format: [JS] fix `??` opreator wrapping..
Jan 20 2020, 3:30 AM · Restricted Project, Restricted Project