Page MenuHomePhabricator

mprobst (Martin Probst)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2015, 5:19 AM (285 w, 3 d)

Recent Activity

Apr 6 2020

mprobst committed rG92201505cdec: clang-format: [JS] handle pseudo-keywords. (authored by mprobst).
clang-format: [JS] handle pseudo-keywords.
Apr 6 2020, 8:39 AM
mprobst closed D77548: clang-format: [JS] handle pseudo-keywords..
Apr 6 2020, 8:39 AM · Restricted Project
mprobst created D77548: clang-format: [JS] handle pseudo-keywords..
Apr 6 2020, 7:00 AM · Restricted Project

Apr 3 2020

mprobst committed rG146d685cd657: clang-format: [JS] detect C++ keywords. (authored by mprobst).
clang-format: [JS] detect C++ keywords.
Apr 3 2020, 5:53 AM
mprobst closed D77311: clang-format: [JS] detect C++ keywords..
Apr 3 2020, 5:52 AM · Restricted Project, Restricted Project
mprobst added inline comments to D77311: clang-format: [JS] detect C++ keywords..
Apr 3 2020, 5:20 AM · Restricted Project, Restricted Project
mprobst updated the diff for D77311: clang-format: [JS] detect C++ keywords..
  • fix formatting
Apr 3 2020, 3:43 AM · Restricted Project, Restricted Project
mprobst added a comment to D77311: clang-format: [JS] detect C++ keywords..

Thanks for the feedback. Indeed, whitelisting the JS keywords is better, but we still needed a way to blacklist all C++ keywords then - Krasimir's suggestion with the #include did the trick, thanks.

Apr 3 2020, 3:43 AM · Restricted Project, Restricted Project
mprobst updated the diff for D77311: clang-format: [JS] detect C++ keywords..
  • - improve handling of keywors - rather than blacklisting all C++
Apr 3 2020, 3:43 AM · Restricted Project, Restricted Project

Apr 2 2020

mprobst created D77311: clang-format: [JS] detect C++ keywords..
Apr 2 2020, 8:06 AM · Restricted Project, Restricted Project

Feb 3 2020

mprobst added a comment to rGdc04c54fc1f6: clang-format: [JS] document InsertTrailingCommas..

That has landed a while ago in https://reviews.llvm.org/rGa324fcf1ae6, not sure what's up with the differential revision not closing. Will do manually.

Feb 3 2020, 1:05 AM
mprobst closed D73354: clang-format: insert trailing commas into containers..

This has landed as https://reviews.llvm.org/rGa324fcf1ae6 (not sure why this hasn't closed automatically).

Feb 3 2020, 1:05 AM · Restricted Project, Restricted Project

Feb 2 2020

mprobst committed rGdc04c54fc1f6: clang-format: [JS] document InsertTrailingCommas. (authored by mprobst).
clang-format: [JS] document InsertTrailingCommas.
Feb 2 2020, 11:52 PM
mprobst closed D73768: clang-format: [JS] document InsertTrailingCommas..
Feb 2 2020, 11:52 PM · Restricted Project

Jan 31 2020

mprobst created D73768: clang-format: [JS] document InsertTrailingCommas..
Jan 31 2020, 1:27 AM · Restricted Project

Jan 29 2020

mprobst committed rGa324fcf1ae62: clang-format: insert trailing commas into containers. (authored by mprobst).
clang-format: insert trailing commas into containers.
Jan 29 2020, 4:28 AM
mprobst added inline comments to D73354: clang-format: insert trailing commas into containers..
Jan 29 2020, 4:28 AM · Restricted Project, Restricted Project
mprobst added inline comments to D73354: clang-format: insert trailing commas into containers..
Jan 29 2020, 3:49 AM · Restricted Project, Restricted Project

Jan 28 2020

mprobst updated the diff for D73354: clang-format: insert trailing commas into containers..
  • - only run comma insertion for JavaScript.
  • review fixes
  • Fix col limit
  • test for comma insertion
  • - validate options, reject bin packing + trailing commas
Jan 28 2020, 7:17 AM · Restricted Project, Restricted Project
mprobst added a comment to D73354: clang-format: insert trailing commas into containers..

PTAL.

Jan 28 2020, 7:17 AM · Restricted Project, Restricted Project
mprobst added inline comments to D73335: clang-format: [JS] options for arrow functions..
Jan 28 2020, 6:05 AM · Restricted Project, Restricted Project
mprobst added inline comments to D73354: clang-format: insert trailing commas into containers..
Jan 28 2020, 6:04 AM · Restricted Project, Restricted Project
mprobst updated the diff for D73354: clang-format: insert trailing commas into containers..
  • - only run comma insertion for JavaScript.
  • review fixes
  • Fix col limit
  • test for comma insertion
Jan 28 2020, 5:54 AM · Restricted Project, Restricted Project

Jan 27 2020

mprobst committed rG02656f29abda: clang-format: [JS] options for arrow functions. (authored by mprobst).
clang-format: [JS] options for arrow functions.
Jan 27 2020, 7:28 AM
mprobst closed D73335: clang-format: [JS] options for arrow functions..
Jan 27 2020, 7:28 AM · Restricted Project, Restricted Project

Jan 24 2020

mprobst updated the diff for D73335: clang-format: [JS] options for arrow functions..
  • Disable arrow functions on single lines by default.
Jan 24 2020, 7:55 AM · Restricted Project, Restricted Project
mprobst added a comment to D73335: clang-format: [JS] options for arrow functions..

If that's the case, consider adding the option to the style in a follow-up patch:

GoogleStyle.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All;

that would have an advantage of making clear which test case diffs are result of the implementation and which are result of the style flip.

Jan 24 2020, 7:55 AM · Restricted Project, Restricted Project
mprobst updated the diff for D73354: clang-format: insert trailing commas into containers..
  • - only run comma insertion for JavaScript.
Jan 24 2020, 7:35 AM · Restricted Project, Restricted Project
mprobst added a comment to D73354: clang-format: insert trailing commas into containers..

This is required by JavaScript style, but this change as is optimistically runs the tool for any language. I think that's probably not what we want here initially, just throwing it out there. WDYT?

Jan 24 2020, 7:27 AM · Restricted Project, Restricted Project
mprobst created D73354: clang-format: insert trailing commas into containers..
Jan 24 2020, 7:26 AM · Restricted Project, Restricted Project
mprobst added a comment to D73335: clang-format: [JS] options for arrow functions..

FYI I've started a conversation on whether SLS_All should be the default Google style. But the option I think is useful in either case.

Jan 24 2020, 2:46 AM · Restricted Project, Restricted Project
mprobst created D73335: clang-format: [JS] options for arrow functions..
Jan 24 2020, 2:35 AM · Restricted Project, Restricted Project

Jan 20 2020

mprobst committed rG4c9d6914453d: clang-format: [JS] fix `??` opreator wrapping. (authored by mprobst).
clang-format: [JS] fix `??` opreator wrapping.
Jan 20 2020, 8:08 AM
mprobst closed D73026: clang-format: [JS] fix `??` opreator wrapping..
Jan 20 2020, 8:08 AM · Restricted Project, Restricted Project
mprobst created D73026: clang-format: [JS] fix `??` opreator wrapping..
Jan 20 2020, 3:30 AM · Restricted Project, Restricted Project

Jan 17 2020

mprobst committed rG9835cf159014: clang-format: [JS] pragmas for tslint, tsc. (authored by mprobst).
clang-format: [JS] pragmas for tslint, tsc.
Jan 17 2020, 4:44 AM
mprobst closed D72907: clang-format: [JS] pragmas for tslint, tsc..
Jan 17 2020, 4:44 AM · Restricted Project
mprobst accepted D72911: clang-format: fix spacing in `operator const char*()`.
Jan 17 2020, 4:01 AM · Restricted Project
mprobst created D72907: clang-format: [JS] pragmas for tslint, tsc..
Jan 17 2020, 1:48 AM · Restricted Project
mprobst committed rG0734fb21ed5e: clang-format: [JS] Handle more keyword-named methods. (authored by mprobst).
clang-format: [JS] Handle more keyword-named methods.
Jan 17 2020, 1:19 AM
mprobst closed D72827: clang-format: [JS] Handle keyword-named methods..
Jan 17 2020, 1:19 AM · Restricted Project, Restricted Project
mprobst added a comment to D72827: clang-format: [JS] Handle keyword-named methods..

I've added tests and a fix for try/catch and if/else.

Jan 17 2020, 1:09 AM · Restricted Project, Restricted Project
mprobst added a comment to D72827: clang-format: [JS] Handle keyword-named methods..

How about if and try? Is there a list somewhere for all such valid identifiers?

Jan 17 2020, 1:09 AM · Restricted Project, Restricted Project

Jan 16 2020

mprobst created D72827: clang-format: [JS] Handle keyword-named methods..
Jan 16 2020, 2:54 AM · Restricted Project, Restricted Project
mprobst committed rG736a3802124b: clang-format: [JS] tests for async wrapping. (authored by mprobst).
clang-format: [JS] tests for async wrapping.
Jan 16 2020, 2:27 AM
mprobst closed D70377: clang-format: [JS] tests for async wrapping..
Jan 16 2020, 2:26 AM · Restricted Project

Nov 18 2019

mprobst created D70377: clang-format: [JS] tests for async wrapping..
Nov 18 2019, 1:12 AM · Restricted Project

Nov 11 2019

mprobst committed rG6bcd8d4a18fc: clang-format: [JS] test declared fields. (authored by mprobst).
clang-format: [JS] test declared fields.
Nov 11 2019, 7:36 AM
mprobst committed rGa7638d384983: clang-format: [JS] support null operators. (authored by mprobst).
clang-format: [JS] support null operators.
Nov 11 2019, 7:36 AM
mprobst closed D69972: clang-format: [JS] test declared fields..
Nov 11 2019, 7:36 AM · Restricted Project, Restricted Project
mprobst closed D69971: clang-format: [JS] support null operators..
Nov 11 2019, 7:36 AM · Restricted Project, Restricted Project

Nov 8 2019

mprobst updated the diff for D69971: clang-format: [JS] support null operators..

Add tests for .?(foo) and .?[foo].

Nov 8 2019, 10:35 AM · Restricted Project, Restricted Project

Nov 7 2019

mprobst created D69972: clang-format: [JS] test declared fields..
Nov 7 2019, 2:54 PM · Restricted Project, Restricted Project
mprobst created D69971: clang-format: [JS] support null operators..
Nov 7 2019, 2:54 PM · Restricted Project, Restricted Project

Aug 26 2019

mprobst committed rL369916: clang-format: [JS] handle `as const`..
clang-format: [JS] handle `as const`.
Aug 26 2019, 8:47 AM
mprobst committed rG5836472ac488: clang-format: [JS] handle `as const`. (authored by mprobst).
clang-format: [JS] handle `as const`.
Aug 26 2019, 8:39 AM
mprobst closed D66736: clang-format: [JS] handle `as const`..
Aug 26 2019, 8:39 AM · Restricted Project
mprobst created D66736: clang-format: [JS] handle `as const`..
Aug 26 2019, 5:55 AM · Restricted Project

Mar 25 2019

mprobst removed a reviewer for D59684: [clang-format] [PR41187] moves Java import statements to the wrong location if code contains statements that start with the word import: mprobst.
Mar 25 2019, 4:24 AM · Restricted Project, Restricted Project

Mar 19 2019

mprobst committed rG26a484f479d5: [clang-format] [JS] handle private members. (authored by mprobst).
[clang-format] [JS] handle private members.
Mar 19 2019, 5:29 AM
mprobst committed rC356449: [clang-format] [JS] handle private members..
[clang-format] [JS] handle private members.
Mar 19 2019, 5:28 AM
mprobst committed rL356449: [clang-format] [JS] handle private members..
[clang-format] [JS] handle private members.
Mar 19 2019, 5:28 AM
mprobst closed D59292: [clang-format] messes up indentation when using JavaScript private fields and methods.

Landed in r356449, thanks!

Mar 19 2019, 5:28 AM · Restricted Project
mprobst removed reviewers for D59292: [clang-format] messes up indentation when using JavaScript private fields and methods: djasper, klimek, JonasToth, reuk, krasimir, alexfh.
Mar 19 2019, 5:25 AM · Restricted Project
mprobst accepted D59292: [clang-format] messes up indentation when using JavaScript private fields and methods.

Actually I'll fix the nits.

Mar 19 2019, 5:19 AM · Restricted Project
mprobst closed D59527: [clang-format] Don't insert break between JS template string and tag identifier.

Landed as r356447.

Mar 19 2019, 4:28 AM · Restricted Project
mprobst committed rGb274d3d79930: [clang-format] [JS] Don't break between template string and tag (authored by mprobst).
[clang-format] [JS] Don't break between template string and tag
Mar 19 2019, 4:15 AM
mprobst committed rC356447: [clang-format] [JS] Don't break between template string and tag.
[clang-format] [JS] Don't break between template string and tag
Mar 19 2019, 4:14 AM
mprobst committed rL356447: [clang-format] [JS] Don't break between template string and tag.
[clang-format] [JS] Don't break between template string and tag
Mar 19 2019, 4:14 AM
mprobst accepted D59527: [clang-format] Don't insert break between JS template string and tag identifier.

LGTM.

Mar 19 2019, 3:23 AM · Restricted Project

Jan 7 2019

mprobst committed rC350516: clang-format: [JS] support goog.requireType..
clang-format: [JS] support goog.requireType.
Jan 7 2019, 5:18 AM
mprobst committed rL350516: clang-format: [JS] support goog.requireType..
clang-format: [JS] support goog.requireType.
Jan 7 2019, 5:18 AM
mprobst closed D56385: clang-format: [JS] support goog.requireType..
Jan 7 2019, 5:18 AM
mprobst created D56385: clang-format: [JS] support goog.requireType..
Jan 7 2019, 4:08 AM

Nov 20 2018

mprobst accepted D54753: [clang-format] JS: don't treat is: as a type matcher.
Nov 20 2018, 6:13 AM

Sep 26 2018

mprobst committed rC343179: clang-format: [JS] conditional types..
clang-format: [JS] conditional types.
Sep 26 2018, 11:53 PM
mprobst committed rL343179: clang-format: [JS] conditional types..
clang-format: [JS] conditional types.
Sep 26 2018, 11:53 PM
mprobst closed D52536: clang-format: [JS] conditional types..
Sep 26 2018, 11:53 PM
mprobst updated the diff for D52536: clang-format: [JS] conditional types..
  • comment in test
Sep 26 2018, 11:49 PM
mprobst created D52536: clang-format: [JS] conditional types..
Sep 26 2018, 2:02 AM
mprobst committed rL343080: clang-format: [JS] space after parameter naming..
clang-format: [JS] space after parameter naming.
Sep 26 2018, 1:30 AM
mprobst committed rC343080: clang-format: [JS] space after parameter naming..
clang-format: [JS] space after parameter naming.
Sep 26 2018, 1:30 AM
mprobst closed D52535: clang-format: [JS] space after parameter naming..
Sep 26 2018, 1:30 AM
mprobst closed D52535: clang-format: [JS] space after parameter naming..
Sep 26 2018, 1:30 AM
mprobst created D52535: clang-format: [JS] space after parameter naming..
Sep 26 2018, 1:14 AM

Aug 7 2018

mprobst accepted D50378: [clang-format] comment reflow: add last line's penalty when ending broken.
Aug 7 2018, 3:16 AM

Aug 3 2018

mprobst committed rL338890: clang-format: [JS] don't break comments before any '{'.
clang-format: [JS] don't break comments before any '{'
Aug 3 2018, 6:59 AM
mprobst committed rC338890: clang-format: [JS] don't break comments before any '{'.
clang-format: [JS] don't break comments before any '{'
Aug 3 2018, 6:59 AM
mprobst closed D50249: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 6:59 AM
mprobst created D50249: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 6:01 AM
mprobst added a comment to rC338837: clang-format: [JS] don't break comments before any '{'.

Roger: thanks for looking, will fix.

Aug 3 2018, 5:55 AM
mprobst committed rL338837: clang-format: [JS] don't break comments before any '{'.
clang-format: [JS] don't break comments before any '{'
Aug 3 2018, 2:35 AM
mprobst committed rC338837: clang-format: [JS] don't break comments before any '{'.
clang-format: [JS] don't break comments before any '{'
Aug 3 2018, 2:35 AM
mprobst closed D50230: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 2:35 AM
mprobst updated the diff for D50230: clang-format: [JS] don't break comments before any '{'.

Also handle multiple numbered list tokens.

Aug 3 2018, 1:57 AM
mprobst created D50230: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 1:53 AM

Aug 2 2018

mprobst committed rC338706: clang-format: fix a crash in comment wraps..
clang-format: fix a crash in comment wraps.
Aug 2 2018, 4:52 AM
mprobst committed rL338706: clang-format: fix a crash in comment wraps..
clang-format: fix a crash in comment wraps.
Aug 2 2018, 4:52 AM
mprobst closed D50177: clang-format: fix a crash in comment wraps..
Aug 2 2018, 4:52 AM
mprobst created D50177: clang-format: fix a crash in comment wraps..
Aug 2 2018, 4:19 AM