[tooling] Fix missing inline keyworkd, breaking build bot.

[etienneb]

Summary

The missing keyword "inline" is causing some buildbot to fail.
The symbol is not available.

see: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/2281/

[rnk]

lgtm

I don't see how this could be causing the problem, but it's worth a try. They should be marked inline anyway.

[alexfh]

inline seems to be completely redundant here. Can you try removing it and running whatever build configurations were failing without D20182?

[etienneb]

I'm sure you're right: they are redundant keywords.
I'm preparing the revert patch, and I'm running tests over multiple build types.

[rnk]

In D20180#427840, @alexfh wrote:

inline seems to be completely redundant here. Can you try removing it and running whatever build configurations were failing without D20182?

My bad, it's explicit function template specializations that need to be marked inline when in headers.

[etienneb]

In D20180#427893, @rnk wrote:

In D20180#427840, @alexfh wrote:

inline seems to be completely redundant here. Can you try removing it and running whatever build configurations were failing without D20182?

My bad, it's explicit function template specializations that need to be marked inline when in headers.

Hmm, it's my bad! I tried it to solve broken bot.
I try it that way because it is implemented with "inline" in ASTMatcherInternal:

Example:

template <>
inline const Stmt *GetBodyMatcher<FunctionDecl>::get(const FunctionDecl &Node) {
  return Node.doesThisDeclarationHaveABody() ? Node.getBody() : nullptr;
}

But, it's "explicit template specialisation" in the above case.

Revert patch is ready: http://reviews.llvm.org/D20189

Still thanks Reid for helping finding the repro case.

include/clang/Tooling/FixIt.h

 
 /// \brief Returns the SourceRange of the token at Location \p Loc.
 inline SourceRange getSourceRange(const SourceLocation &Loc) {
   return SourceRange(Loc);
 }
 
 /// \brief Returns the SourceRange of an given Node. \p Node is typically a
 ///        'Stmt', 'Expr' or a 'Decl'.
-template <typename T> SourceRange getSourceRange(const T &Node) {
+template <typename T> inline SourceRange getSourceRange(const T &Node) {
   return Node.getSourceRange();
 }
 } // end namespace internal
 
 // \brief Returns a textual representation of \p Node.
 template <typename T>
-StringRef getText(const T &Node, const ASTContext &Context) {
+inline StringRef getText(const T &Node, const ASTContext &Context) {
   return internal::getText(internal::getSourceRange(Node), Context);
 }
 
 // \brief Returns a FixItHint to remove \p Node.
 // TODO: Add support for related syntactical elements (i.e. comments, ...).
-template <typename T> FixItHint createRemoval(const T &Node) {
+template <typename T> inline FixItHint createRemoval(const T &Node) {
   return FixItHint::CreateRemoval(internal::getSourceRange(Node));
 }
 
 // \brief Returns a FixItHint to replace \p Destination by \p Source.
 template <typename D, typename S>
-FixItHint createReplacement(const D &Destination, const S &Source,
+inline FixItHint createReplacement(const D &Destination, const S &Source,
                                    const ASTContext &Context) {
   return FixItHint::CreateReplacement(internal::getSourceRange(Destination),
                                       getText(Source, Context));
 }
 
 } // end namespace fixit
 } // end namespace tooling
 } // end namespace clang
 
 #endif // LLVM_CLANG_TOOLING_FIXINT_H