This is an archive of the discontinued LLVM Phabricator instance.

Differential D19898

[ASan] [SystemZ] Add -mbackchain to test cflags.
ClosedPublic

Authored by • koriakin on May 3 2016, 7:43 PM.

Download Raw Diff

Details

Reviewers

kcc
uweigand
eugenis

Commits

rG1598698fcd6f: [ASan] [SystemZ] Add -mbackchain to test cflags.
rCRT269277: [ASan] [SystemZ] Add -mbackchain to test cflags.
rL269277: [ASan] [SystemZ] Add -mbackchain to test cflags.

Summary

This is needed for proper operation of the fast unwinder, see the discussion
on D18895.

Diff Detail

Repository: rL LLVM

Event Timeline

• koriakin updated this revision to Diff 56087.May 3 2016, 7:43 PM

• koriakin retitled this revision from to [ASan] [SystemZ] Add -mbackchain to test cflags..

• koriakin updated this object.

• koriakin added reviewers: uweigand, kcc, eugenis.

• koriakin set the repository for this revision to rL LLVM.

• koriakin added a project: Restricted Project.

• koriakin added a subscriber: llvm-commits.

Herald added a subscriber: kubamracek. · View Herald TranscriptMay 3 2016, 7:43 PM

Depends on D19891.

Ping?

LGTM

This revision is now accepted and ready to land.May 11 2016, 12:05 PM

Closed by commit rL269277: [ASan] [SystemZ] Add -mbackchain to test cflags. (authored by • koriakin). · Explain WhyMay 12 2016, 1:55 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

compiler-rt/

trunk/

test/

asan/

lit.cfg

2 lines

Diff 57006

compiler-rt/trunk/test/asan/lit.cfg

	Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
	# FIXME: Review the set of required flags and check if it can be reduced.			# FIXME: Review the set of required flags and check if it can be reduced.
	target_cflags = [get_required_attr(config, "target_cflags")] + extra_linkflags			target_cflags = [get_required_attr(config, "target_cflags")] + extra_linkflags
	target_cxxflags = config.cxx_mode_flags + target_cflags			target_cxxflags = config.cxx_mode_flags + target_cflags
	clang_asan_static_cflags = (["-fsanitize=address",			clang_asan_static_cflags = (["-fsanitize=address",
	"-mno-omit-leaf-frame-pointer",			"-mno-omit-leaf-frame-pointer",
	"-fno-omit-frame-pointer",			"-fno-omit-frame-pointer",
	"-fno-optimize-sibling-calls"] +			"-fno-optimize-sibling-calls"] +
	config.debug_info_flags + target_cflags)			config.debug_info_flags + target_cflags)
				if config.target_arch == 's390x':
				clang_asan_static_cflags.append("-mbackchain")
	clang_asan_static_cxxflags = config.cxx_mode_flags + clang_asan_static_cflags			clang_asan_static_cxxflags = config.cxx_mode_flags + clang_asan_static_cflags

	if config.asan_dynamic:			if config.asan_dynamic:
	clang_asan_cflags = clang_asan_static_cflags + ['-shared-libasan']			clang_asan_cflags = clang_asan_static_cflags + ['-shared-libasan']
	clang_asan_cxxflags = clang_asan_static_cxxflags + ['-shared-libasan']			clang_asan_cxxflags = clang_asan_static_cxxflags + ['-shared-libasan']
	config.available_features.add("asan-dynamic-runtime")			config.available_features.add("asan-dynamic-runtime")
	else:			else:
	clang_asan_cflags = clang_asan_static_cflags			clang_asan_cflags = clang_asan_static_cflags
	▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines