This is an archive of the discontinued LLVM Phabricator instance.

Remove LLVM_ENABLE_TIMESTAMPS
ClosedPublic

Authored by beanz on May 3 2016, 3:39 PM.

Details

Summary

As per the discussion on LLVM-dev this patch proposes removing LLVM_ENABLE_TIMESTAMPS.

The only complicated bit of this patch is the Windows support. On windows we used to log an error if /INCREMENTAL was passed to the linker when timestamps were disabled.

With this change since timestamps in code are always disabled we will always compile on windows with /Brepro unless /INCREMENTAL is specified, and we will log a warning when /INCREMENTAL is specified to notify the user that the build will be non-deterministic.

See: http://lists.llvm.org/pipermail/llvm-dev/2016-May/098990.html

Diff Detail

Event Timeline

beanz updated this revision to Diff 56074.May 3 2016, 3:39 PM
beanz retitled this revision from to Remove LLVM_ENABLE_TIMESTAMPS.
beanz updated this object.
beanz added reviewers: bogner, silvas, rnk.
beanz added a subscriber: llvm-commits.
rnk accepted this revision.May 3 2016, 6:20 PM
rnk edited edge metadata.

Sounds like a plan!

cmake/modules/HandleLLVMOptions.cmake
371

Looks like a run-on. Maybe end the sentence and start a new one.

391

We can warn and see if people complain, but I think people using the incremental linker have no expectation of getting a reproducible build artifact. We want /Brepro when there is no incremental linking, though, so this change is good.

This revision is now accepted and ready to land.May 3 2016, 6:20 PM
beanz updated this revision to Diff 56322.May 5 2016, 11:51 AM
beanz edited edge metadata.

Fixed the comment @rnk called out and cleaned up the check for "/INCREMENTAL" to be simpler.

Closed by commit rL268670: Remove LLVM_ENABLE_TIMESTAMPS (authored by cbieneman). · Explain WhyMay 5 2016, 1:03 PM
This revision was automatically updated to reflect the committed changes.