Page MenuHomePhabricator

ELF: Fix regression in TLS attribute mismatch logic.
ClosedPublic

Authored by pcc on May 2 2016, 2:03 PM.

Details

Summary

Introduce a special symbol type to indicate that we have not yet seen a type
for the symbol, so we should not report TLS mismatches for that symbol.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 55894.May 2 2016, 2:03 PM
pcc retitled this revision from to ELF: Fix regression in TLS attribute mismatch logic..
pcc updated this object.
pcc added reviewers: rafael, ruiu.
pcc added a subscriber: llvm-commits.
emaste added a subscriber: emaste.May 2 2016, 7:14 PM
ruiu accepted this revision.May 2 2016, 7:28 PM
ruiu edited edge metadata.

LGTM, but we should wait for Ed if he can confirm the fix.

This revision is now accepted and ready to land.May 2 2016, 7:28 PM
ed accepted this revision.May 3 2016, 2:15 AM
ed added a reviewer: ed.
ed added a subscriber: ed.

Seems to fix the issue. Thanks!

This revision was automatically updated to reflect the committed changes.