Page MenuHomePhabricator

Use PIELevel module flags instead of Target option PositionIndependentExecutable
ClosedPublic

Authored by tmsriram on Apr 29 2016, 11:41 AM.

Details

Summary
  • Use PIELevel module flags instead of Target option PositionIndependentExecutable
  • Remove use of -enable-pie option with llc in tests
  • Add PIELevel module flag to tests where PIE should be enabled

After this, I can safely delete Target option PositionIndependentExecutable. I will send a clang patch to delete all references to this.

Diff Detail

Repository
rL LLVM

Event Timeline

tmsriram updated this revision to Diff 55636.Apr 29 2016, 11:41 AM
tmsriram retitled this revision from to Use PIELevel module flags instead of Target option PositionIndependentExecutable.
tmsriram updated this object.
tmsriram added reviewers: rnk, davidxl.
tmsriram added a subscriber: llvm-commits.
rnk accepted this revision.Apr 29 2016, 11:49 AM
rnk edited edge metadata.

lgtm, one less TargetOption!

This revision is now accepted and ready to land.Apr 29 2016, 11:49 AM
tmsriram updated this revision to Diff 55639.Apr 29 2016, 11:51 AM
tmsriram updated this object.
tmsriram edited edge metadata.
  • Delete option -enable-pie.
This revision was automatically updated to reflect the committed changes.