Page MenuHomePhabricator

[clang] [Builtin] Make __builtin_thread_pointer target-independent.
ClosedPublic

Authored by koriakin on Apr 27 2016, 6:54 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

koriakin retitled this revision from to [clang] [Builtin] Make __builtin_thread_pointer target-independent..
koriakin updated this object.
koriakin added reviewers: asl, rjmccall.
koriakin set the repository for this revision to rL LLVM.
koriakin added a subscriber: cfe-commits.

Updated version: changed triple in a test to linux - ios doesn't support TLS, so __builtin_thread_pointer now rightly fails.

rjmccall edited edge metadata.Apr 27 2016, 9:33 AM

Why the random triple change on the test?

Otherwise LGTM.

Why the random triple change on the test?

Otherwise LGTM.

See the comment above - arm64-apple-ios doesn't support TLS, so __builtin_thread_pointer is meaningless (it compiled before, but would result in an error now due to the isTLSSupported check).

Oh, I see. Sure, LGTM.

This revision was automatically updated to reflect the committed changes.