This is an archive of the discontinued LLVM Phabricator instance.

[mips] Fix select patterns for MIPS64
AbandonedPublic

Authored by sdardis on Apr 21 2016, 11:08 AM.

Details

Summary

When targetting MIPS64R6 some of the patterns for select were guarded by a
broken predicate. The predicate was supposed to test if a constant value
could fit in a 16 bit zero-extended field. Instead the value was tested to
fit in a 16 bit sign-extended field. For negative constants of native word
width this resulted in wrong code generation.

Diff Detail

Event Timeline

sdardis updated this revision to Diff 54546.Apr 21 2016, 11:08 AM
sdardis retitled this revision from to [mips] Fix select patterns for MIPS64.
sdardis updated this object.
sdardis added reviewers: dsanders, vkalintiris.
sdardis set the repository for this revision to rL LLVM.
sdardis added subscribers: zoran.jovanovic, petarj.
sdardis abandoned this revision.Apr 21 2016, 11:08 AM