This is an archive of the discontinued LLVM Phabricator instance.

Differential D19099

[clang] [AArch64] Fix D19098 fallout.
ClosedPublic

Authored by • koriakin on Apr 14 2016, 1:23 AM.

Details

Reviewers
t.p.northover
rjmccall
Commits
rG4005070e1bad: [AArch64] Fix D19098 fallout.
rC266817: [AArch64] Fix D19098 fallout.
rL266817: [AArch64] Fix D19098 fallout.
Summary

The intrinsic is now called llvm.thread.pointer, not
llvm.aarch64.thread.pointer. Also, the code handling it in CGBuiltin.cpp
is dead - it's already covered by GCCBuiltin. Remove it.

Diff Detail

Event Timeline

• koriakin updated this revision to Diff 53667.Apr 14 2016, 1:23 AM
• koriakin retitled this revision from to [clang] [AArch64] Fix D19098 fallout..
• koriakin updated this object.
• koriakin added a reviewer: t.p.northover.
• koriakin set the repository for this revision to rL LLVM.
• koriakin added a subscriber: llvm-commits.
Herald added subscribers: rengolin, aemerson. · View Herald TranscriptApr 14 2016, 1:23 AM
• koriakin added a parent revision: D19098: [AArch64] [ARM] Make a target-independent llvm.thread.pointer intrinsic..Apr 14 2016, 2:00 AM
• koriakin mentioned this in D19098: [AArch64] [ARM] Make a target-independent llvm.thread.pointer intrinsic..Apr 18 2016, 12:25 PM
• koriakin added a reviewer: rjmccall.Apr 19 2016, 4:58 AM
• koriakin added a subscriber: cfe-commits.
t.p.northover accepted this revision.Apr 19 2016, 9:23 AM
t.p.northover edited edge metadata.

Looks good to me. I love seeing the death of a target-specific intrinsic!

Tim.

This revision is now accepted and ready to land.Apr 19 2016, 9:23 AM
Closed by commit rL266817: [AArch64] Fix D19098 fallout. (authored by • koriakin). · Explain WhyApr 19 2016, 1:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
CodeGen/
5 lines
test/
CodeGen/
2 lines

Diff 53667

lib/CodeGen/CGBuiltin.cpp

Context not available.
return Builder.CreateCall(F); return Builder.CreateCall(F);
} }
if (BuiltinID == AArch64::BI__builtin_thread_pointer) {
Function *F = CGM.getIntrinsic(Intrinsic::aarch64_thread_pointer);
return Builder.CreateCall(F);
}
// CRC32 // CRC32
Intrinsic::ID CRCIntrinsicID = Intrinsic::not_intrinsic; Intrinsic::ID CRCIntrinsicID = Intrinsic::not_intrinsic;
switch (BuiltinID) { switch (BuiltinID) {
Context not available.

test/CodeGen/builtins-arm64.c

Context not available.
void *tp (void) { void *tp (void) {
return __builtin_thread_pointer (); return __builtin_thread_pointer ();
// CHECK: call {{.*}} @llvm.aarch64.thread.pointer() // CHECK: call {{.*}} @llvm.thread.pointer()
} }
// CHECK: call {{.*}} @llvm.aarch64.rbit.i32(i32 %a) // CHECK: call {{.*}} @llvm.aarch64.rbit.i32(i32 %a)
Context not available.