Page MenuHomePhabricator

Documented standard substitutions defined by lit
ClosedPublic

Authored by RedX2501 on Apr 4 2016, 12:40 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

RedX2501 updated this revision to Diff 52526.Apr 4 2016, 12:40 AM
RedX2501 retitled this revision from to Documented standard substitutions defined by lit.
RedX2501 updated this object.
RedX2501 added reviewers: EricWF, MatzeB, echristo, jroelofs.
RedX2501 added a subscriber: cfe-commits.
MatzeB edited edge metadata.Apr 4 2016, 12:46 AM

Most patterns and several of the ones coming from lit.local.cfg are explained in TestingGuide.rst as well. On the other hand it makes sense to explain the lit specific substitutions in the lit docu, maybe just add an additional link to the TestingGuide.rst to reference this section for additional lit flags?

RedX2501 updated this revision to Diff 52530.Apr 4 2016, 1:08 AM
RedX2501 edited edge metadata.

Added reference to testing infrastructure document.

MatzeB accepted this revision.Apr 4 2016, 1:13 AM
MatzeB edited edge metadata.

I'd probably go for a term like "pattern" instead of macro (there is no parameters or anything more complicated). The explanation for %t/%T is not helpful in the current form. Maybe something like 'temporary file name unique to the test'/'temporary directory unique to the test'.

Apart from that LGTM.

This revision is now accepted and ready to land.Apr 4 2016, 1:13 AM
RedX2501 updated this revision to Diff 52531.Apr 4 2016, 1:47 AM
RedX2501 edited edge metadata.

I had a hard time myself figuring out what tmpbase and tmpdir are. I have used your wording.

Somebody else needs to commit this as I don't have any rights for it.

Somebody else needs to commit this as I don't have any rights for it.

When someone else commits for you, our practice is to attribute the correct author in the commit message.
This is more than a courtesy, because you retain copyright of any changes you have made. Therefore we prefer to use your actual name rather than a handle such as RedX2501, guibufolo, or Guilherme.
What name would you like us to use?

Thanks for the advice.

Please use Guilherme Bufolo as the name for the commit.
Am 04.04.2016 21:33 schrieb "Paul Robinson" <
Paul_Robinson@playstation.sony.com>:

probinson added a subscriber: probinson.
probinson added a comment.

In http://reviews.llvm.org/D18752#390906, @RedX2501 wrote:

> Somebody else needs to commit this as I don't have any rights for it.

When someone else commits for you, our practice is to attribute the
correct author in the commit message.
This is more than a courtesy, because you retain copyright of any changes
you have made. Therefore we prefer to use your actual name rather than a
handle such as RedX2501, guibufolo, or Guilherme.
What name would you like us to use?

http://reviews.llvm.org/D18752

This revision was automatically updated to reflect the committed changes.