This is an archive of the discontinued LLVM Phabricator instance.

Fix PR26940 where compiles times regressed massively.
ClosedPublic

Authored by chandlerc on Mar 31 2016, 1:22 PM.

Details

Summary

Patch by Jonas Paulsson. Original description:
Bugfix in buildSchedGraph() to make -dag-maps-huge-region work properly

I found that the reduction of the maps did in fact never happen in this
test case. This was because *all* the stores / loads were made with
addresses from arguments and they thus became "unknown" stores / loads.
Fixed by removing continue statements and making sure that the test for
reduction always takes place.

Diff Detail

Event Timeline

chandlerc updated this revision to Diff 52277.Mar 31 2016, 1:22 PM
chandlerc retitled this revision from to Fix PR26940 where compiles times regressed massively..
chandlerc updated this object.
chandlerc added a reviewer: echristo.
chandlerc added a subscriber: llvm-commits.
echristo accepted this revision.Mar 31 2016, 1:28 PM
echristo edited edge metadata.

Sure, that seems reasonable.

-eric

This revision is now accepted and ready to land.Mar 31 2016, 1:28 PM

Sure, that seems reasonable.

I think so too.

-eric

This revision was automatically updated to reflect the committed changes.