This is an archive of the discontinued LLVM Phabricator instance.

[X86] Introduction of -march=lakemont
ClosedPublic

Authored by aturetsk on Mar 31 2016, 8:58 AM.

Diff Detail

Event Timeline

aturetsk updated this revision to Diff 52220.Mar 31 2016, 8:58 AM
aturetsk retitled this revision from to [X86] Introduction of -march=lakemont.
aturetsk updated this object.
aturetsk added reviewers: rsmith, echristo.
aturetsk added subscribers: cfe-commits, zinovy.nis.

I used existing test "test/CodeGen/attr-target-x86.c" to check Lakemont's target features. However the test is actually run with 64-bit triple "x86_64-linux-gnu", so "+mmx,+sse,+sse2" are included in target features. The same thing happens with Pentium and other 32-bit-only CPUs. I wonder if we should have some check so that 32-bit-only CPUs couldn't be used with 64-bit triple. What do you think?

echristo accepted this revision.Apr 4 2016, 2:51 PM
echristo edited edge metadata.

I'm not real fond of the testcase being in attr-target-x86, but there's not a better place at the moment either.

-eric

This revision is now accepted and ready to land.Apr 4 2016, 2:51 PM
This revision was automatically updated to reflect the committed changes.