Page MenuHomePhabricator

zinovy.nis (Zinovy Nis)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2014, 7:51 AM (267 w, 2 d)

Recent Activity

Yesterday

zinovy.nis updated the diff for D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Sat, Mar 23, 5:40 AM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Sat, Mar 23, 5:40 AM · Restricted Project, Restricted Project
zinovy.nis created D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Sat, Mar 23, 5:37 AM · Restricted Project, Restricted Project

Thu, Mar 21

zinovy.nis committed rG72bb9a65d62a: Reland r356547 after fixing the YAML module missing issue. (authored by zinovy.nis).
Reland r356547 after fixing the YAML module missing issue.
Thu, Mar 21, 1:33 AM
zinovy.nis committed rCTE356649: Reland r356547 after fixing the YAML module missing issue..
Reland r356547 after fixing the YAML module missing issue.
Thu, Mar 21, 1:33 AM
zinovy.nis committed rL356649: Reland r356547 after fixing the YAML module missing issue..
Reland r356547 after fixing the YAML module missing issue.
Thu, Mar 21, 1:33 AM

Wed, Mar 20

zinovy.nis committed rGaf8817570456: [clang-tidy] Fix redundant check breaking the test on many platforms. (authored by zinovy.nis).
[clang-tidy] Fix redundant check breaking the test on many platforms.
Wed, Mar 20, 11:37 AM
zinovy.nis committed rCTE356589: [clang-tidy] Fix redundant check breaking the test on many platforms..
[clang-tidy] Fix redundant check breaking the test on many platforms.
Wed, Mar 20, 11:36 AM
zinovy.nis committed rL356589: [clang-tidy] Fix redundant check breaking the test on many platforms..
[clang-tidy] Fix redundant check breaking the test on many platforms.
Wed, Mar 20, 11:36 AM
zinovy.nis added inline comments to rG538fb72226cf: Reland r356547 after fixing the tests for Linux..
Wed, Mar 20, 8:54 AM
zinovy.nis committed rG538fb72226cf: Reland r356547 after fixing the tests for Linux. (authored by zinovy.nis).
Reland r356547 after fixing the tests for Linux.
Wed, Mar 20, 8:50 AM
zinovy.nis committed rL356565: Reland r356547 after fixing the tests for Linux..
Reland r356547 after fixing the tests for Linux.
Wed, Mar 20, 8:49 AM
zinovy.nis committed rCTE356565: Reland r356547 after fixing the tests for Linux..
Reland r356547 after fixing the tests for Linux.
Wed, Mar 20, 8:49 AM
zinovy.nis committed rG4bfe83679d6f: [clang-tidy] Cosmetic fix (authored by zinovy.nis).
[clang-tidy] Cosmetic fix
Wed, Mar 20, 4:34 AM
zinovy.nis committed rCTE356548: [clang-tidy] Cosmetic fix.
[clang-tidy] Cosmetic fix
Wed, Mar 20, 4:34 AM
zinovy.nis committed rL356548: [clang-tidy] Cosmetic fix.
[clang-tidy] Cosmetic fix
Wed, Mar 20, 4:34 AM
zinovy.nis committed rGd3939d2013e9: [clang-tidy] Parallelize clang-tidy-diff.py (authored by zinovy.nis).
[clang-tidy] Parallelize clang-tidy-diff.py
Wed, Mar 20, 4:30 AM
zinovy.nis committed rCTE356547: [clang-tidy] Parallelize clang-tidy-diff.py.
[clang-tidy] Parallelize clang-tidy-diff.py
Wed, Mar 20, 4:29 AM
zinovy.nis committed rL356547: [clang-tidy] Parallelize clang-tidy-diff.py.
[clang-tidy] Parallelize clang-tidy-diff.py
Wed, Mar 20, 4:29 AM
zinovy.nis closed D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Wed, Mar 20, 4:29 AM · Restricted Project, Restricted Project

Tue, Mar 19

zinovy.nis added a comment to D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.

How is this functionality different from the clang-tidy-diff.py script with the -j option being added in the other patch?

Tue, Mar 19, 10:10 PM · Restricted Project, Restricted Project
zinovy.nis added a comment to D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.

Any comments?

Tue, Mar 19, 12:09 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

One more gentle ping.

Tue, Mar 19, 12:08 AM · Restricted Project, Restricted Project

Sat, Mar 16

zinovy.nis updated the summary of D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.
Sat, Mar 16, 3:19 AM · Restricted Project, Restricted Project
zinovy.nis created D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.
Sat, Mar 16, 3:16 AM · Restricted Project, Restricted Project

Fri, Mar 8

zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Gentle ping.

Fri, Mar 8, 8:49 AM · Restricted Project, Restricted Project

Wed, Mar 6

zinovy.nis updated the diff for D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
  • honest '--export-fixes': multiple yamls are merged into the resulting one.
  • minor cosmetic fixes.
Wed, Mar 6, 12:35 PM · Restricted Project, Restricted Project
zinovy.nis retitled D57662: [clang-tidy] Parallelize clang-tidy-diff.py from [clang-tidy] Parallelise clang-tidy-diff.py to [clang-tidy] Parallelize clang-tidy-diff.py .
Wed, Mar 6, 9:52 AM · Restricted Project, Restricted Project

Feb 22 2019

zinovy.nis added inline comments to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 22 2019, 12:17 AM · Restricted Project, Restricted Project

Feb 19 2019

zinovy.nis updated the diff for D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
  • -j is 1 by default;
  • fixed minor remarks;
Feb 19 2019, 11:43 AM · Restricted Project, Restricted Project

Feb 15 2019

zinovy.nis added inline comments to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 15 2019, 6:40 AM · Restricted Project, Restricted Project

Feb 14 2019

zinovy.nis added inline comments to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 14 2019, 1:43 AM · Restricted Project, Restricted Project

Feb 13 2019

zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Any comments?

Feb 13 2019, 10:55 AM · Restricted Project, Restricted Project

Feb 12 2019

zinovy.nis updated the diff for D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

-j and -export-fixes were made mutually exclusive.

Feb 12 2019, 10:44 AM · Restricted Project, Restricted Project

Feb 11 2019

zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

I only say this because I think I might have seen it happen when I was running run-clang-tidy.py over a large code base with a fairly aggressive check/fixit, but frankly I was too new to LLVM to know it wasn't something I might have done wrong.

Feb 11 2019, 3:26 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Just a question.. If clang tidy is running with -fix in parallel, what stops each clang-tidy invocation altering a common header at the same time?

Feb 11 2019, 3:01 AM · Restricted Project, Restricted Project

Feb 10 2019

zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Gentle ping.

Feb 10 2019, 10:19 PM · Restricted Project, Restricted Project

Feb 4 2019

zinovy.nis updated the diff for D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 4 2019, 10:39 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Fixed minor typos.

Feb 4 2019, 10:30 AM · Restricted Project, Restricted Project

Feb 3 2019

zinovy.nis created D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 3 2019, 11:29 AM · Restricted Project, Restricted Project

Jan 22 2019

zinovy.nis committed rCTE351925: [doc] Fix svn property for bugprone-parent-virtual-call.rst.
[doc] Fix svn property for bugprone-parent-virtual-call.rst
Jan 22 2019, 10:47 PM
zinovy.nis committed rL351925: [doc] Fix svn property for bugprone-parent-virtual-call.rst.
[doc] Fix svn property for bugprone-parent-virtual-call.rst
Jan 22 2019, 10:47 PM
zinovy.nis committed rL351867: [doc] Replace 'class' with 'struct' for 'public' by default.
[doc] Replace 'class' with 'struct' for 'public' by default
Jan 22 2019, 12:27 PM
zinovy.nis committed rCTE351867: [doc] Replace 'class' with 'struct' for 'public' by default.
[doc] Replace 'class' with 'struct' for 'public' by default
Jan 22 2019, 12:27 PM

Oct 12 2018

zinovy.nis committed rCTE344343: [clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK.
[clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK
Oct 12 2018, 6:38 AM
zinovy.nis committed rL344343: [clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK.
[clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK
Oct 12 2018, 6:37 AM
zinovy.nis closed D53194: [clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK.
Oct 12 2018, 6:37 AM · Restricted Project
zinovy.nis created D53194: [clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK.
Oct 12 2018, 5:34 AM · Restricted Project
zinovy.nis added a comment to D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.

Hi,

It looks like this change has disabled FileCheck for all clang-tidy lit tests that don't use check-prefixes. So, they all trivially pass even if their CHECK... lines are wrong. An easy repro is just to randomly modify any CHECK line in a lit file (e.g. llvm/tools/clang/tools/extra/test/clang-tidy/readability-avoid-const-params-in-decls.cpp) and run ninja check-clang-tools.

In check_clang_tidy.py, if you add back (slightly modified) lines 93-95 to the else branch (line 132), it seems to fix the problem. For example, add:

has_check_fixes = check_fixes_prefixes[0] in input_text
has_check_messages = check_messages_prefixes[0] in input_text
has_check_notes = check_notes_prefixes[0] in input_text
Oct 12 2018, 2:07 AM · Restricted Project

Oct 11 2018

zinovy.nis added inline comments to D52771: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines, HICPP).
Oct 11 2018, 2:30 AM · Restricted Project

Oct 8 2018

zinovy.nis committed rCTE344016: [clang-tidy][docs] Update docs for `--check-suffixes`.
[clang-tidy][docs] Update docs for `--check-suffixes`
Oct 8 2018, 10:52 PM
zinovy.nis committed rL344016: [clang-tidy][docs] Update docs for `--check-suffixes`.
[clang-tidy][docs] Update docs for `--check-suffixes`
Oct 8 2018, 10:52 PM
zinovy.nis committed rCTE344015: [clang-tidy] The patch extends the existing command line option -check-suffix .
[clang-tidy] The patch extends the existing command line option -check-suffix
Oct 8 2018, 10:42 PM
zinovy.nis committed rL344015: [clang-tidy] The patch extends the existing command line option -check-suffix .
[clang-tidy] The patch extends the existing command line option -check-suffix
Oct 8 2018, 10:42 PM
zinovy.nis closed D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.
Oct 8 2018, 10:42 PM · Restricted Project
zinovy.nis updated the summary of D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.
Oct 8 2018, 12:34 PM · Restricted Project
zinovy.nis added a comment to D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.

I think it would make sense to migrate one test already, to use the new capability

Oct 8 2018, 12:31 PM · Restricted Project
zinovy.nis updated the diff for D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.
  • Fixed diagnostics;
  • Interchangeable alias introduced: -check-suffixes for -check-suffix.
Oct 8 2018, 11:42 AM · Restricted Project
zinovy.nis added a comment to D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.

Looks good with a comment.

Oct 8 2018, 5:15 AM · Restricted Project
zinovy.nis added a comment to D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.

The change looks good in principle. I think it would make sense to migrate one test already, to use the new capability and check if everything works as expected. The current tests still run fine?

Oct 8 2018, 5:10 AM · Restricted Project

Oct 7 2018

zinovy.nis added inline comments to D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.
Oct 7 2018, 10:46 PM · Restricted Project
zinovy.nis updated the diff for D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.

Removed "," from the list of allowed suffix characters.

Oct 7 2018, 10:42 PM · Restricted Project
zinovy.nis added a comment to D45776: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py.

Did this intentionally omit the possibility to pass a group of prefixes, like FileCheck supports?
Usefulness of this feature is somewhat penalized by this.

Oct 7 2018, 11:51 AM · Restricted Project
zinovy.nis created D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.
Oct 7 2018, 11:50 AM · Restricted Project

Oct 3 2018

zinovy.nis added a comment to D45776: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py.

Did this intentionally omit the possibility to pass a group of prefixes, like FileCheck supports?
Usefulness of this feature is somewhat penalized by this.

Oct 3 2018, 10:38 AM · Restricted Project

Aug 18 2018

zinovy.nis added inline comments to D50852: [clang-tidy] abseil-auto-make-unique.
Aug 18 2018, 12:43 PM · Restricted Project
zinovy.nis added a comment to D50852: [clang-tidy] abseil-auto-make-unique.
  1. Please always upload all patches with full context.
  2. There already is modernize-use-auto. Does it handle this case? Then this should be just an alias to that check. Else, i think it would be best to extend that one, and still alias.
Aug 18 2018, 12:14 PM · Restricted Project

Jun 15 2018

zinovy.nis committed rL334829: [clang-tidy] This patch is a fix for D45405 where spaces were mistakenly….
[clang-tidy] This patch is a fix for D45405 where spaces were mistakenly…
Jun 15 2018, 6:40 AM
zinovy.nis committed rCTE334829: [clang-tidy] This patch is a fix for D45405 where spaces were mistakenly….
[clang-tidy] This patch is a fix for D45405 where spaces were mistakenly…
Jun 15 2018, 6:40 AM
zinovy.nis closed D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.
Jun 15 2018, 6:40 AM · Restricted Project

May 22 2018

zinovy.nis added inline comments to D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type.
May 22 2018, 1:10 PM · Restricted Project
zinovy.nis added inline comments to D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type.
May 22 2018, 12:34 PM · Restricted Project
zinovy.nis committed rCTE333003: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of….
[clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of…
May 22 2018, 10:28 AM
zinovy.nis committed rL333003: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of….
[clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of…
May 22 2018, 10:28 AM
zinovy.nis closed D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type.
May 22 2018, 10:28 AM · Restricted Project

May 21 2018

zinovy.nis updated the diff for D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type.
  • More accurate place to fix.
May 21 2018, 12:36 PM · Restricted Project

May 20 2018

zinovy.nis created D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type.
May 20 2018, 2:03 PM · Restricted Project

May 18 2018

zinovy.nis added a comment to D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.

Alexander, can you please have a look at the latest patch? Thanks.

May 18 2018, 6:26 AM · Restricted Project

May 16 2018

zinovy.nis added inline comments to D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.
May 16 2018, 2:26 AM · Restricted Project

May 14 2018

zinovy.nis updated the diff for D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.
  • Fix for templated type names. Thanks AlexanderK for pointing.
May 14 2018, 1:45 PM · Restricted Project

May 6 2018

zinovy.nis added inline comments to D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.
May 6 2018, 12:40 PM · Restricted Project
zinovy.nis added inline comments to D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.
May 6 2018, 11:28 AM · Restricted Project

May 5 2018

zinovy.nis added inline comments to D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.
May 5 2018, 12:27 PM · Restricted Project

May 3 2018

zinovy.nis committed rL331475: Simplify test clang-tidy-__clang_analyzer__macro.cpp .
Simplify test clang-tidy-__clang_analyzer__macro.cpp
May 3 2018, 11:35 AM
zinovy.nis committed rCTE331475: Simplify test clang-tidy-__clang_analyzer__macro.cpp .
Simplify test clang-tidy-__clang_analyzer__macro.cpp
May 3 2018, 11:35 AM
zinovy.nis committed rCTE331474: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility….
[clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility…
May 3 2018, 11:31 AM
zinovy.nis committed rL331474: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility….
[clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility…
May 3 2018, 11:31 AM
zinovy.nis closed D46325: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer. 2nd try..
May 3 2018, 11:31 AM · Restricted Project
zinovy.nis added a comment to D46325: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer. 2nd try..

Thanks Alexander for your feedback!

May 3 2018, 11:22 AM · Restricted Project
zinovy.nis updated the diff for D46325: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer. 2nd try..
  • Added comments on why setting ProgramAction explicitly.
May 3 2018, 11:12 AM · Restricted Project

May 1 2018

zinovy.nis closed D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals.

Fixed in git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@331297 91177308-0d34-0410-b5e6-96231b3b80d8

May 1 2018, 1:28 PM · Restricted Project
zinovy.nis added a comment to D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals.

https://reviews.llvm.org/rCTE331297

May 1 2018, 1:28 PM · Restricted Project
zinovy.nis committed rCTE331297: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw….
[clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw…
May 1 2018, 11:50 AM
zinovy.nis committed rL331297: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw….
[clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw…
May 1 2018, 11:50 AM
zinovy.nis added inline comments to D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals.
May 1 2018, 11:35 AM · Restricted Project
zinovy.nis created D46325: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer. 2nd try..
May 1 2018, 11:18 AM · Restricted Project
zinovy.nis added inline comments to D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals.
May 1 2018, 10:32 AM · Restricted Project
zinovy.nis updated the diff for D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.
  • Applied Alexander's changes.
May 1 2018, 8:12 AM · Restricted Project
zinovy.nis added a comment to D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals.

Gentle ping.

May 1 2018, 7:52 AM · Restricted Project

Apr 30 2018

zinovy.nis added a comment to D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.

I think, it's 13, if you choose to remove stars, and 17 otherwise. The difference is excessive spaces vs. required ones. Implementing proper logic may be involved, but we can simplify it to something like "count all non-space characters and a single space between words, but don't count spaces around punctuation":

Apr 30 2018, 10:44 AM · Restricted Project