Page MenuHomePhabricator

zinovy.nis (Zinovy Nis)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2014, 7:51 AM (321 w, 5 d)

Recent Activity

Sun, Apr 5

zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Rebase over the current master.

Sun, Apr 5, 2:39 AM · Restricted Project, Restricted Project

Tue, Mar 24

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Gentle ping)

Tue, Mar 24, 12:30 AM · Restricted Project, Restricted Project

Sun, Mar 15

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

I still think this entire patch is misguided; there's no reason to make the note for const std::string s; std::move(s) any longer than the note for int i; std::move(i) or volatile std::string v; std::move(v). People should not be using moved-from objects, period; and those who want to use moved-from objects, should not enable this clang-tidy check.

However, I have no further comments besides philosophical opposition to the whole idea.

Sun, Mar 15, 3:11 AM · Restricted Project, Restricted Project

Sat, Mar 14

zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Removed top-level consts.

Sat, Mar 14, 12:20 PM · Restricted Project, Restricted Project

Wed, Mar 11

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

I'm done, Aaron, Quuxplusone, do you have any comments?

Wed, Mar 11, 12:09 AM · Restricted Project, Restricted Project

Mar 8 2020

zinovy.nis added inline comments to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Mar 8 2020, 3:43 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Anyway, I still don't see the point of this patch. It seems like you're just duplicating the work of performance-move-const-arg. People who want to be shown notes about moves-of-const-args should just enable that check instead.

Mar 8 2020, 3:10 AM · Restricted Project, Restricted Project

Mar 7 2020

zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Cosmetic and style fixes.

Mar 7 2020, 12:01 AM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Mar 7 2020, 12:01 AM · Restricted Project, Restricted Project

Mar 6 2020

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Any further comments?

Mar 6 2020, 2:12 AM · Restricted Project, Restricted Project

Mar 3 2020

zinovy.nis updated the summary of D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Mar 3 2020, 12:36 PM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Typo fixed.

Mar 3 2020, 11:57 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
  1. Special handling for captured variables in lambdas,
  2. messages texts were changed.
Mar 3 2020, 11:57 AM · Restricted Project, Restricted Project

Feb 26 2020

zinovy.nis added inline comments to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 26 2020, 7:56 AM · Restricted Project, Restricted Project
zinovy.nis abandoned D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks.
Feb 26 2020, 2:34 AM · Restricted Project

Feb 25 2020

zinovy.nis updated the summary of D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks.
Feb 25 2020, 10:25 PM · Restricted Project
zinovy.nis added reviewers for D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks: dlj, alexfh.
Feb 25 2020, 9:58 PM · Restricted Project
zinovy.nis retitled D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts from [clang-tidy] Make bugprone-use-after-move ignore std::move for const values to [clang-tidy][bugprone-use-after-mnove] Warn on std::move for consts.
Feb 25 2020, 9:49 PM · Restricted Project, Restricted Project
zinovy.nis updated the summary of D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 25 2020, 9:49 PM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Warning on use after move is still generated. But there's also an additional note

Feb 25 2020, 9:49 PM · Restricted Project, Restricted Project

Feb 23 2020

zinovy.nis created D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks.
Feb 23 2020, 9:15 AM · Restricted Project

Feb 20 2020

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

(I sent this to the mailing list, but I guess it doesn't show up here unless I do it through Phab. Quoting myself—)

I see your point about how users who care should always be passing this check alongside "performance-move-const-arg"; but IMHO it still makes sense for clang-tidy to warn unconditionally about code of the form

x = std::move(y);
use(y);

regardless of the incidental type of y. Sure, it's technically not wrong if y is const... or if y is a primitive type, such as Widget*... or if y is a well-defined library type, such as std::shared_ptr<Widget>... or if y is a library type that works in practice, such as std::list<int>... but regardless of its technical merits, the code is still logically semantically wrong, and I think that's what the clang-tidy check should be trying to diagnose.

Feb 20 2020, 12:57 AM · Restricted Project, Restricted Project

Feb 17 2020

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Even if no move actually happens, the code is still wrong

Feb 17 2020, 12:02 PM · Restricted Project, Restricted Project

Feb 16 2020

zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 16 2020, 7:43 AM · Restricted Project, Restricted Project
zinovy.nis updated the summary of D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 16 2020, 7:34 AM · Restricted Project, Restricted Project
zinovy.nis updated the summary of D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 16 2020, 7:27 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 16 2020, 7:25 AM · Restricted Project, Restricted Project
zinovy.nis created D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 16 2020, 7:25 AM · Restricted Project, Restricted Project

Dec 29 2019

zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

@zinovy.nis @alexfh @JonasToth @MyDeveloperDay

I'd be happy to provide a patch.

Dec 29 2019, 3:34 AM · Restricted Project, Restricted Project

Dec 1 2019

zinovy.nis accepted D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script.
Dec 1 2019, 10:33 AM · Restricted Project

Nov 3 2019

zinovy.nis added inline comments to D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script.
Nov 3 2019, 7:07 AM · Restricted Project

Oct 20 2019

zinovy.nis committed rG5fa36e42c43b: Fix buildbot error in SIRegisterInfo.cpp. (authored by zinovy.nis).
Fix buildbot error in SIRegisterInfo.cpp.
Oct 20 2019, 1:00 PM
zinovy.nis committed rL375373: Fix buildbot error in SIRegisterInfo.cpp..
Fix buildbot error in SIRegisterInfo.cpp.
Oct 20 2019, 12:59 PM
zinovy.nis committed rG5b8546023f36: Fix minor warning in DWARFVerifier. (authored by zinovy.nis).
Fix minor warning in DWARFVerifier.
Oct 20 2019, 12:58 AM
zinovy.nis committed rL375357: Fix minor warning in DWARFVerifier..
Fix minor warning in DWARFVerifier.
Oct 20 2019, 12:57 AM

Aug 4 2019

zinovy.nis committed rG6d83ab0870c4: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor (authored by zinovy.nis).
[clang-tidy] Add FixItHint for performance-noexcept-move-constructor
Aug 4 2019, 6:37 AM
zinovy.nis committed rL367785: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor.
[clang-tidy] Add FixItHint for performance-noexcept-move-constructor
Aug 4 2019, 6:32 AM
zinovy.nis closed D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor.
Aug 4 2019, 6:32 AM · Restricted Project, Restricted Project

Jul 23 2019

zinovy.nis updated the diff for D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor.
Jul 23 2019, 11:56 PM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor.
  • Fixed tests.
Jul 23 2019, 11:55 PM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor.
Jul 23 2019, 11:30 PM · Restricted Project, Restricted Project

Jul 22 2019

zinovy.nis updated the diff for D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor.
Jul 22 2019, 10:54 AM · Restricted Project, Restricted Project
zinovy.nis created D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor.
Jul 22 2019, 10:54 AM · Restricted Project, Restricted Project

Apr 3 2019

zinovy.nis added a comment to D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.

@alexfh, do you still have any objections?

Apr 3 2019, 1:29 AM · Restricted Project, Restricted Project

Apr 1 2019

zinovy.nis added a comment to D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.

Why not just use clang-tidy-diff.py? The clang-tidy-diff.py script has a distinct and somewhat self-documenting name and a very specific purpose (find clang-tidy regressions in a patch), while run-clang-tidy.py is more focused on running over larger bodies of code with a purpose of analyzing or cleaning up. Is there any benefit in having all functionality in run-clang-tidy.py?

Apr 1 2019, 5:11 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.

Gentle ping.

Apr 1 2019, 3:29 AM · Restricted Project, Restricted Project

Mar 31 2019

zinovy.nis updated the diff for D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.

Added a test.

Mar 31 2019, 12:47 PM · Restricted Project, Restricted Project

Mar 28 2019

zinovy.nis added a comment to D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.

Can we delete clang-tidy-diff.py with this? (Or delete most of its contents and make it forward to this script?)

Mar 28 2019, 11:27 PM · Restricted Project, Restricted Project

Mar 27 2019

zinovy.nis committed rGf8b7269f983a: [clang-tidy] Handle missing yaml module in run-clang-tidy.py (authored by zinovy.nis).
[clang-tidy] Handle missing yaml module in run-clang-tidy.py
Mar 27 2019, 12:20 PM
zinovy.nis committed rCTE357114: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
[clang-tidy] Handle missing yaml module in run-clang-tidy.py
Mar 27 2019, 12:20 PM
zinovy.nis committed rL357114: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
[clang-tidy] Handle missing yaml module in run-clang-tidy.py
Mar 27 2019, 12:20 PM
zinovy.nis closed D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Mar 27 2019, 12:20 PM · Restricted Project, Restricted Project, Restricted Project

Mar 25 2019

zinovy.nis updated the diff for D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Mar 25 2019, 10:22 AM · Restricted Project, Restricted Project, Restricted Project
zinovy.nis added inline comments to D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Mar 25 2019, 10:16 AM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2019

zinovy.nis updated the diff for D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Mar 23 2019, 5:40 AM · Restricted Project, Restricted Project, Restricted Project
zinovy.nis added inline comments to D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Mar 23 2019, 5:40 AM · Restricted Project, Restricted Project, Restricted Project
zinovy.nis created D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Mar 23 2019, 5:37 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2019

zinovy.nis committed rG72bb9a65d62a: Reland r356547 after fixing the YAML module missing issue. (authored by zinovy.nis).
Reland r356547 after fixing the YAML module missing issue.
Mar 21 2019, 1:33 AM
zinovy.nis committed rCTE356649: Reland r356547 after fixing the YAML module missing issue..
Reland r356547 after fixing the YAML module missing issue.
Mar 21 2019, 1:33 AM
zinovy.nis committed rL356649: Reland r356547 after fixing the YAML module missing issue..
Reland r356547 after fixing the YAML module missing issue.
Mar 21 2019, 1:33 AM

Mar 20 2019

zinovy.nis committed rGaf8817570456: [clang-tidy] Fix redundant check breaking the test on many platforms. (authored by zinovy.nis).
[clang-tidy] Fix redundant check breaking the test on many platforms.
Mar 20 2019, 11:37 AM
zinovy.nis committed rCTE356589: [clang-tidy] Fix redundant check breaking the test on many platforms..
[clang-tidy] Fix redundant check breaking the test on many platforms.
Mar 20 2019, 11:36 AM
zinovy.nis committed rL356589: [clang-tidy] Fix redundant check breaking the test on many platforms..
[clang-tidy] Fix redundant check breaking the test on many platforms.
Mar 20 2019, 11:36 AM
zinovy.nis added inline comments to rG538fb72226cf: Reland r356547 after fixing the tests for Linux..
Mar 20 2019, 8:54 AM
zinovy.nis committed rG538fb72226cf: Reland r356547 after fixing the tests for Linux. (authored by zinovy.nis).
Reland r356547 after fixing the tests for Linux.
Mar 20 2019, 8:50 AM
zinovy.nis committed rL356565: Reland r356547 after fixing the tests for Linux..
Reland r356547 after fixing the tests for Linux.
Mar 20 2019, 8:49 AM
zinovy.nis committed rCTE356565: Reland r356547 after fixing the tests for Linux..
Reland r356547 after fixing the tests for Linux.
Mar 20 2019, 8:49 AM
zinovy.nis committed rG4bfe83679d6f: [clang-tidy] Cosmetic fix (authored by zinovy.nis).
[clang-tidy] Cosmetic fix
Mar 20 2019, 4:34 AM
zinovy.nis committed rCTE356548: [clang-tidy] Cosmetic fix.
[clang-tidy] Cosmetic fix
Mar 20 2019, 4:34 AM
zinovy.nis committed rL356548: [clang-tidy] Cosmetic fix.
[clang-tidy] Cosmetic fix
Mar 20 2019, 4:34 AM
zinovy.nis committed rGd3939d2013e9: [clang-tidy] Parallelize clang-tidy-diff.py (authored by zinovy.nis).
[clang-tidy] Parallelize clang-tidy-diff.py
Mar 20 2019, 4:30 AM
zinovy.nis committed rCTE356547: [clang-tidy] Parallelize clang-tidy-diff.py.
[clang-tidy] Parallelize clang-tidy-diff.py
Mar 20 2019, 4:29 AM
zinovy.nis committed rL356547: [clang-tidy] Parallelize clang-tidy-diff.py.
[clang-tidy] Parallelize clang-tidy-diff.py
Mar 20 2019, 4:29 AM
zinovy.nis closed D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Mar 20 2019, 4:29 AM · Restricted Project, Restricted Project

Mar 19 2019

zinovy.nis added a comment to D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.

How is this functionality different from the clang-tidy-diff.py script with the -j option being added in the other patch?

Mar 19 2019, 10:10 PM · Restricted Project, Restricted Project
zinovy.nis added a comment to D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.

Any comments?

Mar 19 2019, 12:09 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

One more gentle ping.

Mar 19 2019, 12:08 AM · Restricted Project, Restricted Project

Mar 16 2019

zinovy.nis updated the summary of D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.
Mar 16 2019, 3:19 AM · Restricted Project, Restricted Project
zinovy.nis created D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py.
Mar 16 2019, 3:16 AM · Restricted Project, Restricted Project

Mar 8 2019

zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Gentle ping.

Mar 8 2019, 8:49 AM · Restricted Project, Restricted Project

Mar 6 2019

zinovy.nis updated the diff for D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
  • honest '--export-fixes': multiple yamls are merged into the resulting one.
  • minor cosmetic fixes.
Mar 6 2019, 12:35 PM · Restricted Project, Restricted Project
zinovy.nis retitled D57662: [clang-tidy] Parallelize clang-tidy-diff.py from [clang-tidy] Parallelise clang-tidy-diff.py to [clang-tidy] Parallelize clang-tidy-diff.py .
Mar 6 2019, 9:52 AM · Restricted Project, Restricted Project

Feb 22 2019

zinovy.nis added inline comments to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 22 2019, 12:17 AM · Restricted Project, Restricted Project

Feb 19 2019

zinovy.nis updated the diff for D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
  • -j is 1 by default;
  • fixed minor remarks;
Feb 19 2019, 11:43 AM · Restricted Project, Restricted Project

Feb 15 2019

zinovy.nis added inline comments to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 15 2019, 6:40 AM · Restricted Project, Restricted Project

Feb 14 2019

zinovy.nis added inline comments to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 14 2019, 1:43 AM · Restricted Project, Restricted Project

Feb 13 2019

zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Any comments?

Feb 13 2019, 10:55 AM · Restricted Project, Restricted Project

Feb 12 2019

zinovy.nis updated the diff for D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

-j and -export-fixes were made mutually exclusive.

Feb 12 2019, 10:44 AM · Restricted Project, Restricted Project

Feb 11 2019

zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

I only say this because I think I might have seen it happen when I was running run-clang-tidy.py over a large code base with a fairly aggressive check/fixit, but frankly I was too new to LLVM to know it wasn't something I might have done wrong.

Feb 11 2019, 3:26 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Just a question.. If clang tidy is running with -fix in parallel, what stops each clang-tidy invocation altering a common header at the same time?

Feb 11 2019, 3:01 AM · Restricted Project, Restricted Project

Feb 10 2019

zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Gentle ping.

Feb 10 2019, 10:19 PM · Restricted Project, Restricted Project

Feb 4 2019

zinovy.nis updated the diff for D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 4 2019, 10:39 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Fixed minor typos.

Feb 4 2019, 10:30 AM · Restricted Project, Restricted Project

Feb 3 2019

zinovy.nis created D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 3 2019, 11:29 AM · Restricted Project, Restricted Project

Jan 22 2019

zinovy.nis committed rCTE351925: [doc] Fix svn property for bugprone-parent-virtual-call.rst.
[doc] Fix svn property for bugprone-parent-virtual-call.rst
Jan 22 2019, 10:47 PM
zinovy.nis committed rL351925: [doc] Fix svn property for bugprone-parent-virtual-call.rst.
[doc] Fix svn property for bugprone-parent-virtual-call.rst
Jan 22 2019, 10:47 PM
zinovy.nis committed rL351867: [doc] Replace 'class' with 'struct' for 'public' by default.
[doc] Replace 'class' with 'struct' for 'public' by default
Jan 22 2019, 12:27 PM
zinovy.nis committed rCTE351867: [doc] Replace 'class' with 'struct' for 'public' by default.
[doc] Replace 'class' with 'struct' for 'public' by default
Jan 22 2019, 12:27 PM

Oct 12 2018

zinovy.nis committed rCTE344343: [clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK.
[clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK
Oct 12 2018, 6:38 AM
zinovy.nis committed rL344343: [clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK.
[clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK
Oct 12 2018, 6:37 AM