Page MenuHomePhabricator

zinovy.nis (Zinovy Nis)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2014, 7:51 AM (385 w, 3 h)

Recent Activity

Dec 11 2020

zinovy.nis committed rG709112bce442: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of… (authored by zinovy.nis).
[clang-tidy] false-positive for bugprone-redundant-branch-condition in case of…
Dec 11 2020, 10:10 AM
zinovy.nis closed D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params.
Dec 11 2020, 10:10 AM · Restricted Project, Restricted Project

Dec 5 2020

zinovy.nis updated the diff for D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params.

Fixed remarks from Aaron.

Dec 5 2020, 4:11 AM · Restricted Project, Restricted Project

Nov 29 2020

zinovy.nis added a comment to D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params.

What do you think of it?

Nov 29 2020, 6:54 AM · Restricted Project, Restricted Project

Nov 25 2020

zinovy.nis updated the diff for D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params.

Handle ref & val mixed cases.

Nov 25 2020, 10:00 AM · Restricted Project, Restricted Project

Nov 18 2020

zinovy.nis added inline comments to D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params.
Nov 18 2020, 11:58 AM · Restricted Project, Restricted Project

Nov 15 2020

zinovy.nis updated the diff for D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params.

Extend the context.

Nov 15 2020, 7:23 AM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 15 2020, 7:19 AM · Restricted Project, Restricted Project
zinovy.nis requested review of D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params.
Nov 15 2020, 7:19 AM · Restricted Project, Restricted Project

Nov 13 2020

zinovy.nis added a comment to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.

LGTM!

Nov 13 2020, 10:04 PM · Restricted Project, Restricted Project
zinovy.nis committed rG4364539b3a4c: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on… (authored by zinovy.nis).
[clang-tidy] Fix crash in bugprone-redundant-branch-condition on…
Nov 13 2020, 10:03 PM
zinovy.nis closed D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 13 2020, 10:02 PM · Restricted Project, Restricted Project

Nov 12 2020

zinovy.nis added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 12 2020, 10:03 AM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 12 2020, 9:09 AM · Restricted Project, Restricted Project

Nov 11 2020

zinovy.nis added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 11 2020, 10:10 PM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.

Fixed fix-it section.

Nov 11 2020, 10:09 PM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 11 2020, 9:58 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.

Use IgnoreParenImpCasts

Nov 11 2020, 9:56 AM · Restricted Project, Restricted Project

Nov 10 2020

zinovy.nis added a comment to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.

Taking a step back, rather than worrying about if its an ExprWithCleanups. Shouldn't we just get the condition removing all implicit nodes.

const Expr* Cond = InnerIf->getCond()->ignoreImplicit();

This has to be simpler and will likely future proof this against any other implicit nodes potentially added in future that can appear between the Condition and the binary operator.

Nov 10 2020, 10:15 PM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 10 2020, 10:12 PM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.

Simplified to use IgnoreImplicit().

Nov 10 2020, 10:11 PM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 10 2020, 11:43 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.

dyn_cast_or_null -> dyn_cast

Nov 10 2020, 11:41 AM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 10 2020, 11:35 AM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 10 2020, 10:02 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.

*iterator -> getSubExpr()

Nov 10 2020, 10:01 AM · Restricted Project, Restricted Project

Nov 8 2020

zinovy.nis updated the diff for D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.

auto -> const auto.

Nov 8 2020, 9:11 PM · Restricted Project, Restricted Project
zinovy.nis added a comment to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.

Think this has an incorrect name, seems to have something to do with bugprone-redundant-branch-condition

Nov 8 2020, 9:05 PM · Restricted Project, Restricted Project
zinovy.nis retitled D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups from [clang-tidy][bugprone-use-after-mnove] Warn on std::move for consts to [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 8 2020, 9:04 PM · Restricted Project, Restricted Project
zinovy.nis added a reviewer for D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups: baloghadamsoftware.
Nov 8 2020, 11:43 AM · Restricted Project, Restricted Project
zinovy.nis requested review of D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 8 2020, 11:42 AM · Restricted Project, Restricted Project

Oct 11 2020

zinovy.nis committed rG32d565b4618d: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs (authored by zinovy.nis).
[clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs
Oct 11 2020, 8:53 AM
zinovy.nis closed D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs.
Oct 11 2020, 8:53 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs.

I am fine now, thank you!

Oct 11 2020, 8:43 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs.
Oct 11 2020, 8:27 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs.

LGTM.
Short reminder to please use full context patches. Its not an issue right now, but review sometimes just needs the context to understand the changes :)

Oct 11 2020, 8:13 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs.

Full diff.

Oct 11 2020, 8:06 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs.

Done. Any other comments/ideas?

Oct 11 2020, 7:56 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs.
  • Updated docs on the matcher.
  • Register the new matcher.
Oct 11 2020, 7:55 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs.
Oct 11 2020, 6:22 AM · Restricted Project, Restricted Project

Oct 10 2020

zinovy.nis requested review of D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs.
Oct 10 2020, 11:37 AM · Restricted Project, Restricted Project

Sep 15 2020

zinovy.nis committed rG96c6d012dfe2: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class (authored by zinovy.nis).
[clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class
Sep 15 2020, 10:14 PM
zinovy.nis closed D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class.
Sep 15 2020, 10:14 PM · Restricted Project, Restricted Project
zinovy.nis added a comment to D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class.

Done.

Sep 15 2020, 10:57 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class.
  • Fixed the test.
  • Fixed clang-format issues.
Sep 15 2020, 10:56 AM · Restricted Project, Restricted Project

Sep 14 2020

zinovy.nis requested review of D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class.
Sep 14 2020, 12:37 PM · Restricted Project, Restricted Project

Jun 5 2020

zinovy.nis added a comment to D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.

How are you landing these changes, because the commit message isn't lining up with the PR name?

Jun 5 2020, 10:35 AM · Restricted Project, Restricted Project
zinovy.nis committed rGc063b4a72bb3: Fix crash on misc-redundant-expression (authored by zinovy.nis).
Fix crash on misc-redundant-expression
Jun 5 2020, 8:56 AM
zinovy.nis closed D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.
Jun 5 2020, 8:55 AM · Restricted Project, Restricted Project

Jun 4 2020

zinovy.nis added inline comments to D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.
Jun 4 2020, 11:00 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.

Simplify test.

Jun 4 2020, 11:00 AM · Restricted Project, Restricted Project
zinovy.nis committed rG6271b96bef47: [clang-tidy][modernize-loop-convert] Make loop var type human readable (authored by zinovy.nis).
[clang-tidy][modernize-loop-convert] Make loop var type human readable
Jun 4 2020, 9:55 AM
zinovy.nis closed D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable.
Jun 4 2020, 9:54 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.

@njames93, @aaron.ballman do you have any other comments?

Jun 4 2020, 1:02 AM · Restricted Project, Restricted Project

Jun 1 2020

zinovy.nis added a comment to D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.
Jun 1 2020, 11:58 PM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.
  • Fix test.
  • Simplify the code.
Jun 1 2020, 3:09 AM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.
Jun 1 2020, 3:09 AM · Restricted Project, Restricted Project
zinovy.nis retitled D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr from [clang-tidy][misc-redundant-expression] Fix crash on CXXFoldExpr to [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.
Jun 1 2020, 3:09 AM · Restricted Project, Restricted Project

May 31 2020

zinovy.nis updated the diff for D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.

Fix and simplify the condition.

May 31 2020, 11:57 PM · Restricted Project, Restricted Project
zinovy.nis added reviewers for D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr: alexfh, aaron.ballman.
May 31 2020, 1:02 PM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.

Fix formatting.

May 31 2020, 1:02 PM · Restricted Project, Restricted Project
zinovy.nis created D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr.
May 31 2020, 12:14 PM · Restricted Project, Restricted Project

May 29 2020

zinovy.nis added a comment to D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable.

@njames93, @aaron.ballman do you have any other questions/comments?

May 29 2020, 10:21 AM · Restricted Project, Restricted Project

May 26 2020

zinovy.nis added a comment to D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable.

I'm having trouble with the reproduction of this - https://godbolt.org/z/tsMfcj.
Aside from that this needs some test cases to demonstrate the patch is indeed working

May 26 2020, 11:22 PM · Restricted Project, Restricted Project
zinovy.nis added a reviewer for D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable: aaron.ballman.
May 26 2020, 4:50 AM · Restricted Project, Restricted Project

May 25 2020

zinovy.nis updated the summary of D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable.
May 25 2020, 11:25 PM · Restricted Project, Restricted Project
zinovy.nis created D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable.
May 25 2020, 11:25 PM · Restricted Project, Restricted Project

Apr 22 2020

zinovy.nis abandoned D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Apr 22 2020, 11:58 AM · Restricted Project, Restricted Project

Apr 21 2020

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

One more gentle ping)

Apr 21 2020, 11:57 PM · Restricted Project, Restricted Project

Apr 5 2020

zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Rebase over the current master.

Apr 5 2020, 2:39 AM · Restricted Project, Restricted Project

Mar 24 2020

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Gentle ping)

Mar 24 2020, 12:30 AM · Restricted Project, Restricted Project

Mar 15 2020

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

I still think this entire patch is misguided; there's no reason to make the note for const std::string s; std::move(s) any longer than the note for int i; std::move(i) or volatile std::string v; std::move(v). People should not be using moved-from objects, period; and those who want to use moved-from objects, should not enable this clang-tidy check.

However, I have no further comments besides philosophical opposition to the whole idea.

Mar 15 2020, 3:11 AM · Restricted Project, Restricted Project

Mar 14 2020

zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Removed top-level consts.

Mar 14 2020, 12:20 PM · Restricted Project, Restricted Project

Mar 11 2020

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

I'm done, Aaron, Quuxplusone, do you have any comments?

Mar 11 2020, 12:09 AM · Restricted Project, Restricted Project

Mar 8 2020

zinovy.nis added inline comments to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Mar 8 2020, 3:43 AM · Restricted Project, Restricted Project
zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Anyway, I still don't see the point of this patch. It seems like you're just duplicating the work of performance-move-const-arg. People who want to be shown notes about moves-of-const-args should just enable that check instead.

Mar 8 2020, 3:10 AM · Restricted Project, Restricted Project

Mar 7 2020

zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Cosmetic and style fixes.

Mar 7 2020, 12:01 AM · Restricted Project, Restricted Project
zinovy.nis added inline comments to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Mar 7 2020, 12:01 AM · Restricted Project, Restricted Project

Mar 6 2020

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Any further comments?

Mar 6 2020, 2:12 AM · Restricted Project, Restricted Project

Mar 3 2020

zinovy.nis updated the summary of D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Mar 3 2020, 12:36 PM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Typo fixed.

Mar 3 2020, 11:57 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
  1. Special handling for captured variables in lambdas,
  2. messages texts were changed.
Mar 3 2020, 11:57 AM · Restricted Project, Restricted Project

Feb 26 2020

zinovy.nis added inline comments to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 26 2020, 7:56 AM · Restricted Project, Restricted Project
zinovy.nis abandoned D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks.
Feb 26 2020, 2:34 AM · Restricted Project

Feb 25 2020

zinovy.nis updated the summary of D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks.
Feb 25 2020, 10:25 PM · Restricted Project
zinovy.nis added reviewers for D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks: dlj, alexfh.
Feb 25 2020, 9:58 PM · Restricted Project
zinovy.nis retitled D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts from [clang-tidy] Make bugprone-use-after-move ignore std::move for const values to [clang-tidy][bugprone-use-after-mnove] Warn on std::move for consts.
Feb 25 2020, 9:49 PM · Restricted Project, Restricted Project
zinovy.nis updated the summary of D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 25 2020, 9:49 PM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Warning on use after move is still generated. But there's also an additional note

Feb 25 2020, 9:49 PM · Restricted Project, Restricted Project

Feb 23 2020

zinovy.nis created D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks.
Feb 23 2020, 9:15 AM · Restricted Project

Feb 20 2020

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

(I sent this to the mailing list, but I guess it doesn't show up here unless I do it through Phab. Quoting myself—)

I see your point about how users who care should always be passing this check alongside "performance-move-const-arg"; but IMHO it still makes sense for clang-tidy to warn unconditionally about code of the form

x = std::move(y);
use(y);

regardless of the incidental type of y. Sure, it's technically not wrong if y is const... or if y is a primitive type, such as Widget*... or if y is a well-defined library type, such as std::shared_ptr<Widget>... or if y is a library type that works in practice, such as std::list<int>... but regardless of its technical merits, the code is still logically semantically wrong, and I think that's what the clang-tidy check should be trying to diagnose.

Feb 20 2020, 12:57 AM · Restricted Project, Restricted Project

Feb 17 2020

zinovy.nis added a comment to D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.

Even if no move actually happens, the code is still wrong

Feb 17 2020, 12:02 PM · Restricted Project, Restricted Project

Feb 16 2020

zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 16 2020, 7:43 AM · Restricted Project, Restricted Project
zinovy.nis updated the summary of D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 16 2020, 7:34 AM · Restricted Project, Restricted Project
zinovy.nis updated the summary of D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 16 2020, 7:27 AM · Restricted Project, Restricted Project
zinovy.nis updated the diff for D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 16 2020, 7:25 AM · Restricted Project, Restricted Project
zinovy.nis created D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts.
Feb 16 2020, 7:25 AM · Restricted Project, Restricted Project

Dec 29 2019

zinovy.nis added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

@zinovy.nis @alexfh @JonasToth @MyDeveloperDay

I'd be happy to provide a patch.

Dec 29 2019, 3:34 AM · Restricted Project, Restricted Project

Dec 1 2019

zinovy.nis accepted D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script.
Dec 1 2019, 10:33 AM · Restricted Project

Nov 3 2019

zinovy.nis added inline comments to D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script.
Nov 3 2019, 7:07 AM · Restricted Project