This is an archive of the discontinued LLVM Phabricator instance.

python bindings: expose the clang version string
AcceptedPublic

Authored by john.tornblom on Mar 25 2016, 12:23 PM.

Details

Reviewers
compnerd
eliben

Diff Detail

Event Timeline

john.tornblom retitled this revision from to python bindings: expose the clang version string.
john.tornblom updated this object.
john.tornblom added reviewers: eliben, compnerd.
john.tornblom added a subscriber: cfe-commits.

Any suggestions on how to test this? Just check for non-empty string?

compnerd edited edge metadata.Aug 7 2016, 10:09 PM

Hmm, could do something devious. Write the test and run that through the c preprocessor and then use that to compare the string. Ugly, but would be completely generic and ensure that we see the value we expect always.

compnerd accepted this revision.Apr 19 2017, 6:19 PM
compnerd added a subscriber: jbcoe.

This would ideally wait for the change that @jbcoe has in the works to enable python 3, but the change itself is fine.

This revision is now accepted and ready to land.Apr 19 2017, 6:19 PM
shafik added a subscriber: shafik.Sep 21 2023, 8:58 AM

@compnerd is this still relevant?

Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2023, 8:58 AM
Herald added a subscriber: arphaman. · View Herald Transcript