This is an archive of the discontinued LLVM Phabricator instance.

[sanitizier] initializing common flags.
ClosedPublic

Authored by aizatsky on Mar 21 2016, 1:27 PM.

Reviewers

Commits

Summary

Without SetDefaults() CommonFlags contain garbage.

aizatsky retitled this revision from to [sanitizier] initializing common flags..

aizatsky updated this object.

aizatsky added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Mar 21 2016, 1:30 PM

don't we need to do activation/deactivation copying for html_cov_report?

In D18326#379689, @vitalybuka wrote:

don't we need to do activation/deactivation copying for html_cov_report?

Frankly, I don't know. Alexei, what's the logic behind all this? Why some flags are copied and most are not?

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

asan/

1 line

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines	#undef COMMON_ACTIVATION_FLAG
}		}

void OverrideFromActivationFlags() {		void OverrideFromActivationFlags() {
Flags f;		Flags f;
CommonFlags cf;		CommonFlags cf;
FlagParser parser;		FlagParser parser;
RegisterActivationFlags(&parser, &f, &cf);		RegisterActivationFlags(&parser, &f, &cf);

		cf.SetDefaults();
// Copy the current activation flags.		// Copy the current activation flags.
allocator_options.CopyTo(&f, &cf);		allocator_options.CopyTo(&f, &cf);
cf.malloc_context_size = malloc_context_size;		cf.malloc_context_size = malloc_context_size;
f.poison_heap = poison_heap;		f.poison_heap = poison_heap;
cf.coverage = coverage;		cf.coverage = coverage;
cf.coverage_dir = coverage_dir;		cf.coverage_dir = coverage_dir;
cf.verbosity = Verbosity();		cf.verbosity = Verbosity();
cf.help = false; // this is activation-specific help		cf.help = false; // this is activation-specific help
▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines