Page MenuHomePhabricator

Modify llvm-objdump to print disassembly failures inline
ClosedPublic

Authored by colinl on Mar 17 2016, 12:49 PM.

Details

Summary

Two major problems exist with the current way failed disassembly is printed. Warnings are printed to stderr which is not synchronized with stdout, leading to confusing output and if someone is trying to pipe output to a file, warnings are still printed out to the command line.

This patch prints the text "<unknown>" where the instruction text would have been, had disassembly succeeded.

Diff Detail

Repository
rL LLVM

Event Timeline

colinl updated this revision to Diff 50967.Mar 17 2016, 12:49 PM
colinl retitled this revision from to Modify llvm-objdump to print disassembly failures inline.
colinl updated this object.
colinl added reviewers: davide, sidneym, shankare.
colinl set the repository for this revision to rL LLVM.
colinl added a subscriber: llvm-commits.
rnk accepted this revision.Mar 17 2016, 1:01 PM
rnk added a reviewer: rnk.
rnk added a subscriber: rnk.

lgtm

This revision is now accepted and ready to land.Mar 17 2016, 1:01 PM
colinl closed this revision.Mar 18 2016, 9:35 AM

Committed in r263793