Page MenuHomePhabricator

[MC] Rename TLSCALL as it's not ARM specific
ClosedPublic

Authored by davide on Mar 14 2016, 2:32 PM.

Details

Summary

MCSymbolRefExpr variant kind for TLSCALL is prefixed with _ARM_ since it was originally implemented.
I'm currently implementing the X86_64 version(s) described here http://www.fsfla.org/~lxoliva/writeups/TLS/RFC-TLSDESC-x86.txt and noticed that the assembler for both of them is:

symbol@TLSCALL(%register)

I think it makes sense to rename VK_ARM_TLSCALL to VK_TLSCALL (this may also be true for TLSDESC) and implement the correct semantic action in the machine-dependent code. Any objections?

Diff Detail

Repository
rL LLVM

Event Timeline

davide updated this revision to Diff 50647.Mar 14 2016, 2:32 PM
davide retitled this revision from to [MC] Rename TLSCALL as it's not ARM specific.
davide updated this object.
davide added reviewers: rafael, echristo, compnerd.
davide added a subscriber: llvm-commits.

No objections from me, if the semantics are identical on all targets. AFAIK, they are, so... LGTM.

rafael accepted this revision.Mar 14 2016, 5:19 PM
rafael edited edge metadata.

LGTM. Thanks

This revision is now accepted and ready to land.Mar 14 2016, 5:19 PM
This revision was automatically updated to reflect the committed changes.