This is an archive of the discontinued LLVM Phabricator instance.

Refactor D17884 solution to use xmacro idiom
AbandonedPublic

Authored by hintonda on Mar 14 2016, 1:48 PM.

Details

Summary

As recomended by Amjad, this is a follow on to D17884.

It uses the xmacro idiom and addresses Dave's concerns about relying
on, and exposing, implemetation details.

Diff Detail

Event Timeline

hintonda updated this revision to Diff 50642.Mar 14 2016, 1:48 PM
hintonda retitled this revision from to Refactor D17884 solution to use xmacro idiom.
hintonda updated this object.
hintonda added reviewers: aaboud, dblaikie, aprantl.
hintonda added a subscriber: llvm-commits.
dblaikie resigned from this revision.Mar 25 2016, 3:46 PM
dblaikie removed a reviewer: dblaikie.

I don't think this is too much of an improvement over what we ended up with - no big deal. Thanks for the example, though.

hintonda abandoned this revision.Apr 17 2016, 9:34 PM